From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5941DA3160 for ; Wed, 9 Oct 2019 13:24:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2932D1DFE4; Wed, 9 Oct 2019 13:24:24 +0200 (CEST) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 6ED411C211; Wed, 9 Oct 2019 13:24:22 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 7E960B4005F; Wed, 9 Oct 2019 11:24:20 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 9 Oct 2019 12:24:12 +0100 To: Tiwei Bie , Ferruh Yigit , Thomas Monjalon CC: Maxime Coquelin , Zhihong Wang , , Dilshod Urazov , References: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com> <1569944672-24754-3-git-send-email-arybchenko@solarflare.com> <20191008054650.GA22478@___> <20191009084341.GA32515@___> <43e11493-65d6-fdf2-8086-106ed7b4eb25@solarflare.com> <20191009104143.GA14695@___> From: Andrew Rybchenko Message-ID: <97813cf0-78c1-8ff3-5b36-b3423a9141ce@solarflare.com> Date: Wed, 9 Oct 2019 14:24:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191009104143.GA14695@___> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24964.003 X-TM-AS-Result: No-22.667800-8.000000-10 X-TMASE-MatchedRID: ZFzIhWOuIzv4ECMHJTM/ubxygpRxo46969aS+7/zbj+qvcIF1TcLYHPs gxK9Wga5feLMdo7pGOSLJR4t9fq1XJv831J4kXLFSHCU59h5KrFuwUsg2ZgJ8fwl4RWl2uGKhp4 SQh/ttLfeTHPmCCrjc6QMPmUuEsM3ofaD2zI+zzw/ApMPW/xhXkyQ5fRSh265V7MQTbTl029GHT QYY9oPPxJEQOxaUVFwvi6EqsH0DOv1fjWzduyGVjIjK23O9D33pvDLLlsAH/1QKAQSutQYXP4mH prMacH/qUirzUPTZU8mk8NN5/8GDr4woKbwwuNB5Qo03mEdwAF6QyBM5BtUW1XWVD8efRM6qvxi D/jBnTlk2pw5YjLA94XeZCN6PfjPgFZcSmL3XQzG9W0D68BZzGOJthub07Sw+ncGmJHI9ZVbJHG A/RgNqzNtjON64kNqdBcEqTbszsAwO9k8xu9MPlMsVuL5ry7dD6NL4tGmXzW9riHHO5UXuMZzCC 0RExuZl01ZbKu65x3bxr7tz8rCpDi80gTpPdTOGUlF/M3Dxp/pCJPdKwF/IZsoi2XrUn/JyeMtM D9QOgChMIDkR/KfwI2j49Ftap9EkGUtrowrXLg= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--22.667800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24964.003 X-MDID: 1570620261-WQCDzDiKnEKS Subject: Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" @Thomas, @Ferruh, please see small question below. On 10/9/19 1:41 PM, Tiwei Bie wrote: > On Wed, Oct 09, 2019 at 12:00:28PM +0300, Andrew Rybchenko wrote: >> On 10/9/19 11:43 AM, Tiwei Bie wrote: >>> On Wed, Oct 09, 2019 at 11:04:38AM +0300, Andrew Rybchenko wrote: >>>> On 10/8/19 8:46 AM, Tiwei Bie wrote: >>>>> On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: >>>>>> From: Dilshod Urazov >>>>>> >>>>>> This driver supports none of DCB, RSS or VMDQ modes, >>>>>> therefore must check and return error if configured incorrectly. >>>>>> >>>>>> Fixes: c1f86306a026 ("virtio: add new driver") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Dilshod Urazov >>>>>> Signed-off-by: Andrew Rybchenko >>>>>> --- >>>>>> drivers/net/virtio/virtio_ethdev.c | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >>>>>> index 7261109dd..0af4fc392 100644 >>>>>> --- a/drivers/net/virtio/virtio_ethdev.c >>>>>> +++ b/drivers/net/virtio/virtio_ethdev.c >>>>>> @@ -2071,6 +2071,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) >>>>>> PMD_INIT_LOG(DEBUG, "configure"); >>>>>> req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES; >>>>>> + if (rxmode->mq_mode != ETH_MQ_RX_NONE) { >>>>>> + PMD_DRV_LOG(ERR, >>>>>> + "Unsupported Rx multi queue mode %d", >>>>>> + rxmode->mq_mode); >>>>>> + return -EINVAL; >>>>>> + } >>>>> We need similar checks for Tx as well. >>>> OK, I'll add. >>>> >>>> However, I'm not 100% sure about RSS. Yes, I know that virtio has >>>> no RSS configuration support, but it looks possible to have multi queue >>>> in vhost-net case. >>> Yeah, it's possible to have MQ in virtio. >>> The RSS support in virtio is still WIP. >>> https://github.com/oasis-tcs/virtio-spec/issues/48 >> Thanks for the link. So, may be ETH_MQ_RX_RSS should be accepted >> as well, but attempts to configure RSS rejected? >> Yes, it is a bit strange to accept RSS with empty rss_hf etc, but >> at least it is exactly what net/virtio can do. >> >> And one more thought... >> It looks like if more than one Rx queue is configured, mq_mode must >> be ETH_MQ_RX_RSS and must not be ETH_MQ_RX_NONE. > Some apps in DPDK will set mq_mode to ETH_MQ_RX_NONE while > enabling multiple queue pairs, e.g.: > > https://github.com/DPDK/dpdk/blob/5b5bb56532fd5dea5d6260c0a0e405c0e32da2a0/app/test/test_link_bonding.c#L137 > https://github.com/DPDK/dpdk/blob/5b5bb56532fd5dea5d6260c0a0e405c0e32da2a0/app/test/test_link_bonding.c#L181-L182 > https://github.com/DPDK/dpdk/blob/5b5bb56532fd5dea5d6260c0a0e405c0e32da2a0/app/test/test_link_bonding.c#L3938-L3948 > > Testpmd will also set mq_mode to ETH_MQ_RX_NONE when multiple > Rx queues are enabled but rss_hf is empty: > > https://github.com/DPDK/dpdk/blob/5b5bb56532fd5dea5d6260c0a0e405c0e32da2a0/app/test-pmd/testpmd.c#L2935-L2938 > https://github.com/DPDK/dpdk/blob/5b5bb56532fd5dea5d6260c0a0e405c0e32da2a0/app/test-pmd/testpmd.c#L2945-L2948 > (the flow_type_rss_offloads reported by virtio-PMD is zero) > > My understanding is that, setting mq_mode to ETH_MQ_RX_NONE means > no method is enforced on how to route packets to MQs. I'm not sure. It is definitely a place to be improved in ethdev documentation. Thomas, Ferruh, what do you think? Is it really a definition of ETH_MQ_RX_NONE? > It looks that ETH_MQ_RX_NONE is the best fit for virtio currently. Anyway I agree and I think it is better to go this way in the patch. Thanks, Andrew.