From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EC1C42B6F; Mon, 22 May 2023 11:29:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21332410DD; Mon, 22 May 2023 11:29:24 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id D88CB410D1 for ; Mon, 22 May 2023 11:29:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684747763; x=1716283763; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=RMcBNXgQE9Ri1XmTGNiqsaggw/xTWAxLCPCaa4WgG2Y=; b=mPXT/1CSyPJASqVV7ym1V2DYY4+6+2jZXMtnQ5TeN9VTmV+kMqiV6yKN h+6bjEUfvgVHnzePGaN+WiuZOvY1r7/wAD4XXs1EZPBzq4X51NJ7bozHF vxdKqPHmKFmlRbQObKQS4Og7gAvCYFusYNqvGVwTXB17wunUg/h/KZPYQ jPtotI2xjJnykG7s5HC3gwMDAvqvnVJVgfnU0Dk7N7dYLDl9XEvBVvP7e AwPHAwFB3CGB5H6v/J1BIjfazb+fJK/EEKs26irx6oH/dm6mRFcAu5Qh7 0SrkYfwB6WpsQxnDpWPk1HuoIVGJ1a27bXtzFkPbZD6Um7pZl+ztGgZJH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="352895956" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="352895956" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 02:29:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="706459907" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="706459907" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 22 May 2023 02:29:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 02:29:21 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 22 May 2023 02:29:21 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 22 May 2023 02:29:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZBxa9mfg1qq/1eTVTBxRyCBvHyvADIaqJ5K8jf9eYpkRU18VJwdchSFd/x0P573Rv2zvvjuJYKzyzENIZgQthpgnRW7JS3jMotCKmk509RL8mb8JN8d3SOK4pvbx6ZkmNlNVt7ixauRuOU2F6dVCX1ERj0rZTHVa/0zPxdR81dKYv42pGYzHjInXydTXyJAs8grCp8zqoBER74N7QFmFK+ppeNm0/eq1y8E8OS52Aw3Nn5FR+78Dt2kJVLSOcnFIc7FLQr1a7532LcpFOgB5WBYddLm12SsPFxUBZ5FY7jiEygny90Rh988pGAHkfTIRqLxuIfGZOl5U4vEyC9Qx4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbTXncHLAtL6wTHV0fKsJczeaZYRGzib9rt7RDK9Fuk=; b=nDbjZ1AlLPAaDyzTUYScyarz/DVDFGO8MHtZnE5Pp5cbB7PfZQnzL0V6Mfn9aGc5bomnuVN0YZacBUJ994WCZR2Bg+YQqhyDWQUF1l4nKbfF5dy+FOc2EMjoW8LYkROQDrVIfuleIRc+LgACx6yzWyibI2RRplmK8mzXRLsCrKWsORtyqSJ03k6ez0Mnid9evFoFDeGU1DXeXVjn9aVyr4CGCmOxgscow2MbFwF7vRvURNpb36eD9a2AqpGGLV5EZJprAY9d08uoBunczP/Gd7QTHN/FcNDhm3hos7c/vrPzVvIwJSMwXtYZibmCYo7s56GPHUOyLRVK1m9ivPL7Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SA1PR11MB6918.namprd11.prod.outlook.com (2603:10b6:806:2bf::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.27; Mon, 22 May 2023 09:29:16 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%5]) with mapi id 15.20.6411.028; Mon, 22 May 2023 09:29:16 +0000 Message-ID: <9797143a-9ca9-f392-7346-994ac15c5eb9@intel.com> Date: Mon, 22 May 2023 10:29:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH v1] usertools/telemetry: fix unused parameter Content-Language: en-US To: References: <20230518134730.68538-1-samina.arshad@intel.com> From: "Burakov, Anatoly" In-Reply-To: <20230518134730.68538-1-samina.arshad@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB3PR08CA0028.eurprd08.prod.outlook.com (2603:10a6:8::41) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SA1PR11MB6918:EE_ X-MS-Office365-Filtering-Correlation-Id: 88074287-fe1c-41de-fcf9-08db5aa70312 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ED40tjd+j5ly9BSi2dIVsmywS7CsUByY96/bS7Jx7IhPpw4uK1nEU93Y6bdkMTI4xbhKwKyHdC3tGgEBgZ3vJbCqnmYiey636FmfCXM5dHW5L18HOhqM4+2YYyDVF69Sqzk+LL2moGpKGsfsnvOfhgE9vI1Ev9kzEjOFQ7981jc7sqDCfUIPStRPN/XEYEeHKdz2JBZBtnI6Ymh5egQ/ewn91FxYO0ndx74MTd8V0lB9Wi8bl1l4crxoeNOPniPGaK3fNm3A0iTpjq+z9y2P9Cs+ZmswtP9lU0psaNAJerhvqYMPJqezWKarbfLziuIh84BKtMz3jBt6IflchunAqjEU8YuHSZLK/jzD5PWhU9Noiz2Ru6o37AycaAuiCgP9jmQ/oW4EdJxOLenu6xAqCKSF1HcudXSxhpWKVkiAR71OLn44AH1JtlgCYkYCn1RQxkRerzM8jtCUI992t6sjQHUdxK1C/P1ihWw947qtaCQ7/vGYN9ZSkb7nFHWgcIpquNrgzp6A7Z+n2bNe2WB/dM37i+byw6R4QTecdG6DJ4jXhpnTDJ4+eoWhp+KMSDYekWrdRrKKDtUFFeJv2E3Bcmtiwcr20Qo6siJ/YVz37PGjaAFZacd7E9+eh2p7FnQ/qFGGgwRk8SRmd3M5ir5syQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199021)(31686004)(2906002)(5660300002)(83380400001)(8676002)(8936002)(66946007)(41300700001)(66556008)(6916009)(66476007)(316002)(36756003)(6486002)(6666004)(478600001)(2616005)(6512007)(6506007)(26005)(82960400001)(31696002)(86362001)(186003)(53546011)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEFyYythSGl5L00yQjFQRmJETVFscU9hZDgrOHZUTTlQMm5hRDgwNXNBdUZl?= =?utf-8?B?UzF6ejNBQnFZTGkwaG5HVS9LZHBsRzd5bFNJam9IV2xPREt2ZDVSNkxWVFdx?= =?utf-8?B?Z01hdE85RUpNcXVrM1JxelVRT3lvSnI4N2Q1U2J4b2psOXFYeE5JWFVuMHhR?= =?utf-8?B?YVJ1dXVxL3lmL3hPVDBWSTNIYWpyVXFDRkhDUzk4NXVZNWdHYTArZ21INVlk?= =?utf-8?B?U21tTytaMjF4ZzR6dUtHT25TN25kSE81VG9ENUF0QUxCb3lvTUVUTzlHelRF?= =?utf-8?B?VUNybFc1KzNjNURSV05CbXBrbngyVlduQitDWGl5VlkrdHlEcDlXMjFEVlR3?= =?utf-8?B?WVM0cFE1dm5uT1lzZ0FNd1BqM1kyK0U1VzEvVXZKRTZIQVVkNEY2ZmxYdU1Z?= =?utf-8?B?NnNhelpqUEN6U2ZMbngzM2M1aEhsbVZjZjdyQStzMnZrMlcyU2cwNmpQNXV6?= =?utf-8?B?bUVHZnFndTEyMEFnUWNuTkd2cnRZZnpQREo1OGI2N2lrMnF0V1pLOVZUQzFx?= =?utf-8?B?TEFKekE1ZTEwRnVNWU0wVXJzbHVlaThmQW4xeng5aXBWK0hzU3czNHhUcHpP?= =?utf-8?B?dDM0V0dKc2FoTE5ZYWExcS9vVHQyT0R2eVJKMHlFa3plRGNDb3BYNzVVRS9u?= =?utf-8?B?T0dlejU2eVU5d2VrVS9iZ20vQVNZREx6M2E5UXZpTU85QVlFK2s0eDMzZzNF?= =?utf-8?B?QzUvVjY1ZmV6RlNjSkh5ZURxU29xQVI5bWxWeGFLOStJLzE4U3RqQkpMbi96?= =?utf-8?B?QmM4b1c5MkVXR0dyN1d6ZkhDQStvR3IvZ2V4bmZCYWtIQW1kYlB1dGsxYlFz?= =?utf-8?B?NDAwcDFEOG0ycnJNSk1DMHdqaThpZFlxMTlRSzdHVE5RZUQ1MUFDREhINGk1?= =?utf-8?B?K2JPRUE5Rkt0WUJITGxtblY3WmZQWjJtTktlZVk3RjR0SHNqMzc5VktNQ0hy?= =?utf-8?B?ZFFZZjcrb1VGS2htcjBBemlFNUJQVHk1UUJxaVVvZE5hY0hiTlR2Y0FFdjNE?= =?utf-8?B?cGxRaWdvM2Rmd1VqT2tBNmtCVTdyRDQ5NFE5V1dUK0xiVXlTZnFjR0RBN1pq?= =?utf-8?B?T05pRjU2SWJuSEVGOXJxZm9QajJ1ZjU2MzlmdmVOWTZ0Q2ZkVG5aVldVSFla?= =?utf-8?B?VTRvZXp1c3RxblNCWm80NjJNaTYwNTRqWDFvT0JpbnJXVW9NUTJHUHRIMDYw?= =?utf-8?B?a3JRaXFLWmRjTy9ZbUJYZUdDMnQ1MzJJUzZRQWJ6NW1VT00vU1VFakpyY2Z1?= =?utf-8?B?SU42RVEyaFFKaWFvcm1Yb08vUWtYcDhZcDRoUExMVjYydzJhSU1tV3hvMDVn?= =?utf-8?B?Y0ttM3dsb0hWZjFjRUZJZ00zRFgrbTFmcGd5d2FqUThVanZLVnptOFVxemdo?= =?utf-8?B?YnVJeUd1c3grQUFFY1l3OVEwTldROTlTeEZOY3lINWVaOEIrNXFZZVZ3cFgr?= =?utf-8?B?M2c0MVZleWJFRks3VE9TcmpaNjlnM0ZrU2wxazQrMjR0cmlVSy9QWUh4eXpT?= =?utf-8?B?alRmRlJiNm5Oa2FmTyt1V0VWSXpuSXJRL1AyQ3FFa3BsRlhoWnJVYkZXOGtH?= =?utf-8?B?K2dLYlBZZDZSQThyTnMyWHlGMW0rV1NVWXc1L25YVUVaVHhkZmViYkVHOTRR?= =?utf-8?B?dkcrMFZZKzRULzIyYlJBN2VsRUt0SW1nazEzTnN1QlYxNzJjblFxYnc4ZHpy?= =?utf-8?B?WUQ1bi8rWWRMYXE2RjFOdDFVaEEySHRiWHJDZ0d2QnFBSHBXRHpUd2dXNzRj?= =?utf-8?B?WHRUL2t3NEQ0MmovcnFWRFhJNlU4dlRVbU95OUhpcU5KWlJocEFFamZqU0RC?= =?utf-8?B?OU0vZEJoKzJzWnFGNVoxWEtpWTV4Vng4dFlCSTBLZmdXL29lYmFJaXRFTE1r?= =?utf-8?B?aU5CT0RpLzR3cEo0RTRYdU9UR2gycVR1Y2FoSUdJTkZlbW1WYWtwMFRiYkcx?= =?utf-8?B?RWFCV0FBUWlxMURJQ05Zc09DV2w0UkVicnJMK0JnUnExT1QvVVo0Zk5SMnVu?= =?utf-8?B?aUdhbmp1TWJUSVI3Q2NsT1ZEQzNCaFMxVVk5R2hJbXp3TWRqSjl2aGhRbG5j?= =?utf-8?B?MjdOUlROaHpzKzQwR05LS3lrallsMlFZN0U2a2RQakd4TTBwMjJOdWVSa3Rz?= =?utf-8?B?a3VROWJ0dmc3VUNDc3hRanh1akw2QVN5UVBqajVBT09zZnhqYzMzYVgwcFhm?= =?utf-8?B?WFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 88074287-fe1c-41de-fcf9-08db5aa70312 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 09:29:16.2733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /nGoqWkFzk83JIYFCJF+3E2ufS0fsoXMnALyNvC63S3BL3Y4WT6TifTVD/cpo8hWIQDmwizV/D3k5OBaSuTrZueva9lhqsNL9dxcsXS6nc0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6918 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/2023 2:47 PM, Samina Arshad wrote: > This bug fix ensures that the runtime socket path is generated > correctly, based on the user-specified file_prefix value, > resolving the issue that occurred in the previous implementation. > > Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument") > Cc: lihuisong@huawei.com > Cc: stable@dpdk.org > > Signed-off-by: Samina Arshad > --- > usertools/dpdk-telemetry-client.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py > index d6718ca5b0..3441b6b02e 100755 > --- a/usertools/dpdk-telemetry-client.py > +++ b/usertools/dpdk-telemetry-client.py > @@ -55,7 +55,7 @@ def getFilepath(self, file_path): > # Gets arguments from Command-Line and assigns to instance of client > self.file_path = file_path > > - def setRunpath(self, file_path): > + def setRunpath(self, file_prefix): > self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix), > RUNTIME_SOCKET_NAME) > Does this fix anything? The path is generated from args.file_prefix anyway, so this change will have no effect, I think? -- Thanks, Anatoly