From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95507A00C2; Mon, 31 Oct 2022 21:15:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 538B140685; Mon, 31 Oct 2022 21:15:18 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57]) by mails.dpdk.org (Postfix) with ESMTP id EA4A640223 for ; Mon, 31 Oct 2022 21:15:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FnidBSOWoFxP1X1xYCBGFbAHpxk/vKzt0PBWTrwRl9YsyjV12vA8AH2wwqWGvhv1Gq9ab0m0rq+Hi/We1oBpo4T33XLc1clHxYjx2EQb/Z/jI1oeuEf4enne4MiQFbyrxTB3PtXco8aZIkLJ0JG1O0z2i8vIWINrfhXzmukp3+0FH2fb0dUDO10vtPsVCSlUnTh3Azb6WxE1IeJxnGeaVA9fLwZ274JIO2rPJDv/lOD3+m/hHrqFY7zznB9JVQLqKuLaqD87nufo8lMnakjFINHmSoPtqYwKPFPIWNpJ7S0QyhekZR25+idAeQ0xrure1Jq/bKb6rY4FEdrhZz/dAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ybRba0QtS82HaP6M/yjbbIf3kkW/FMQ0E8KTRbCTW44=; b=DFxgTunL1SxcUv1h2JLX5we1rsW8BfMnDRGlQb9WjQTz3BDJ7ppBwSA8s0phoszYRNZOLbVTgX3yVxntmgK56oeCzPpcfyNKRmEmJKOgc4Ofn7gtwZt3Bun0qejXV7ZS6U77rU4NRwHwVbVmHm9qj7jAq4oww2RDjsNE1SuxkkjEEmMzKyKC6iEr1s24PMoIyU7LrZaxphjb3u1KsDh8mVzKGWph4RUV2wBS8bNEYFbaabwXLL36EsdhR6dQTLFNbyFusdPT1eut10RLTfYkMuBMeYCC80ONa07kP0uBdwbVCv42L1+3+tPlyG35w8Jll3tmQqsCAfeAz+x8sxFvPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ybRba0QtS82HaP6M/yjbbIf3kkW/FMQ0E8KTRbCTW44=; b=OSlnsGBg/laT3mQt/3SqrZegu2mnklykwCVxxzhb7hvUacIX2TfLax64OUquOMy6TRx5juUqLVtJSf2etqhd7AI1tenZqqYANa+lgWabejNpJDjXUg8GsRLXzqUsWBnPEGWoyBZsaAb2iKsjONiXpEPG1fYp8k7ZAYimSyJ9iwc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by SJ0PR12MB5453.namprd12.prod.outlook.com (2603:10b6:a03:37f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct 2022 20:15:15 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5769.016; Mon, 31 Oct 2022 20:15:14 +0000 Message-ID: <97a009d2-87cf-c901-590d-7c4dad37d6ca@amd.com> Date: Mon, 31 Oct 2022 20:15:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Understanding RX_OFFLOAD_VLAN_EXTEND Content-Language: en-US To: Ivan Malov , dev@dpdk.org, Qi Z Zhang , Qiming Yang , Wenjun Wu Cc: Thomas Monjalon , John McNamara , Andrew Rybchenko , Jerin Jacob Kollanukkaran References: <911e37b-7c27-5bbb-ca40-4b778d396fff@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: <911e37b-7c27-5bbb-ca40-4b778d396fff@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0595.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::12) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|SJ0PR12MB5453:EE_ X-MS-Office365-Filtering-Correlation-Id: 0517f3c1-5ecf-4de7-897c-08dabb7c9ea0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yYUUuv7u4FImWCBZB8ehQ96kl3ejjjTjaE9ynEHgI4ys1TTsiqNQuWcAGI7F9C1/JWO3kl3OmWgGRnm/5sEHRznQ/Qs8DH3iC6TupHEAR6Ro8MA+cO5UxfQxdHFUiJ9uaaNLF48p29GTP5fwpmOmTpzZIO/zd6TV/y22Dq+/fKUjq4vucU6GQuFZBPEXqggek97MbFoZqjAvslqcspB2fsZ35GzPiIqlIrkugIMO1oD9YEzQcttAcnTL0ioY20OkOw6y48+pDkod9rhgALdj2v5Z7Qx3AyfvRtFvVXyJVsrpYuYB3mcpk/Y1yGLgD5hdlf7QnzHgHWA/sXBndcaeDwJNju8QQHG1ua4Xd5MtJLAi+jqDRAyZOmYb3zHLbhwjT6jwT8QaP3LPSpFCqZxJ4Nq0QIp4vrzQQdQs5QIVxyAxZTf8LSp1ODTPyJXFt/HqzQCHzATOGrgarp1ssY5cAYlDvG5YQGG5LJZRKHwHuOodr88jYH6xGRciciNcJ79ZRTfONLT+iUWYbbCeFM/xsbNCrAUbGBQGDfcdVUYXCz/uckeXfAV8uA0jGXp4bByQzBncwPRXKFPk5kpfSLZ7Dr4maZRtfXCIQZIlMOlVICdoMhtfRhpSo1/LFyzG/IZha4vfERZ3OjtF34qUphKHBJ9cfF74VgEJ61SsL+ph+oqyxTlDDqR5qloBPJrlDAPXNVSjCoEFmiq97jOzAL6DoZZvkaKFy9WiiJ6xwgvDMpH9eNUgcuFmRLL+lGXlYM6kSju883IVEj0LmnC6ikadXq1Qk2o9z+T3TD8KaxwhdCBF14egfnte4L+icPi2254z X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199015)(6486002)(53546011)(8936002)(6512007)(2616005)(26005)(110136005)(54906003)(5660300002)(8676002)(36756003)(316002)(6666004)(6506007)(7116003)(38100700002)(66556008)(478600001)(31686004)(86362001)(83380400001)(31696002)(66476007)(186003)(66946007)(44832011)(41300700001)(4326008)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUpYeTIva1ZvVmVZaWQrMzA2aWhkM0VqNmFTbWtYdWk2RWJza3VQcEZSZ1FZ?= =?utf-8?B?L1ZwYXJJTVVaRFFqYlZkTGp3OUpCM1ZUaTIvVmJkRGNMQWJXTW1IMVZEVDFF?= =?utf-8?B?YnRSWWNadCtpY3RtUDZPbzBLSFVNQldWRlcwL1R3R2ZXQnloMm9tUm5xZS9J?= =?utf-8?B?VzZWM21FcU9lUW1MMDd2NVNaQVBmeUp1K0VrMHlqbW0yTFRMMlFjcTlIaW9E?= =?utf-8?B?ekhTc0FUZGlWYXJnK1llMmRVSTBRdURPU1RvQmljRGx1UmhCNEt2QzU0Zjdo?= =?utf-8?B?Q2RBTDVzOVBUbWVPelRMSDNTMURzUTNwMWVuOExuRmp0T3hQVVNEM1cwQlNk?= =?utf-8?B?bWRNeEdwMkgyV1JzNXlheDg5aktFMFpHZHVJUHhWTzF5ZEJwbE1FQksxeHZ6?= =?utf-8?B?cmNJK0dRa0NRbTFnS1JVSGdMZGYzSUdhb3FBdnhsUHpuYnh4QkFzZUszcm9I?= =?utf-8?B?Q093dWxBcm8yelFyVkREeEU0bFdDTW9sYzFSWDE5V0NQazdHQ2dkWEJoRUJQ?= =?utf-8?B?aFdjUHZ5eGt4bU9YVnZ4cVo2c2IwWC90d1gwdDVtYlhDMnRocjNzc09wc1I0?= =?utf-8?B?NzNocnpyQ01DQkpBazlmSmN1UVI5TTJGVnE1a3laSjBlRHB5Z0NwbEt2TTd0?= =?utf-8?B?L1gvbHFpT0IwU2U5Nm5veUhFU2lySmlHaDlwK1B5RGhKSENMR25PRm9vSnZJ?= =?utf-8?B?dHN2OHpvRnc0RUwrWmVTVUJlK0ZpS0dEZUVqc1h2WWcyL1ZadHR2VWl6SUVT?= =?utf-8?B?U0htODlIbzJkWGU0ZUxNbDdEMHVMYXpNRkVDL2VaS0swQTQ5SWRaMFNoWVpt?= =?utf-8?B?SlhZUk1wZmxIUUh2WXRMdWtwYVdzdzA5QzZiallTMWRBb2dYWFR0S0QycWF0?= =?utf-8?B?SUpiVVBNYTh5MWxCQTI3SnZwVldEbWRTZk50OE9DNjN2MmxBcW5TVnRrUCtk?= =?utf-8?B?Y3k1QkNvUWU0eURUQ1VZVCtnck44a2xkRUVlUTBHd3pFUW5KUTRsUGFxVVNy?= =?utf-8?B?OE1ZZ05pOHBxYlNXQ3I3OXphN0VTQXpQWUV4cjhiNjBnaUM2UmhHaDNNRER0?= =?utf-8?B?TUhCanRUOURyZUJNalRZZUtITVIyQTF3ekVYMkdWMC96dCtxOFNtUDZXeWgr?= =?utf-8?B?WEwzY0dIOUlvTHA2R05zN3NuRHc2UytJR0NnME9qUFZHT2o0SEgzeFU1a1Jr?= =?utf-8?B?OWZZZjcreVgvUk9lWnFlOW14Umwrd0prczJyRkVZS0pta3JKK21lYlRyei9W?= =?utf-8?B?Q0o3M2dnT0lkYzJTMmlBS0hkRUxza1BKaVlFZjFYQlA4OHlhTUtXUnNuSlZU?= =?utf-8?B?b2RxT21CYUk4LzBuVUhiNGtKRXQ0WkVCQkF0VEx6N0lwc2k1VEJHdFJlN3o0?= =?utf-8?B?SEJsazJCdE5JY0lUdHc2ZmJvemMzSEd1UDlvdEZUQ2pCcEZrek9JZndnVEdH?= =?utf-8?B?Z3gxbzFzTnNtN0ZMcFRNeDNmeTJrWm9ybDJURFE1RHBiS3B6TVArZytONWZj?= =?utf-8?B?MEdycCt5dzdKUC93UGJHNmd5ZWpZMEdhbUp6QnlFaDBDYXMxNk1OSTNYK0c5?= =?utf-8?B?ZG85SHZ4RWV3Y2N4QzF6OGFneiswREZsQnNNRTBpajJlK1BQaE10TFc2bzNx?= =?utf-8?B?eTV5QTYvUU1OTlkzWWJoUGt3VEpXdUZFZHZpenF4Y3NNS0VNZVpYWUpVYUow?= =?utf-8?B?UzdlbzFNejlnQkkvemF1ejR0UkRwYnNFR2FveXhNL0RvSGh1V3ViaCtmeHRM?= =?utf-8?B?aS94ajRaWGxxUU9VQUVWTjV4elFpT01UTHQ3SDBkLy9haDRQWGxjWVN0SGZ3?= =?utf-8?B?WlFFMG5jaWxURkd0cEgwSC8rTjBqU3dSTHJqQkFIeWtaUzZqR2J5T0k2SnlO?= =?utf-8?B?RVFtQ1pmRkxDV2ZNNnFaeTJDWk05K2poT3dhS2lacUdQREdMUklXdXZ2SFRY?= =?utf-8?B?K0ZkbUQ5Vmg1eCsyR09FUGcwb1VNeHdKLy9MZzJzWkNJbFEvR0NnN0xOYTFM?= =?utf-8?B?VHlmYUZzNXVFSjhCaVgxMmJ3a0MzTEdSV1Z0MlFUM3NaMnpYZWh4L3BaWnlE?= =?utf-8?B?bG1yMGM4bnNjMENoYXVmTXRpUmdRbFd3SjBDR2xKRk15MmxLYTVlalgwOG5j?= =?utf-8?Q?VgC5Y3NFH6BvTWi0vSy0IH+Xt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0517f3c1-5ecf-4de7-897c-08dabb7c9ea0 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 20:15:14.0349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7AIg8CpHOkVMdJ7U5nQhzIk3w3trLmliFp0OoovcKC9EVZK1wYtxWAQvVc6FrWuu X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5453 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/31/2022 6:46 PM, Ivan Malov wrote: > Hi! > > We have a hard time figuring out what the API contract of > RX_OFFLOAD_VLAN_EXTEND might be. The best educated guess > we can make is that the feature might have something to > do with identifying VLAN packets and extracting TCI > without stripping the tags from incoming packets. > > Is this understanding correct? > > You see, things aren't helped by the offload bit having > almost no commentary. Such could've shed light on its > meaning. Perhaps this gap in documentation should > be addressed somehow. Any opinions? > > Thank you. Hi Ivan, It is legacy from ixgbe driver, you can find more details on the ixgbe (82599) datasheet [1]. RX_OFFLOAD_VLAN_EXTEND is *like*, QinQ but not, that is why we have 'QINQ_STRIP' offload. And RX_OFFLOAD_VLAN_EXTEND is more a configuration option, briefly you can ignore it. But in detail that is to configure device in a mode that it knows that received packets always has at least one VLAN tag, I assume it is for a case that some in the middle networking device inserts/requires VLAN tags. But optionally packet can have two VLAN tags. But as far as I can see this is not for to strip the VLAN tag or to filter packet based on it, this is just to configure device for this environment. [1] copy/paste from a public datasheet (http://iommu.com/datasheets/ixgbe-datasheets/82599-datasheet-v3-4.pdf), not sure if this is up to date version, but I think it is OK for this context: Double VLAN and Single VLAN Support The 82599 supports a mode where all received and sent packets have at least one VLAN tag in addition to the regular tagging that might optionally be added. In this document, when a packet carries two VLAN headers, the first header is referred to as an outer VLAN and the second header as an inner VLAN header (as listed in the table that follows). This mode is used for systems where the near end switch adds the outer VLAN header containing switching information. This mode is enabled by the following configuration: • This mode is activated by setting the DMATXCTL.GDV and the Extended VLAN bit in the CTRL_EXT register. • The EtherType of the VLAN tag used for the additional VLAN is defined in the VET EXT field in the EXVET register.