From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD2B8A054F; Tue, 16 Mar 2021 12:34:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F47B4069F; Tue, 16 Mar 2021 12:34:54 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id A78234003D for ; Tue, 16 Mar 2021 12:34:52 +0100 (CET) IronPort-SDR: ONO3yrmTYamV4yH9TnoXkfTw+RPwoK69R1cCWu9Up7uYg8KlpuacaQMRFFbKaW8bgew/BZZLAv L/+Pk4tcyqBw== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="169158654" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="169158654" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 04:34:51 -0700 IronPort-SDR: k7idAOqfTl6MDJz8Mclq7mqUml5MeMs4eCKsqxbcoXEIt7k30D6eTxOzmbbCgrfFFx/UhAxPwb 4Jq9RIk6pOYQ== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="405517460" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.11.157]) ([10.252.11.157]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 04:34:51 -0700 From: Ferruh Yigit To: Andrew Rybchenko Cc: dev@dpdk.org References: <20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru> <20210316085832.942481-1-andrew.rybchenko@oktetlabs.ru> <36b86891-1ec2-3cfc-0a3b-a0b9fe850a2d@intel.com> X-User: ferruhy Message-ID: <97af0a82-86c9-421d-d9d6-02a8f16282e0@intel.com> Date: Tue, 16 Mar 2021 11:34:49 +0000 MIME-Version: 1.0 In-Reply-To: <36b86891-1ec2-3cfc-0a3b-a0b9fe850a2d@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 0/8] common/sfc_efx: prepare to introduce vDPA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2021 11:32 AM, Ferruh Yigit wrote: > On 3/16/2021 11:30 AM, Andrew Rybchenko wrote: >> On 3/16/21 2:26 PM, Ferruh Yigit wrote: >>> On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: >>>> Update base driver to provide functionality required by vDPA driver. >>>> >>>> Factor out helper functions to be shared by net and vDPA drivers. >>>> >>>> v4: >>>>    - fix Copyright year >>>> >>>> v3: >>>>    - one more attempt to fix windows build breakage >>>> >>>> v2: >>>>    - fix windows build breakage - do not build common/sfc_efx in the case >>>>      of windows >>>>    - remove undefined efx_virtio_* functions from version.map (since >>>>      EFSYS_OPT_VIRTIO is disabled) >>>> >>>> Vijay Kumar Srivastava (6): >>>>     common/sfc_efx/base: add virtio build dependency >>>>     common/sfc_efx/base: add support to get virtio features >>>>     common/sfc_efx/base: add support to verify virtio features >>>>     common/sfc_efx: add support to get the device class >>>>     net/sfc: skip driver probe for incompatible device class >>>>     drivers: add common driver API to get efx family >>>> >>>> Vijay Srivastava (2): >>>>     common/sfc_efx/base: add base virtio support for vDPA >>>>     common/sfc_efx/base: add API to get VirtQ doorbell offset >>>> >>> >>> The driver adds vDPA support, I believe it worth mentioning in the >>> driver documentation and in the release notes, can you please send a >>> new version with documentation updates? >> >> No, no. It is just preparations to introduce the vDPA driver. >> vDPA drier will be added in a subsequent patches and I'll >> ensure that it is mentioned in release notes etc. >> > > Got it, that answers a few of unused functions too.. Please be sure to document. I mean with coming patches, where appropriate.