From: Maryam Tahhan <mtahhan@redhat.com>
To: dev@dpdk.org
Subject: Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic
Date: Mon, 13 May 2024 09:23:08 +0100 [thread overview]
Message-ID: <97be801a-bc5c-47bd-bb1f-23cca7f1fbcf@redhat.com> (raw)
In-Reply-To: <20240510080612.7b420011@hermes.local>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On 10/05/2024 16:06, Stephen Hemminger wrote:
> You don't have to use local statistic for this, there already is one in the dev struct
> i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port number to find
> what dev is.
I think the diff id that dev->data->rx_mbuf_alloc_failed would reflect
the pure HW(NIC) failed allocations where as the local alloc_failed
would reflect the failed allocations on the xdp side. Both should be
accounted for.
[-- Attachment #2: Type: text/html, Size: 851 bytes --]
next prev parent reply other threads:[~2024-05-13 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:03 [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Ciara Loftus
2024-05-10 10:03 ` [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic Ciara Loftus
2024-05-10 12:35 ` Maryam Tahhan
2024-05-10 15:06 ` Stephen Hemminger
2024-05-13 8:23 ` Maryam Tahhan [this message]
2024-05-13 15:53 ` Stephen Hemminger
2024-05-14 8:37 ` Loftus, Ciara
2024-05-10 10:03 ` [PATCH 3/3] net/af_xdp: Fix stats reset Ciara Loftus
2024-05-10 12:36 ` Maryam Tahhan
2024-05-10 12:20 ` [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Maryam Tahhan
2024-05-10 14:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97be801a-bc5c-47bd-bb1f-23cca7f1fbcf@redhat.com \
--to=mtahhan@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).