From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 334C1A0524; Tue, 13 Apr 2021 16:18:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C74AB161021; Tue, 13 Apr 2021 16:18:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id D0A7C16101E for ; Tue, 13 Apr 2021 16:18:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618323480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXb63rw7CaaLzFt3IO/jvqdeMg3twx4Bmi9nICltIuU=; b=XrkyHaXaKTAKNQKE2H78lTxpnxvlUzDGQd9PjdErRu17xoh1zgKh/CbDTHqpCczdzim8jF E9859pFAGnlIXWmh5hIAZGjK7s4ZmvlHneJQaiKD7CJtWyOSE476r5NDB3QnpTS5QYunfW LVBbEf94vyBjOg9o9gIZpEAlp3j3H7k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-fUWnNF3OOTiXN-56D2emeA-1; Tue, 13 Apr 2021 10:17:58 -0400 X-MC-Unique: fUWnNF3OOTiXN-56D2emeA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B2AF679EC9; Tue, 13 Apr 2021 14:17:56 +0000 (UTC) Received: from [10.36.110.28] (unknown [10.36.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D6B7710023AB; Tue, 13 Apr 2021 14:17:51 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: olivier.matz@6wind.com, fbl@sysclose.org, i.maximets@ovn.org, Chenbo Xia References: <20210401095243.18211-1-david.marchand@redhat.com> <20210401095243.18211-4-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: <97d280e8-cabc-1177-2c37-5ad730dc4a40@redhat.com> Date: Tue, 13 Apr 2021 16:17:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210401095243.18211-4-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/5] net/virtio: do not touch Tx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/1/21 11:52 AM, David Marchand wrote: > Tx offload flags are of the application responsibility. > Leave the mbuf alone and use a local storage for implicit tcp checksum > offloading in case of TSO. > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtqueue.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index 71b66f3208..2e8826bc28 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -618,10 +618,12 @@ virtqueue_xmit_offload(struct virtio_net_hdr *hdr, > uint8_t offload) > { > if (offload) { > + uint64_t csum_l4 = cookie->ol_flags & PKT_TX_L4_MASK; > + > if (cookie->ol_flags & PKT_TX_TCP_SEG) > - cookie->ol_flags |= PKT_TX_TCP_CKSUM; > + csum_l4 |= PKT_TX_TCP_CKSUM; > > - switch (cookie->ol_flags & PKT_TX_L4_MASK) { > + switch (csum_l4) { > case PKT_TX_UDP_CKSUM: > hdr->csum_start = cookie->l2_len + cookie->l3_len; > hdr->csum_offset = offsetof(struct rte_udp_hdr, > Reviewed-by: Maxime Coquelin Thanks, Maxime