From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4388DA09E4; Fri, 29 Jan 2021 13:07:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5B60240134; Fri, 29 Jan 2021 13:07:16 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3AAC040694 for ; Fri, 29 Jan 2021 13:07:15 +0100 (CET) IronPort-SDR: n7vxW4zMtPaVUdPx55af5aKKn+zMOq+gKw9k4oUOBlm0/LVHyjJ+ckJDPoIcNWoTnsS1YZli6e V+X+2s64Hi6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="265244487" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="265244487" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 04:07:12 -0800 IronPort-SDR: nnNe0Bf2SLDW8Wf87Fh+SJx0FGmRGYjxuzcZBAHyZ/zMpyJWSiyFCHnDYF5xN+iXGoL1M2gK3n 969lKF6Byg7A== X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="389274923" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.204]) ([10.213.197.204]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 04:07:08 -0800 To: Michal Krawczyk , dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, mw@semihalf.com References: <20210126183226.2420903-1-mk@semihalf.com> <20210126183226.2420903-5-mk@semihalf.com> From: Ferruh Yigit Message-ID: <97d9c7eb-7bc2-3076-b5bf-f835958ca483@intel.com> Date: Fri, 29 Jan 2021 12:07:01 +0000 MIME-Version: 1.0 In-Reply-To: <20210126183226.2420903-5-mk@semihalf.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/26/2021 6:32 PM, Michal Krawczyk wrote: > From: Igor Chauskin > > Before starting transmission of Tx burst, the driver checked the > available space in the sq and limited the number of packets for > transmission accordingly. > The calculation was incorrect for fragmented packets and potentially had > significantly limited the length of Tx bursts. > > This patch removes the assessment and pushes packets to the sq as long > as the burst is not exhausted and space is available in the sq. > > Correct evaluation of the required space isn't possible before the burst > because it depends on the number of segments of each packet. > This patch adds per-packet space evaluation for each packet before > attempting to process it. In case there is not enough queue space, the > burst will just stop without error. > > Signed-off-by: Igor Chauskin > Reviewed-by: Michal Krawczyk Hi Michal, Igor, Can you please provide fixes line for the patch, and I assume you want it to be backported?