From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 855F145555; Wed, 3 Jul 2024 06:25:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 246B24025E; Wed, 3 Jul 2024 06:25:11 +0200 (CEST) Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011040.outbound.protection.outlook.com [52.101.70.40]) by mails.dpdk.org (Postfix) with ESMTP id 6B7E84003C for ; Wed, 3 Jul 2024 06:25:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlPaKqjuHWeJ26w+5A/mJpseCZR/Aled3oO/8sR4y+HsMgDaQJR7pTQOTS8/Evkr94jmcg5ugtlFSv1iBTqtTSOPnHSW6CX4smtsEUEMFG+g7le09EOxZkbf74dtaSyxEPLFXnxMZtbGHxFi2cq6cZIs3QWFUGj8N6yXlsrJU1c8BRas4RZK7X8WsX7XMIptFrb2GKVSPv/yt8cuiDsEzIg7XNrn/anyqgi5S7Y280jXncxcdTswj2tTRmMB7YZfNCM7yglV3jqg/0ldULJF2XdGXnYhuRuPPlv+trsR1FUOX5oZqJ4o6VrsCCyQnb9HxvGeAVCTS/yBQjKzKflpTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c0R959otPEXhsAUkxElAbutXbfE8FjIiaxHEPWiXUM4=; b=CyL2ZWLisn3mKHqaZsdpy59o6oX9GIdBXPcpMYcKBwdPLYy9Pc3UAntmM/dEwDLtmbngE5AIYSjkSerWaRJcRfoG+2qHu0mZ25RuzLPDmNIw4CSwheHSa8n+lOPH5i22+smlrydCfobJjTsDum964UjwKxsbILb7klXKRRFon1M3rT5Li5N3ArYuHw9GSie9HZQbmiOplpQN5eazdv+UPnYWyXuzBF8p9HqQmoA9suo7v/4/1SQ1QfxJDkN96RZMztAWNHQpjY211O3cUXzUJkca+A6M8eDkTdcwnMiqjqIGR4VqYwdsORghGC7pm22gaCqaszwdz4RGwIgTZPBiAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c0R959otPEXhsAUkxElAbutXbfE8FjIiaxHEPWiXUM4=; b=SgJ+uDR0jy5j+qhwznusj5VS3Aco45vWYj36jBOQncQi9VO9ApmWxbMyDzF+m5abna5sUQAucy02ItOGQ+9KdceHF1x7xAvW9YgZWKersBwYeicxeToyDdlagEwUXm7ZjfPb/4GQ5z2vFusW/qeZRngNTaLX5K6Lg/RAyRiIrA4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by GVXPR04MB10945.eurprd04.prod.outlook.com (2603:10a6:150:21e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.29; Wed, 3 Jul 2024 04:25:05 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%4]) with mapi id 15.20.7719.036; Wed, 3 Jul 2024 04:25:05 +0000 Message-ID: <97efd5ba-9b47-96c8-03a9-43a543ed776c@oss.nxp.com> Date: Wed, 3 Jul 2024 09:54:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v1 1/2] bbdev: add new function to dump debug information Content-Language: en-US To: "Chautru, Nicolas" , "dev@dpdk.org" , "maxime.coquelin@redhat.com" Cc: "hemant.agrawal@nxp.com" , "Marchand, David" , "Vargas, Hernan" References: <20240701223424.427588-1-nicolas.chautru@intel.com> <20240701223424.427588-2-nicolas.chautru@intel.com> <0b28aebd-0247-0e0f-22f3-f04ee0b2a236@oss.nxp.com> From: Hemant Agrawal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|GVXPR04MB10945:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b7a87a6-b58c-4889-ab7f-08dc9b181d4d X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U1lFUFpsUC90UzJPVHZHUVpFWkthRm10SVVRck5HMlRtZDYxR2FvSlhzNTJh?= =?utf-8?B?V2tnYkRQREZJcTVNTGhiMW1MZ1cxQ2l4WHdvTUQwRkN6Vldtei96eGpudExj?= =?utf-8?B?bndvaERUZXZBbC9rMUFGbGVuNnlWSURNN3Y5UWlzQXlISUdJcFZvS1FtMDQv?= =?utf-8?B?MDJOby9XekFXb2ZFZFBSN1V2Q3RMSjhXUkJucFVsK2xLdHdVV1VPTTdsc3pQ?= =?utf-8?B?SDBPcEtOOUc5VmdmcFQwNlNzTFFPdy9ldUZWRFVKNEJ1UG00aEVUUEJyTDhD?= =?utf-8?B?eEFnenR1TDBSSnFBQU1RWUtyZGtHdG84SkJFRTdOcFpkTk85WVlUcW52N0NU?= =?utf-8?B?M01RZFlPREoxUEpCMG4vYUx5S3N1bzdPamcvU3Q4RHlOWTR2c2FtcXhYRDA5?= =?utf-8?B?bUFwVW1JL0ROTUxwVkRxOWhiMm5VRW1JaUtLT3V6NHdCTHR3MXFCcjhlWmpo?= =?utf-8?B?aFFnVUpvN3YzK2d0d0hpL0xTR0dNQXBkUUdpK2NLckZKclZjNG0rQWNidm5J?= =?utf-8?B?QjVrRmc0Z0ZvQVlnVFhOa20vYzhVYkFJWDlZM0t0SmhiTG8vWm5GaUljOVk3?= =?utf-8?B?aFVOTnFzZFU2U2lpRUJ0RGovOVdRMUw4N3VBRmQ5K1RJSWI0ck14Rk02QUh2?= =?utf-8?B?dWpmUGRWWU12SXBWR0o3c1d6NDYranFjL3UyS0ZFU2ZkL01vcytDNHhXL2Jk?= =?utf-8?B?MGs4ejByV2RibEZLUHJJQkJBZnpKWG90emRhYUo5Nk90Tk9teWVZaVZYRG5n?= =?utf-8?B?S1IrUSttL2FZejhLVnBlWlJ3MWpvRVc4NEdUV3dOZzZQWEgxb1djMlNSMVpY?= =?utf-8?B?RFQxUmkyZTVrNmptN2lnYVF1WnJvdTlvdVpPelRnRGx1dE1admFzUGs4M1Vt?= =?utf-8?B?QUxkN2tONkRaVU9iUzI5eU1zN2I4bkN0UnBtNVJqbzJsTUZoMTY3VmE0SzlN?= =?utf-8?B?QjBKWWczREx4aXgwYzJTODhraGsvR3pPamR6eVdxaGoxQThBQ2FXUlNWb2hm?= =?utf-8?B?NzkydjJBZW56QmtsVUF6QVVLVG9zR0ZMWWxQbEV3Umwzb1YrbzM5ZTdQOFlD?= =?utf-8?B?SzU0WERaVE8veWx5R285bWJscHRzODVlS1ltSVBIVFZZSGlxWXZnZHh3aS9R?= =?utf-8?B?bitBYUVPeGZRRGdqdk9EMnA4K1N1Q1grNWR5alhuOVNDTStQWTRhNUo4RFIz?= =?utf-8?B?L25NSTQ5eXB2MC91ODJJTE9oZE5EcFNLNnJ6VUNZcHJ2TS9kNERJb1N2VmxR?= =?utf-8?B?cG4rcVdrVEV3bEVTOVZuL1BsQjNqK2VxQ1lBWFdJZ2RZM2NIdFpMUm9FVlNN?= =?utf-8?B?dmRmTXJQZDNHK1QydmEvc0txTmRPME1COXB1ODFyTGo3VFRuK0l5cDZjREpX?= =?utf-8?B?ajdjYzFZYkI5ODEzekRXRDEvc0FuSURucWszYUlxMGpTRDRGa0FQRndJREZE?= =?utf-8?B?T1FPUEtDVUVlMGl3OWZDZkNBVGpmTGxTNm0waUNBaUhUQS85MFpES3pJVTli?= =?utf-8?B?UmN5YzB0TXhRWW4xdDhneFFrR2htTGgvOHRJWkxjNzB5Q1N3cnBXMmZ5TTln?= =?utf-8?B?TE5lTTNicW9jUWZZbExkMkZZUFhnYjl4cE41MG55NWFxemIzc1NEbWJZRGEw?= =?utf-8?B?MnpsVHJkL1FvMmdjU25zcVpUREpQZXJFbzdlUUc0aisyZ0FsOWZ6akVSU2pt?= =?utf-8?B?b2RxOExwS3hxSFhQSm9PVnFUcXBYa0F6MjZPUmd5Mk1lbzV2aitVQkNhRE94?= =?utf-8?B?b212bkdvQTVEQ2N5ZWEycndZSjBldFpMRkFsYzNHVXhveGZ5WkN0S2hTNXZ3?= =?utf-8?B?UStKUVNhUVEvWWx3VFFWdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEFJVGgydHZDS3NpUDRteG55cWNYK3dNL0xFOXYwM0lPb0JmVXFnUDZEeGZ3?= =?utf-8?B?bWk1bEhnb0xlWUZMVW00Q1NOdkFWM0JYWm1kWWFuMThRdGk5UDV1c2o5cGds?= =?utf-8?B?OHMwYnV2a1dtcmxCdk5leVRmMk1ZZ3F1Z1lmdWE1OUMzMTdja0l0VWUwM1JF?= =?utf-8?B?ZE54M3VNamxSK1ExMS9QV1h0aUZwWDUxM0thVVhZVXRQYnNXamJES0tNVHZR?= =?utf-8?B?UFpHQVE2QVg3NmphY3lVUjVCcTZVanVEY1huSVR2QXVDMVhGbFFxT3IvVUw2?= =?utf-8?B?WjlCUTlNUVAzQjhnRjZTbVZOY3E1YmZ4bGRycFpDMkpoRmJIbVJTUThabEpF?= =?utf-8?B?VW5VeEZHRHhkQk9WUTViL3pKQmI2YVZsQVBkK0VpZjM2YkFOSC9JQkVNOWNS?= =?utf-8?B?V3YvRFVhY3ZWdXFBNVZFWUVkbUhvSGVYSHdweFlGSlc3NFNlQmxtc1g5c0JM?= =?utf-8?B?a3BzdmcvNFNXTWVkRldkODVDN3A1SkROTndicDNEYy9rWGV1ZHJUVlFkOVRs?= =?utf-8?B?ZGZpRSswOUhCQkg2Qm84eWdYdkwweXd5NGlIYlJpK0Z5ZHJiaVBqOTNsWVpO?= =?utf-8?B?TTM0T05NYmRIUERFc0tWUHM0S3d5QWVDaFIzSWtSZHdhUEswSk0xMFBFNytE?= =?utf-8?B?OE9GMXNjUWVBOW1FdGRrbDJnSXdqdlpsaUoxQnBMZjdkSi9DRU80L0JrUS9M?= =?utf-8?B?MTQzUU9SMk1QYTB0VDdWTXFLNzBZdWdKTU5PbFZuK3RIclN0ZHBjVU9BVFhy?= =?utf-8?B?akFXZU9xeU5HemwzNFlmQkR2R2VSV3JkWVdEQmlsOVU3cFdvZzJ1V1RWMDJE?= =?utf-8?B?cS9zZXJNV0hnNXRtbXpidEtlaFlTSlc2Wjl2c0d0SjQzNkN0Njh6bG9yTWpY?= =?utf-8?B?UUdSYjVkSEpjWHFGelM0WUN6dkJGMDQxc1QybWgramY3b2pCYmJJaEYzM2s2?= =?utf-8?B?N29rUEJXQ1Eyekc5bU40UjJTcC8ydWx2LzhBeUpxc3VieTdrSFYxdTlIS3lJ?= =?utf-8?B?NFZjUk5UUXg4TXUyUWVkMUQ5eG8vdEVpcmRYRHBOWi8vNVdSOWNMWkNLeWxO?= =?utf-8?B?dkhZNTJ2blVSQkZuWjE3Y3N0WTRWSVRDRHlVN0gvd1ZBSmZOZHJPMGZQRHZz?= =?utf-8?B?a2FRWHZRaWR2NGN0RFhiMVRtT1BoWE45UVM3ell1MlVuU0JETkVSL2ZCNXpo?= =?utf-8?B?M3BrUzBRdVMvZW5DeUlhSVRyR1JkMGZrN29rbGZNWWlxcnFwNzk0RjdlWFVt?= =?utf-8?B?M3lmNkpkR05qQTBIMmNRK3F3aHgwWkgvQmFzVExrcGZmeTF5bGFuZFBGcjQv?= =?utf-8?B?YzFvdTFpRmU2NFBHRFZtbkNUc3cyaTNwT3B3TndaYzRpQ1VEcVgrNUk0T1l6?= =?utf-8?B?aTQyclE2K2RhV09SS2hITUZFaHJsd2ViV0tnVERsTFUyWkg4a04yandYRGJ4?= =?utf-8?B?aWhEcXpkYnNzT0RQQ2xZV3d0a1NtSEMxaHhxcExlY3lMdkpUSGlUQkRYNFpI?= =?utf-8?B?Zmg4dk1XSXpPTGJtM1Faa3RYcjVHUTQ3Z3lNVEM1bUVZdXF3UldDcmVKeWdx?= =?utf-8?B?NTJwcTUyQzJUN25sd3RPZm1MeEtKK2FBd2ViL3NUd0VRSExvcGEzeUJycFd4?= =?utf-8?B?Q0ZCbFdjcXN0cGVqemR5dEZEcjF0VmQyK0VKLy9nVXZsbjl5WTZvVkpJSkVN?= =?utf-8?B?S0N0ZW1zSUx1azhwK3Rya0toZmhFS0xzcWVYR0dNR0MxcVBhUFBieGtadGh6?= =?utf-8?B?RUs2c1dJU0F5OEJ2WW1nd1laRGxPY1BYWUE2ZFhZNk5NM25PSnFVRDQ3UGZ0?= =?utf-8?B?VUtvVktCd2JCTXJUdUVaUlZSbEdIOWVRSEZRNnQ1WXViNTUzTjZYaGJ5VHky?= =?utf-8?B?cXN2bjNuQUVQOEsvSm5ISHdOVmVIUXVuclJtcWRuUHR3ek5WTnZ0WVg3OUwr?= =?utf-8?B?azgybW5tL3pqOU5LQ0JYWUh5YmVFTk4vSU15SzArQkdORkJFcTB6azRLdHJ2?= =?utf-8?B?aGRwOFVyYVJlYzkzL2xNT2xhYm5RZEFXVTdkaDJtN09nTU51bGZWTHJCT3cz?= =?utf-8?B?cU5aRnUyMjVBQjBLREE1bDh5Q2xFOXZVYVFOa3FNZGJZSzk2MGdTTVB1ZjZw?= =?utf-8?B?NXdRRzhUbjFyOWkyZC92eGx3REw3YUEzQXQrZXNRUlo3VjNWM0xuMnNySkha?= =?utf-8?B?d0E9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b7a87a6-b58c-4889-ab7f-08dc9b181d4d X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2024 04:25:05.6709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mCN+54QINfBgevk7GqX9e2FiRfZNMwrpbvbo1/ZB67GSxbQGHlRxlX7hYuNLzG/Sz5gDYaWKbix7bmvKtbXOSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10945 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 03-07-2024 00:25, Chautru, Nicolas wrote: > Hi Hemant, > >> -----Original Message----- >> From: Hemant Agrawal >> Sent: Tuesday, July 2, 2024 3:54 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> maxime.coquelin@redhat.com >> Cc: hemant.agrawal@nxp.com; Marchand, David >> ; Vargas, Hernan >> >> Subject: Re: [PATCH v1 1/2] bbdev: add new function to dump debug >> information >> >> Hi Nicolas, >> >>     Few comments inline. >> >> On 02-07-2024 04:04, Nicolas Chautru wrote: >>> This provides a new API to dump more debug information related to the >>> status on a given bbdev queue. >>> Some of this information is visible at bbdev level. >>> This also provides a new option dev op, to print more information at >>> the lower PMD level. >>> This helps user to troubleshoot issues related to previous operations >>> provided into a queue causing possible hard-to-debug negative >>> scenarios. >>> >>> Signed-off-by: Nicolas Chautru >>> --- >>> lib/bbdev/rte_bbdev.c | 214 >> ++++++++++++++++++++++++++++++++++++++ >>> lib/bbdev/rte_bbdev.h | 41 ++++++++ >>> lib/bbdev/rte_bbdev_pmd.h | 9 ++ >>> lib/bbdev/version.map | 4 + >>> 4 files changed, 268 insertions(+) >>> >>> diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index >>> 13bde3c25b..81c031fc09 100644 >>> --- a/lib/bbdev/rte_bbdev.c >>> +++ b/lib/bbdev/rte_bbdev.c >>> @@ -1190,3 +1190,217 @@ rte_bbdev_enqueue_status_str(enum >> rte_bbdev_enqueue_status status) >>> rte_bbdev_log(ERR, "Invalid enqueue status"); >>> return NULL; >>> } >>> + >>> + >>> +int >>> +rte_bbdev_queue_ops_dump(uint16_t dev_id, uint16_t queue_id, FILE >> *f) >>> +{ >>> + struct rte_bbdev_queue_data *q_data; >>> + struct rte_bbdev_stats *stats; >>> + uint16_t i; >>> + struct rte_bbdev *dev = get_dev(dev_id); >>> + >>> + VALID_DEV_OR_RET_ERR(dev, dev_id); >>> + VALID_QUEUE_OR_RET_ERR(queue_id, dev); >>> + VALID_DEV_OPS_OR_RET_ERR(dev, dev_id); >>> + VALID_FUNC_OR_RET_ERR(dev->dev_ops->queue_ops_dump, >> dev_id); >>> + >>> + q_data = &dev->data->queues[queue_id]; >>> + >>> + if (f == NULL) >>> + return -EINVAL; >>> + >>> + fprintf(f, "Dump of operations on %s queue %d\n", >>> + dev->data->name, queue_id); >>> + fprintf(f, " Last Enqueue Status %s\n", >>> + rte_bbdev_enqueue_status_str(q_data- >>> enqueue_status)); >>> + for (i = 0; i < 4; i++) >> It shall be RTE_BBDEV_ENQ_STATUS_SIZE_MAX instead of 4 ? > Thanks, I can update this in the v2. > >> >>> + if (q_data->queue_stats.enqueue_status_count[i] > 0) >>> + fprintf(f, " Enqueue Status Counters %s %" PRIu64 >> "\n", >>> + rte_bbdev_enqueue_status_str(i), >>> + q_data- >>> queue_stats.enqueue_status_count[i]); >>> + stats = &dev->data->queues[queue_id].queue_stats; >>> + >>> + fprintf(f, " Enqueue Count %" PRIu64 " Warning %" PRIu64 " Error %" >> PRIu64 "\n", >>> + stats->enqueued_count, stats- >>> enqueue_warn_count, >>> + stats->enqueue_err_count); >>> + fprintf(f, " Dequeue Count %" PRIu64 " Warning %" PRIu64 " Error %" >> PRIu64 "\n", >>> + stats->dequeued_count, stats- >>> dequeue_warn_count, >>> + stats->dequeue_err_count); >>> + >> why not print acc_offload_cycles aas well? > I don’t personally find them necessarily useful for this kind. > But still if you believe these might help sometimes, no problem I can add them in the v2. Kindly confirm your preference. This is the only remaining element in the structure not getting dumped. If you think, it is not useful at all - you may leave it. > >>> + return dev->dev_ops->queue_ops_dump(dev, queue_id, f); } >>> + >>> +char * >>> +rte_bbdev_ops_param_string(void *op, enum rte_bbdev_op_type >> op_type) >>> +{ >>> + static char str[1024]; >>> + static char partial[1024]; >>> + struct rte_bbdev_dec_op *op_dec; >>> + struct rte_bbdev_enc_op *op_enc; >>> + struct rte_bbdev_fft_op *op_fft; >>> + struct rte_bbdev_mldts_op *op_mldts; >>> + >>> + rte_iova_t add0 = 0, add1 = 0, add2 = 0, add3 = 0, add4 = 0; >>> + >>> + if (op == NULL) { >>> + snprintf(str, sizeof(str), "Invalid Operation pointer\n"); >>> + return str; >>> + } >>> + >> how about also covering mempool and opaque_data pointer - they may also >> be helpful in debugging? > What have got in mind specifically? > Note that underlying memory may not always trace to actual mempool (due to signal processing sizes not always fitting with mbuf size requirements, some mbuf are sometimes indirectly constructed). > Any specific suggestion welcome though. Yes, It is understood that underlying mbufs may not belong to this mempool .  However, being a library function the underlying PMD implementations may be different.  I see no harm in to dump most/all of the elements, they may be helpful in debugging. > > > Thanks, > Nic >