From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B2C9A4C99; Mon, 25 Mar 2019 07:34:35 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 5609014005B; Mon, 25 Mar 2019 06:34:34 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Mar 2019 06:34:27 +0000 To: David Marchand CC: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , "Yigit, Ferruh" , dpdk stable References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> From: Andrew Rybchenko Message-ID: <98079459-1bfa-dc1b-c6f3-e32028be646a@solarflare.com> Date: Mon, 25 Mar 2019 09:34:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24510.003 X-TM-AS-Result: No-8.379700-8.000000-10 X-TMASE-MatchedRID: u7Yf2n7Ca/12LasmHuCXMSa1MaKuob8PC/ExpXrHizys/t8iuh5J87ml eb3iXVf4VaYLWcd8stZ83td45IE6DpO7ij3TaTVL9Ib/6w+1lWS+1Vx7rDn4r1wpnAAvAwazK93 7aFdF5XPu9s1Tb1CRqXpmpQkPv+6/AYpB0V3us28k78SxLKShoEEKKv3+tzX70apUEpjsc8HzTu 35URal5iBkhyrvdMSlklPOPDP4bOjHuFqMm/pFRcg6fo0rxLVrJd2n2XoSRFnnZVNiuSZvW12vN tlQium/8qSNUYFLbEodw3jH6W1gvaTCGfFuDW355BgEdUqqANR9LQinZ4QefL6qvLNjDYTwsuf7 RWbvUtxjYGxdKEQ2dClF73DKzokOtUqi1V5Alo0sC6AkrnLRmKjL5Wv8Z94REkS3yqgF823FKb9 TPrCyLw6HyPiIugBm+OYoyvjvCsV7L0ApdmMF8C5ZVZv9/BGWRJY6zZnK3vnG1lDD/jEXss9Mew WJ3Ob908gr49Yc9hqI5zE67yZyQ5n3dB1BpxUEm3pIQOIJ7GinNpUKLkqur0lLd09OvFjP X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.379700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24510.003 X-MDID: 1553495675-isa8lL5svpFP Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 06:34:36 -0000 On 3/23/19 10:12 PM, David Marchand wrote: > On Fri, Mar 22, 2019 at 6:43 PM David Marchand > wrote: > >> On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko < >> arybchenko@solarflare.com> wrote: >> >>> In fact bad Rx checksum counters follow and I think they should be in >>> this line. >>> >>> That's why there is no \n here from the very beginning. >>> >>> My fix for the bug (local) just add \n in else branch below. >>> > Just to be clear. > > origin/master: > - iofwd engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 121811360 TX-packets: 121811392 TX-dropped: > 0 RX-bursts : 3806605 [100% of 32 pkts] > TX-bursts : 3806606 [100% of 32 pkts] > > - csum engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 5467488 TX-packets: 5467520 TX-dropped: > 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: > 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 170859 [100% of 32 pkts] > TX-bursts : 170860 [100% of 32 pkts] > > > So, as suggested, I added a printf("\n") in the else for the csum engine > block: > > - iofwd engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 259770560 TX-packets: 259770592 TX-dropped: > 0 > RX-bursts : 8117830 [100% of 32 pkts] > TX-bursts : 8117831 [100% of 32 pkts] > > - csum engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 7834016 TX-packets: 7834048 TX-dropped: > 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: > 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 244813 [100% of 32 pkts] > TX-bursts : 244814 [100% of 32 pkts] > > > deal ? Yes, thanks a lot. Andrew. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DD554A05D3 for ; Mon, 25 Mar 2019 07:34:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D4914C9D; Mon, 25 Mar 2019 07:34:36 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B2C9A4C99; Mon, 25 Mar 2019 07:34:35 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 5609014005B; Mon, 25 Mar 2019 06:34:34 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Mar 2019 06:34:27 +0000 To: David Marchand CC: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , "Yigit, Ferruh" , dpdk stable References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> From: Andrew Rybchenko Message-ID: <98079459-1bfa-dc1b-c6f3-e32028be646a@solarflare.com> Date: Mon, 25 Mar 2019 09:34:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24510.003 X-TM-AS-Result: No-8.379700-8.000000-10 X-TMASE-MatchedRID: u7Yf2n7Ca/12LasmHuCXMSa1MaKuob8PC/ExpXrHizys/t8iuh5J87ml eb3iXVf4VaYLWcd8stZ83td45IE6DpO7ij3TaTVL9Ib/6w+1lWS+1Vx7rDn4r1wpnAAvAwazK93 7aFdF5XPu9s1Tb1CRqXpmpQkPv+6/AYpB0V3us28k78SxLKShoEEKKv3+tzX70apUEpjsc8HzTu 35URal5iBkhyrvdMSlklPOPDP4bOjHuFqMm/pFRcg6fo0rxLVrJd2n2XoSRFnnZVNiuSZvW12vN tlQium/8qSNUYFLbEodw3jH6W1gvaTCGfFuDW355BgEdUqqANR9LQinZ4QefL6qvLNjDYTwsuf7 RWbvUtxjYGxdKEQ2dClF73DKzokOtUqi1V5Alo0sC6AkrnLRmKjL5Wv8Z94REkS3yqgF823FKb9 TPrCyLw6HyPiIugBm+OYoyvjvCsV7L0ApdmMF8C5ZVZv9/BGWRJY6zZnK3vnG1lDD/jEXss9Mew WJ3Ob908gr49Yc9hqI5zE67yZyQ5n3dB1BpxUEm3pIQOIJ7GinNpUKLkqur0lLd09OvFjP X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.379700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24510.003 X-MDID: 1553495675-isa8lL5svpFP Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190325063423.nPQbajbJ2hHiECW0SSCmUtGtmWrxR2nupRAovn1PLr4@z> On 3/23/19 10:12 PM, David Marchand wrote: > On Fri, Mar 22, 2019 at 6:43 PM David Marchand > wrote: > >> On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko < >> arybchenko@solarflare.com> wrote: >> >>> In fact bad Rx checksum counters follow and I think they should be in >>> this line. >>> >>> That's why there is no \n here from the very beginning. >>> >>> My fix for the bug (local) just add \n in else branch below. >>> > Just to be clear. > > origin/master: > - iofwd engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 121811360 TX-packets: 121811392 TX-dropped: > 0 RX-bursts : 3806605 [100% of 32 pkts] > TX-bursts : 3806606 [100% of 32 pkts] > > - csum engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 5467488 TX-packets: 5467520 TX-dropped: > 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: > 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 170859 [100% of 32 pkts] > TX-bursts : 170860 [100% of 32 pkts] > > > So, as suggested, I added a printf("\n") in the else for the csum engine > block: > > - iofwd engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 259770560 TX-packets: 259770592 TX-dropped: > 0 > RX-bursts : 8117830 [100% of 32 pkts] > TX-bursts : 8117831 [100% of 32 pkts] > > - csum engine: > ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 > ------- > RX-packets: 7834016 TX-packets: 7834048 TX-dropped: > 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: > 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 244813 [100% of 32 pkts] > TX-bursts : 244814 [100% of 32 pkts] > > > deal ? Yes, thanks a lot. Andrew.