From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7530A0548; Tue, 17 Aug 2021 16:44:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A6AD407FF; Tue, 17 Aug 2021 16:44:28 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 42FB94014E for ; Tue, 17 Aug 2021 16:44:27 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="212992255" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="212992255" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 07:44:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="520514057" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 17 Aug 2021 07:44:26 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 17 Aug 2021 07:44:25 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 17 Aug 2021 07:44:25 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 17 Aug 2021 07:44:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KSpsj/bjmweJRdtcaKevz9YqzjKLi/aEg8QQwZJg/48wff/BlPGvsnm2+lapTdlAafXZZLp9aGlaJr7u3m65FtUNRjNj1XZV5lljzhHkoySM+dEXRszkM330EZQ6HeOL5iFtBpv1olnXaKTItdPw4xg0/O+bN3AuhNCGo5MDbzPv+tfQsFq/7kIGYd0D+XynNUkMfjHyNkn9lW4T73oG1rCsif33pyILKe89X37k02lVUiTqaeILoxLdnRd85oL5+PkoJ13w10QoIykJGK61cw6i2VaAPDYUvUPPBtgXQZiT9PE3Qzr6mH++7tcfhIAASPAoRZLYKxlSTcpupWPUaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FPdXoG3T0Wgjc7Otl5J3B7ZULyWy8deI6Kt8hF+JJI=; b=NBFbh0nqFMVKJBR2gPWCBZ6e1JnFW8dYDQfkRZv18bvNY+Zipxkujooc8kW4QJLzs1Z92rDhyJF84jZHcuaxMwY3YPErwo5IeCyvGhyuVn39QZk1qTkt8D19XdlknqEeUZhtjjmQPdqjwBM3ZxAFxvo5UgrPfAG7GNBV0rp/pd7EilYnHDfcFgHgqgxjA9aS03YCWhZ/uJWAPngB+6ixBvfvH8UcCaC9Mlre7A+tMPw9Qu6r/yYfP1qIFnWcnkWb8kq8omCw9ZwgqQCMHy3+8qzjjqXANXPZSOScWSwaX+klOMNlcCEJUkIF27ZazJ2KvvAoZfqiYBfB44HvdIkRSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FPdXoG3T0Wgjc7Otl5J3B7ZULyWy8deI6Kt8hF+JJI=; b=MHKZ+rWxDL7d9Ztac7OWKP+jmRQsZBrmG50PCkL7ABHD4cZEpwRUk5FWFeM+CeA833qrfZUCJvS3fgQYiXexfjRJ9ZvPh8c2ViRP7pp/T7ee9V9hNmJaGIxR+/okwhRVrrcs1OEX6z+9Go1klDjnM2q03/VcUlznOpm2qogQUB4= Authentication-Results: corigine.com; dkim=none (message not signed) header.d=none;corigine.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4998.namprd11.prod.outlook.com (2603:10b6:510:32::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Tue, 17 Aug 2021 14:44:24 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021 14:44:24 +0000 To: Heinrich Kuhn , CC: Simon Horman References: <20210716083545.34444-1-heinrich.kuhn@netronome.com> <20210729134711.35870-1-heinrich.kuhn@netronome.com> <20210729134711.35870-5-heinrich.kuhn@netronome.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <9815f897-3e04-26e7-1048-8f9eda29d0aa@intel.com> Date: Tue, 17 Aug 2021 15:44:19 +0100 In-Reply-To: <20210729134711.35870-5-heinrich.kuhn@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR3P251CA0012.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by PR3P251CA0012.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 17 Aug 2021 14:44:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3eb75fd7-4677-4041-bece-08d9618d819a X-MS-TrafficTypeDiagnostic: PH0PR11MB4998: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9MOMyAfTW0X92NZuIm0TMAAltAAERmWeKbHdfohKf54zRNGJ87sVgnPXvfOichkghSl3gkzP9SPdv9NPrOK7dMdQIYLRnTkKlduJjTF0BMstqih4FKOjMJjRV7kNs1C6jNycNOoTiLhVlB5p0jgZoJT70OLcy41srjF0ZJaX4AuGZ1p/s3o4BJbqlb21jaznUoGkoEEK4LX60D4faFGc9h+qEL4nP0RdgeP2heC/w5mmDm4zCggY+B/LT+x7lz9HX7kPEcjN1vkrI3mmJJnzeRnKISR5HXcIHsY5U46nttttUv9OWsnUZAqa8ibqgPAjnYdUqfzGPQmwICzISOVwAXDJSrb5ZgGd/z0oqRICQNLkS2LU70bK2ZQ1UlJ1kGq9++whcgEfaY+H+kIIGmjgyZAEUk0OjMSy/7byhNqFWGNnRk4tPKf4DeOaTVjgwepcyH9KTytho3Xo1duya6tQTYnwAqBD5UE4N38w+pdtfFCSqCCqCvfKJf7cIEBIme9G5BSgjd0QU5VmtciqETdjTOZtA9bp5pzNff8dvPPystj8f175YrF7KoCTaRh9+ilaNVwDYJQzomdzdSURWLt4AKAXllG+j9piw+OEugkoXgkV5Eeyw4LZahQ4kvsA+jl+WPZFlUKFqty6Xd/pwCIEG7H4uczgu7ok0SUaw5qi1aqBQ7GxAp2mXWkqkTQcAUDFedMkOhJeVB8OKUis/BFvJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(366004)(31696002)(26005)(36756003)(83380400001)(8676002)(186003)(8936002)(31686004)(86362001)(956004)(2616005)(4744005)(53546011)(4326008)(2906002)(66556008)(66476007)(5660300002)(6666004)(44832011)(38100700002)(16576012)(66946007)(6486002)(316002)(478600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXMrU0YwLyt4TzZPSmJNWW5CekJob1RwaU0wcDh3d1M1dDRqeW4xSkNyak1W?= =?utf-8?B?MTd5b1JlbUUzSHRkSTFiTFlwQ2VJUkJySW01UXJRMnZoZzN5ZlVmN3RnMGR5?= =?utf-8?B?WlpHL0R4a290RlZPb1d4NGt3K1k5Nkt3aVJGMFBJR1ZzQzZlbGo5ZGRoQ3dC?= =?utf-8?B?TUNPc0dsWDdTVWhXdDlpWTV5R2lhYXBpUDk2MmFxc0RjVkl6bkZvd3MrN0Vm?= =?utf-8?B?YVhBWFNsNEhwQ2J4THhMT004WEY1U2YyTjR4K3MrSlp1bTRZbnhtcDFWM1JS?= =?utf-8?B?c1JSMVdMMkFINUQzcElsUlFRQktuZDZvMGZuNW9ZWG9MVXUzd1pJVUNodlUw?= =?utf-8?B?Vmt0WmN0Wm1xOE1UY2JLRnBQQVUyNlJORnovTWgrMldKV09UU3cxbE9MQnN5?= =?utf-8?B?bFF3d0tUcXRXRXV6a3ptVkZGNDlzelMzU3NrQjNxQnE1a2dmb1FEcU1Vb0VO?= =?utf-8?B?OG5VMW1DMVdNYTJYQ3dMaHdNc09ZbUlMOTcwUjNkWUFGaEZmbndtTysyVEtG?= =?utf-8?B?VWFMa2Y3aFFUSEtqTlBYdFNpRXFueEM2TEJySWN6amJzVVQ1YWs1dFNBd094?= =?utf-8?B?Y2hBcEdrUDJ5aENlbnhkOFpBNTdqZVpRcVZWR2wxZ3lKejBYVVplbDN1REtp?= =?utf-8?B?YWpyczdkL2pwVHBNc1ppSVZCKy9COXFyeHpzR21ac1MyeVVZb1pvYmYvRCtG?= =?utf-8?B?Q3NVbTdMdFlqMjFidzFCbUFUYUEvTzRPKzNvUnE3SFZ3NWx1cisrRFBtclB2?= =?utf-8?B?dndadHZERXZ4M1pFSGdKNG5UMVliS09EWjJ0bE5WSmFydU8rVk5CeXNmMzFN?= =?utf-8?B?c2Vqa0lIYjRMeVZWOGhrbzkreWhQMjhxUi92dktnZUVwVERWOHpuSVN6Rm1m?= =?utf-8?B?dlVYWEVXb0FDbUZqRTZscVhIc2tiR2V4UnBRTUJSdUNTSDk1QTdjV1R1ZDBT?= =?utf-8?B?L0g5Rm4rb2JtTGN5aVAxRzkrVzNEc3NwWUJ4eGVoL09tNEw2S1M0N0swMmFW?= =?utf-8?B?Z0FPaGljbUhUazRjc3p3ZThJUXpYcCs5N1Y1UlJKemFHdWsxVEttckdiS0ph?= =?utf-8?B?ZU5FUFQ0dVhWcnUrY0QzV1I0cnBaTGZKSjJ1cVViSkJlVU9xczMycCtkOUkv?= =?utf-8?B?RkpsYTlRR05wRkpFK29sdXEwTExjM0V1RnB2VTBpaGlwQTE0dUZQT3RpODJx?= =?utf-8?B?c3Rla09BbVVnaVBCL3ZrZGR0b3BXZUJubExwN2o0ZXJKQ1ZobDdyRnF6ZlFN?= =?utf-8?B?ODR1RGdxdHNiUmphYURQQUdXaSszYXpHVnY3Y0RtTEM1SVQyQXhqWml5S0hn?= =?utf-8?B?S1lvVnEra090cGI2ZGFDMUxPZ1cxSU04a2ZBdnlpZHl6di9nMHhmMzZUNUVX?= =?utf-8?B?SWlvWmU3QjZYR0pEUGxZTU9lRFFBMjZSWXVRNy85aTdKbmMvWnljNHdROEEx?= =?utf-8?B?N05HaUo0dXYzdHZjaWVmbmhiRVJ5djFwdGtFUVgrVk5PSlVnaHRsWmFvc1Ri?= =?utf-8?B?UURpWHMxREJaNmgrdTMzaEpjaFVrb1Q3RmJKeXVvOFp2K25HWDQwZDlQNVJn?= =?utf-8?B?bUhjcVBZM1dxckNGemdYR2NEalFVZDVUS1hLNkZ2cElsTFNUTUw5TWtnZ0lq?= =?utf-8?B?RXZzOW9pM0lORWJYMFhVMElmalRyOGV5ZGZWVk5DMWZnb1JIR1BYQndGMU1G?= =?utf-8?B?YWlyUlU4MVFEOXVDdmtYbzA1enVBR2xjaUQ4SG05L3NsL211SDdlaU5zMFNp?= =?utf-8?Q?Gi6CxWE2olNXzrGM8FAVPasHwss6p3M2mVYnYlj?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3eb75fd7-4677-4041-bece-08d9618d819a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 14:44:24.4277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: abRgDJ9jn+TWgk7jTP/wEvbS09+mJswAN7im+mHH21zHxGRmDSGy2bQJkNHkMLJUwvahR9ObOmGx7e5pRo6oHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4998 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 4/7] net/nfp: prototype common functions in header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/29/2021 2:47 PM, Heinrich Kuhn wrote: > The majority of "ethdev" type functions are used for both PF devices and > VF devices. Prototype these functions in the nfp_net_pmd header file in > preparation of splitting PF and VF specific functions. > > Signed-off-by: Heinrich Kuhn > Signed-off-by: Simon Horman > --- > drivers/net/nfp/nfp_net.c | 87 +++++++++++++---------------------- > drivers/net/nfp/nfp_net_pmd.h | 49 ++++++++++++++++++++ > 2 files changed, 81 insertions(+), 55 deletions(-) > <...> Following functions seems only used in this file, and you may want to keep them 'static': nfp_net_dev_link_status_print nfp_net_irq_unmask nfp_net_dev_interrupt_delayed_handler nfp_net_rss_reta_write nfp_net_rss_hash_write (I may be missed some, you may want to double check all.) Rest of the set looks good to me. Thanks, ferruh