DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ibtisam Tariq <ibtisam.tariq@emumba.com>,
	chenbo.xia@intel.com, cristian.dumitrescu@intel.com,
	jasvinder.singh@intel.com, john.mcnamara@intel.com,
	reshma.pattan@intel.com, konstantin.ananyev@intel.com,
	marko.kovacevic@intel.com
Cc: dev@dpdk.org, roy.fan.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v4 7/7] examples/vhost_crypto: enhance getopt_long usage
Date: Tue, 23 Mar 2021 12:27:09 +0100
Message-ID: <981675b3-49f8-2284-03d0-b8b86c9e145f@redhat.com> (raw)
In-Reply-To: <20210204073420.2421-7-ibtisam.tariq@emumba.com>



On 2/4/21 8:34 AM, Ibtisam Tariq wrote:
> Instead of using getopt_long return value, strcmp was used to
> compare the input parameters with the struct option array. This
> patch get rid of all those strcmp by directly binding each longopt
> with an int enum. This is to improve readability and consistency in
> all examples.
> 
> Bugzilla ID: 238
> Cc: roy.fan.zhang@intel.com
> 
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
> v4:
> * Set indentation of preprocessor directives.
> 
> v3:
> * None.
> 
> v2:
> * Remove extra indentations.
> * Remove extra block brackets in switch statement.
> * Change enum names to start with OPT_ and remove KEYWORD from enum names.
> * Remove unused short options.
> 
> v1:
> * enhance getopt_long usage.
> ---
>  examples/vhost_crypto/main.c | 86 +++++++++++++++++++++---------------
>  1 file changed, 50 insertions(+), 36 deletions(-)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2021-03-23 11:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  7:34 [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: " Ibtisam Tariq
2021-02-04  7:34 ` [dpdk-dev] [PATCH v4 2/7] examples/l3fwd-acl: " Ibtisam Tariq
2021-02-04  7:34 ` [dpdk-dev] [PATCH v4 3/7] examples/packet_ordering: " Ibtisam Tariq
2021-02-04  7:34 ` [dpdk-dev] [PATCH v4 4/7] examples/performance-thread/l3fwd-thread: " Ibtisam Tariq
2021-02-04  7:34 ` [dpdk-dev] [PATCH v4 5/7] examples/qos_sched: " Ibtisam Tariq
2021-02-04  7:34 ` [dpdk-dev] [PATCH v4 6/7] examples/vhost: " Ibtisam Tariq
2021-03-23 11:19   ` Maxime Coquelin
2021-02-04  7:34 ` [dpdk-dev] [PATCH v4 7/7] examples/vhost_crypto: " Ibtisam Tariq
2021-02-05 16:21   ` Zhang, Roy Fan
2021-03-23 11:27   ` Maxime Coquelin [this message]
2021-02-18  9:59 ` [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: " David Marchand
2021-02-18 10:47   ` Ibtisam Tariq
2021-02-18 11:14     ` David Marchand
2021-03-23 11:52 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=981675b3-49f8-2284-03d0-b8b86c9e145f@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ibtisam.tariq@emumba.com \
    --cc=jasvinder.singh@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git