From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: David Marchand <david.marchand@redhat.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>
Subject: Re: [PATCH 00/10] ethdev: cleanup deprecated defines
Date: Tue, 23 Aug 2022 19:08:33 +0100 [thread overview]
Message-ID: <982092f2-f7ef-f2c1-1307-6fdc27734577@xilinx.com> (raw)
In-Reply-To: <CAJFAV8wXA5zmXbwMWFJ4o0arAuNyzL-UkepQckFceWA0LtKWHw@mail.gmail.com>
On 8/23/2022 9:41 AM, David Marchand wrote:
> On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Remove deprecated because of invalid namespace defines.
>>
>> Andrew Rybchenko (10):
>> ethdev: remove deprecated link speed and duplex defines
>> ethdev: remove deprecated Rx and Tx multi-queue mode defines
>> ethdev: remove deprecated defines for RSS configuration
>> ethdev: remove deprecated Rx and Tx offload defines
>> ethdev: remove deprecated DCB and VMDq defines
>> ethdev: remove deprecated tunnel type defines
>> ethdev: remove deprecated flow control defines
>> ethdev: remove deprecated VLAN offload configuration defines
>> ethdev: remove deprecated maximum Rx MAC addresses define
>> ethdev: remove deprecated metadata dynamic fields defines
>>
>
> Same comment as for the mbuf flags patch, we have a cocci script to do
> the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci
> We can reference it in the release notes.
>
Agreed. I will group release notes updates while merging. And note
'devtools/cocci/namespace_ethdev.cocci'.
> I suspect the RN will grow quite big for 22.11.
> Can we perhaps have a single entry for ethdev, listing all the
> different defines in a sublist?
I am also not sure about benefit of the multiple commits, I will keep as
it is since it is already split. But maybe can be squashed while pulling
from next-net.
> (and looking again at the other cleanups, this last comment applies to
> the mempool series too).
>
>
> I sent some comments, but otherwise, the series lgtm and you can add my ack.
Adding your explicit ack while merging:
Acked-by: David Marchand <david.marchand@redhat.com>
For series,
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
Series applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2022-08-23 18:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 19:05 Andrew Rybchenko
2022-08-04 19:05 ` [PATCH 01/10] ethdev: remove deprecated link speed and duplex defines Andrew Rybchenko
2022-08-04 19:05 ` [PATCH 02/10] ethdev: remove deprecated Rx and Tx multi-queue mode defines Andrew Rybchenko
2022-08-04 19:05 ` [PATCH 03/10] ethdev: remove deprecated defines for RSS configuration Andrew Rybchenko
2022-08-23 8:41 ` David Marchand
2022-08-23 18:08 ` Ferruh Yigit
2022-08-04 19:05 ` [PATCH 04/10] ethdev: remove deprecated Rx and Tx offload defines Andrew Rybchenko
2022-08-04 19:05 ` [PATCH 05/10] ethdev: remove deprecated DCB and VMDq defines Andrew Rybchenko
2022-08-23 8:41 ` David Marchand
2022-08-23 18:08 ` Ferruh Yigit
2022-08-04 19:05 ` [PATCH 06/10] ethdev: remove deprecated tunnel type defines Andrew Rybchenko
2022-08-23 8:41 ` David Marchand
2022-08-04 19:05 ` [PATCH 07/10] ethdev: remove deprecated flow control defines Andrew Rybchenko
2022-08-04 19:06 ` [PATCH 08/10] ethdev: remove deprecated VLAN offload configuration defines Andrew Rybchenko
2022-08-04 19:06 ` [PATCH 09/10] ethdev: remove deprecated maximum Rx MAC addresses define Andrew Rybchenko
2022-08-04 19:06 ` [PATCH 10/10] ethdev: remove deprecated metadata dynamic fields defines Andrew Rybchenko
2022-08-04 19:29 ` [PATCH 00/10] ethdev: cleanup deprecated defines Stephen Hemminger
2022-08-05 8:01 ` Andrew Rybchenko
2022-08-23 8:41 ` David Marchand
2022-08-23 18:08 ` Ferruh Yigit [this message]
2022-08-24 6:46 ` David Marchand
2022-08-24 7:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=982092f2-f7ef-f2c1-1307-6fdc27734577@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).