From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF7574559B; Fri, 5 Jul 2024 19:33:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA211410EE; Fri, 5 Jul 2024 19:33:12 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2050.outbound.protection.outlook.com [40.107.243.50]) by mails.dpdk.org (Postfix) with ESMTP id 12FDB410D5 for ; Fri, 5 Jul 2024 19:33:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cDlCywYqPi4gHC18TDBIsXvZZLvLKWrG6XqBOFuTps2+Ztup46vfh1U98zqC6zD2bir9nSy47qA6aiOhjEnmzMa7ycsF2XYyKDSYWDUGJZa3hIwuMgA8edaJamGmiRLd+R6MFcyKXpo2E6LjasCB2QtHAiwsd/Maw+lzMdcAKW2uiGrZgY/KzDZ8c5eNkISY0rXLmoHC64/txb9Veopy5C8J47CLzxGCVatEzAKsz4Q5MVCy4ma9PwOmRg+RebLNKOIlGn4TCcLb2RDNKNIjIHhzL6YqznYg1NWPFPMKfnd3xXUz1HvbDFUa8XnldI26GYnWc9uYCVFZN5KaR9dn0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=afmyTRMIksqJe2M4iI3F71uYp9FJL1Ka2e+8XKgHuR0=; b=RI28HSS/FMl/X9Z/fIrfkHIrHEhOlcer4fEpNqVb03ciWElfeVButiSIQspfCyQ+XLCIB5KV2dzYiEXti8GgAy3UJL40MlR+iISQK7FHgA7WrFahalYEY3izLz3NU4X2ZZhCeu/rak1twxqhGEu0uADTD3YPlPgOBN9ln8hI4eefzI3GRKHWsIyjedkHbPFKEgX6CcwpPxMc1iKKNFeQDo2nTYMUefzngGvxRPEkbFTMGKGS51lFIEciwuLUdcqLLiUVNHgv4GuoPUn1TZIstxZxiba5E2Hg6jrPRdx1XUHKOzGHkdYjMbBORW4t5YFgWvYn48/EoVDCvtmLGPTcuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afmyTRMIksqJe2M4iI3F71uYp9FJL1Ka2e+8XKgHuR0=; b=W6imgLt6cwNHJdr1haPk2lU44FvB9GYn/deouy+NwV0mNt2BE9g+90v5cheki2gtpt9MX6HsBJz1oOxmXj4QNg97TtWRpPkqELGhpc1rdpfyXxLWrEblm7qe+SOnXTv4QLJS3vf1tcPIBr+KopSmze8RVl0hKovIwWJF4IRGU28= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CYYPR12MB8872.namprd12.prod.outlook.com (2603:10b6:930:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.29; Fri, 5 Jul 2024 17:33:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7741.017; Fri, 5 Jul 2024 17:33:05 +0000 Message-ID: <9822cf6d-7c96-4e44-a210-88838b89b286@amd.com> Date: Fri, 5 Jul 2024 18:33:00 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ethdev: Add link_speed lanes support To: huangdengdui , Damodharam Ammepalli Cc: dev@dpdk.org, ajit.khaparde@broadcom.com, kalesh-anakkur.purayil@broadcom.com References: <20240617203448.97972-1-damodharam.ammepalli@broadcom.com> <4a0d1bc0-4edf-4653-8b23-f2b12a924b3d@huawei.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <4a0d1bc0-4edf-4653-8b23-f2b12a924b3d@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0264.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::36) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CYYPR12MB8872:EE_ X-MS-Office365-Filtering-Correlation-Id: 47c5483f-70ed-4688-4668-08dc9d188726 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?enhyckdPR3VPM2xEdVFwRXJnV0UwWjJUMFd5MDlpckRxb1ZaRnFHZ242Vmxj?= =?utf-8?B?eHlhV0o2NU80SVRTNmNrWkxuQkx2NjRsc2g3d0F4VkdlL3NDbEZUZS83UzJQ?= =?utf-8?B?YVZjdUROQTlSSm1PaVY5OE00dU1ZQU8wa0RHUXZ4RW1BNjREbnBWZU9IU2Z2?= =?utf-8?B?SEZidG5Kb2tCMDlwdFhIZTk4YUhzV2F3VG1RbXRJVUwzQ3hFWTJzWk1iNXJY?= =?utf-8?B?Uk9XWlVVSDdZYzd2L0l3d2ZwTk9hTGYza1EybFh0aUtoR0hqQ0xYUnFrUnFk?= =?utf-8?B?cHc5WTFiaHJ5NDBYY1ZiZGlBM1Q0eWx5OWN2TlV4ZzlpNUVFOGV4SFRGS2dW?= =?utf-8?B?b2NnWStyQ3lGNnA4OFkzZUZZVk82U3VtS0tFNVVVcUxjUXgyeU5BeDBpVmJ2?= =?utf-8?B?ZzFFbU1PcSsyRWxQV1lCc3hTOE1QZklxYU9XVFBrVDFJMGhDU0k4bjNCU01K?= =?utf-8?B?dmNrZ2ticWZrUlBsa2Vja0VKNjArd05MWXBZamFBeUR4SmRHYlVuU3htMm80?= =?utf-8?B?MU5vMDhnTWlEbHNLTjRHZU1UaWcwVnJjbURYY0U3YStmbjdRYWxmdy85cHk0?= =?utf-8?B?MmxnR0lEajlsU3A5YTVRWksyZGdRZTUxaXZieU13SUY1cVpNTmQ1eUNXVlBE?= =?utf-8?B?d1BsSGo5eEpyV2Qza3FSRkpoam1yRVVMck1KRWRYaTFnSEFhS0trYklubUEy?= =?utf-8?B?T0dNVWVLam9JNWU3UVcxd2RYRnZJWXhRd2dJVExiZmN5NUpQenlqVVpKdUpw?= =?utf-8?B?dUtKTjYzUmRINEtHM1k2dml6MEI5SDlSYk9GcFlzZGxjKzgwVG1uQVlPeitu?= =?utf-8?B?RUlScGNQa2FHMFNZRHJFODFxODV5d1dNaTVXcEM3bFRPSzB2ZXBZdS80YWZr?= =?utf-8?B?dS93bXloMjZZL0ZNTVYxMHlYb0d2bEtaMWlXUytiRzM1dGEwTFNncVVOQlgw?= =?utf-8?B?QzFTNldpR0lMOGt0UzFNM0kxemx0UTlGcUVSYzcxdXV3aFNlaHF1aW5IUm9E?= =?utf-8?B?R2pDUjc0bEpyTXpMUXBraGp6eGhmbjV1UlZiSmRnUCtUczIzMzIvMnBmVS90?= =?utf-8?B?bFgyRlVKUmovS1pZVmRpZWdqRkNvOGFKenYveUlxT2R5TzI2UHNTYzRCV044?= =?utf-8?B?b0hhZ0M4c2xoM2dhaExuanlDbnNwd2NEZmg2ZDJZell5b3RLNFpraTZNNW9N?= =?utf-8?B?OEZheFVMV3U3Tng3ZFlVNmVjUHdLYnl4WURJRExOMGlpbkh2NENRQ1MwMlJh?= =?utf-8?B?K3ZDTzFlTitoVUpDRUd3T0R1MjBJQStLbVd6czl5cUxDSFFrdlZzZFB3OWxw?= =?utf-8?B?aVZaa25xUGJ2VHJxbTg5cHpKTHdzRUl3ZVNYNTdvaVUzZVV5QzRqc1ZubWo2?= =?utf-8?B?SHRhdVJXcUlHdElIdGg1SWJnaXRFMlhEY3RoNVc4djErM01OeVpWaFdUblAy?= =?utf-8?B?RzhjTVUvejY1QVo4NUxuRzMzR1U2bjNlSFdlQk5aSitmVGdWb0daNjg3UE9N?= =?utf-8?B?QnoveVBXVnhqaDdSNEt4VnUzbnFEcFZMRVYrQldFL09nOWFjZjQwZUpndUxH?= =?utf-8?B?eE1nMG1PaHBteG5BWXVRZUhLREYvY3hpMW1VcHBidHN2UXhjQ1FjeEpqMERK?= =?utf-8?B?cklJQ0NQUTdIYkhWemt1bUp1UWg0U0RoUThGR3lLQ01uSU44TUtwNFlFa3hK?= =?utf-8?B?RGFpRVFmTW9GdUwwaXRFbVlNT2VwenI1Q1UrMGxlSXNqOURUUENXbXZ1SjFh?= =?utf-8?B?b1NwVDdrRXRTdEVqRGJMeFFFSTVaeHIyNDZ6WFNGeG1XYTJtNW1KS2lmTndw?= =?utf-8?B?WVBXaUo2cEFua1d0SHlCdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnBqNFlqQ0ZDOW8zU0RSZ21hVFVVR3FrNnpRdUR4NExBTlV6THV1cWFhYkpu?= =?utf-8?B?dXVEbm83eExnVDJBNmU3ZEFKUEpNVStVd29jZDFIUXplMDMyNnpoSUxFRFdm?= =?utf-8?B?djJsak50NkNiS3JyQThuTjNURUhaWVAwRkVlUk5zcEFsTmZ5dkR0WWYxUTZP?= =?utf-8?B?djRaRGUxUHJwUFZoNFZ4WUY3L3NKejN5NGNRbGh5V3FPb1VNNzhCcGM2N2Z6?= =?utf-8?B?VE9JVGxqdzBSQ1EvRUllUHMrUkRRS1NBcFlDNDUwOWcwUGdYWXhMcmZ3SXRh?= =?utf-8?B?bERkaGxXekdWWmc0YkpFUVoxRnhzaUVodmNyZ3draG1LK2dOK3NJYW9LN01l?= =?utf-8?B?Y1EzVHdWOCtrNWtJRE5vMGhGQXFEcXNtRUZpYWg0emhHWFIxUDJzWjhXZ2J0?= =?utf-8?B?NkdKMCs5NjN5WnVsK2lXYzhCVjRwMGlNelpTaWZKNUdZNklPT1Jyd0tFZEM2?= =?utf-8?B?bjJydnhyNVFIZENhZXduQWFKWFgzTGhDMDMyNTBHY0lzVDl2RDhlOWJSVXp1?= =?utf-8?B?OVdNQ1E5dFZyVW5VbmZ1azlJbXVveE16eE11bEJWdytGYmNLRVVZUHYzRkFh?= =?utf-8?B?M2M0eFlTalFjd0xOZzBMNXhzaU4rRS9yUlhzZXFaa2E4RE1OSlAvKzc1Ull4?= =?utf-8?B?RXNGaE9UNWxlYnhzRGNUbTJwb0J2Zit2NmN3ZlJOc0tIZ09UZDV4WEs0dTJC?= =?utf-8?B?YWxkR2RuRzJ5WDM1Rm9YUk9qbnJ4d3pBVEpkS1JSdlNmT3NUL1FKK3M0anAr?= =?utf-8?B?RzZ6YVlOTFlnNFliVmFrRU5EVEtnWXQxZGRDWWJxVFpESTFTaHZ1RGxOODM1?= =?utf-8?B?dXZqSHNWeU9Ya0x1RVE1Nk90NDVrbitrR1NhcVBaV2NGRDA3bjVoZ08waWV2?= =?utf-8?B?N2FsMUFxMUxaUUN1T1JtdUtiZXRhenhFbEFGTThka25TVWRLWlV6SkNSZnk1?= =?utf-8?B?NUxpM21temd1MFZySytIcmZCdlhycXhNREFQRUM1b1BkVzRBL2F1VlMvbWJj?= =?utf-8?B?WkFkWE45TUJmSDFIdFYvL2FWM2Y4OWtSTVB3cm5ta2hqMm0yTzlPV21SVFpo?= =?utf-8?B?MC9DL0xMRHNMd0RITEVGMG9xaUFMRlNQdXczZXBFY0NXTlJwRmc3b1lwSWNp?= =?utf-8?B?Yytmd25Kc3FDd01wYjlhS3JwMVdyU1pkZUdXZ3BZSXloVjdxeW16akJpb2Vl?= =?utf-8?B?L3RyWk9pYmlGTTdIdzBmMlVxeEplOWpJdzdKMGNRSlFZWlNSMnFjdHNZT0Vr?= =?utf-8?B?ZlhVTkVjWFFmanpFcmRuekF1TzJjemFldFA1UWlubE5XT1pTYTRUdU1NbThk?= =?utf-8?B?d3RpQnFEOCtXMFpzbXZnb2tkaGNnZWVQNlJxUWRiM2tlT0RVTFJRYVJzTmth?= =?utf-8?B?c0NIejhkTUpqb0svZEtZRFo0VW5qZnV0R1o0a29HeVNLRlpsZGtoaUZLcFM1?= =?utf-8?B?WFpFK0FxWGt2Y25UdWlvK2xtZFdYemtKR051OEQydXFzRTlXY2FrTDNVZHY3?= =?utf-8?B?QjhBNytCSE44TE1LcEpNL3AzdlpSeUc1V1I2UWtWTWhITUFCSkhRVzZsblJl?= =?utf-8?B?bGFvK3pqS09vWERPWldEMW96bEJuMncyQ21lcER0MkwrWDhsendVMzB5Rklp?= =?utf-8?B?VzhGcVpFYitXTVczUTB0cVJFcndSbTZVeG5yVU5Vdkc1d081RG80bndicENa?= =?utf-8?B?MkRuNkZUc0IyTTRkakN4U2JqWGdBamZaRlJwQ2FBRHVMNkljVzNsNTlZUTJk?= =?utf-8?B?V1U4Y1pOSGQwSnk2NGpicXdTdVAxWjNIZVFMMFZjejhPZTFpTHdkZ3VLL1Zu?= =?utf-8?B?dTJpWGVvS1BjdEUvTHUwL3J4WGJFVmN3YmxOUkQzSEk0eDdzWitzRmZneUpJ?= =?utf-8?B?aFk2MXpTcnJvRXJDR3JyWEd1SmZwN21oOTB6RFc3ZnM2WGlPWUlzZGNpcWsr?= =?utf-8?B?WVRWQ1B3Yzl2QUQ0R0N0eDJhLzNiVDRob2ZOeHllcjBSdzh5dFFJeWJHOUF0?= =?utf-8?B?bUJ6TXUxVG90UXRJOFJWa0g2VzVTTmM5S0dicEVKNnFBbDFXaWJMZXVJRndW?= =?utf-8?B?aTBFUVF0ckQ4bzBHRitMVjRldEN1em0wdzBKTlE2Zlh4SS9wSTJtT2FqM2RU?= =?utf-8?Q?X2kp1ZQvm2hQ0/aL/M1JoDd+w?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47c5483f-70ed-4688-4668-08dc9d188726 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2024 17:33:05.3981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: APHAlSVe3AGOumvEClrDoQfmcW8M83UU2lByEnW+qDsaBSY5VmoWhsJXTppv6LOo X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8872 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/26/2024 3:19 AM, huangdengdui wrote: > > On 2024/6/26 5:07, Damodharam Ammepalli wrote: >> On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: >>> >>> Hi Damodharam >>> Here are some suggestions. See below. >>> >> Thank you for the review. >> >>> On 2024/6/18 4:34, Damodharam Ammepalli wrote: >>>> Update the eth_dev_ops structure with new function vectors >>>> to get, get capabilities and set ethernet link speed lanes. >>>> Update the testpmd to provide required config and information >>>> display infrastructure. >>>> >>>> The supporting ethernet controller driver will register callbacks >>>> to avail link speed lanes config and get services. This lanes >>>> configuration is applicable only when the nic is forced to fixed >>>> speeds. In Autonegiation mode, the hardware automatically >>>> negotiates the number of lanes. >>>> >>> >>> >>>> + >>>> /* *** configure txq/rxq, txd/rxd *** */ >>>> struct cmd_config_rx_tx { >>>> cmdline_fixed_string_t port; >>>> @@ -13238,6 +13459,9 @@ static cmdline_parse_ctx_t builtin_ctx[] = { >>>> (cmdline_parse_inst_t *)&cmd_set_port_setup_on, > > cut > >>>> >>>> @@ -993,7 +1022,7 @@ port_summary_display(portid_t port_id) >>>> if (ret != 0) >>>> return; >>>> >>>> - printf("%-4d " RTE_ETHER_ADDR_PRT_FMT " %-12s %-14s %-8s %s\n", >>>> + printf("%-4d " RTE_ETHER_ADDR_PRT_FMT " %-12s %-14s %-8s %-8s\n", >>> >>> Does the lanes need to be printed? >> Ferruh in the previous comment, asked not to print. >> > > OK > >>> >>>> port_id, RTE_ETHER_ADDR_BYTES(&mac_addr), name, >>>> dev_info.driver_name, (link.link_status) ? ("up") : ("down"), >>>> rte_eth_link_speed_to_str(link.link_speed)); >>>> @@ -7244,3 +7273,35 @@ show_mcast_macs(portid_t port_id) >>>> printf(" %s\n", buf); >>>> } >>>> } >>>> + >>>> +int >>>> +parse_speed_lanes(uint32_t lane, uint32_t *speed_lane) >>>> +{ >>>> + uint8_t i; >>>> + >>>> + for (i = 0; i < RTE_DIM(speed_lane_name); i++) { >>>> + if (speed_lane_name[i].value == lane) { >>>> + *speed_lane = lane; >>>> + return 0; >>>> + } >>>> + } >>>> + return -1; >>>> +} >>>> + > > cut > >>>> >>>> +/** >>>> + * This enum indicates the possible link speed lanes of an ethdev port. >>>> + */ >>>> +enum rte_eth_speed_lanes { >>>> + RTE_ETH_SPEED_LANE_NOLANE = 0, /**< speed lanes unsupported mode or default */ >>>> + RTE_ETH_SPEED_LANE_1, /**< Link speed lane 1 */ >>>> + RTE_ETH_SPEED_LANE_2, /**< Link speed lanes 2 */ >>>> + RTE_ETH_SPEED_LANE_4, /**< Link speed lanes 4 */ >>>> + RTE_ETH_SPEED_LANE_8, /**< Link speed lanes 8 */ >>>> + RTE_ETH_SPEED_LANE_MAX, >>>> +}; >>> >>> Is it better to make the index equal to the lanes num? >>> enum rte_eth_speed_lanes { >>> RTE_ETH_SPEED_LANE_NOLANE = 0, /**< speed lanes unsupported mode or default */ >>> RTE_ETH_SPEED_LANE_1 = 1, /**< Link speed lane 1 */ >>> RTE_ETH_SPEED_LANE_2 = 2, /**< Link speed lanes 2 */ >>> RTE_ETH_SPEED_LANE_4 = 4, /**< Link speed lanes 4 */ >>> RTE_ETH_SPEED_LANE_8 = 8, /**< Link speed lanes 8 */ >>> RTE_ETH_SPEED_LANE_MAX, >>> }; >>> >> I followed the existing enums code convention in rtelib. Your point >> makes sense too. >> > > I looked at the other enum code in the lib. There are many similar code styles. > Make the index meaningful to avoid conversion. For example, the parse_speed_lanes() function in this patch > >>> In addition, when lanes = 0, is it better to define it as Unknown? >>> If default lanes can return 0 lanes, The active lanes are different for each NIC, >>> users may be confused. >>> >> Ack. Are you proposing a new enum RTE_ETH_SPEED_LANE_UKNOWN or rename >> RTE_ETH_SPEED_LANE_NOLANE? >> > > I suggest changing the name to RTE_ETH_SPEED_LANE_UKNOWN, > Also change the comment to describe it as an unknown lane. > > This prevents the driver from always returning lanes=0 > even if the driver knows the number of active lanes. > >>>> + >>>> +/* Translate from link speed lanes to speed lanes capa */ >>>> +#define RTE_ETH_SPEED_LANES_TO_CAPA(x) RTE_BIT32(x) >>>> + >>>> +/* This macro indicates link speed lanes capa mask */ >>>> +#define RTE_ETH_SPEED_LANES_CAPA_MASK(x) RTE_BIT32(RTE_ETH_SPEED_ ## x) >>>> + >>>> +/* A structure used to get and set lanes capabilities per link speed */ >>>> +struct rte_eth_speed_lanes_capa { >>>> + uint32_t speed; >>>> + uint32_t capa; >>>> +}; >>>> + > > cut > >>>> +__rte_experimental >>>> +int rte_eth_speed_lanes_set(uint16_t port_id, uint32_t speed_lanes_capa); >>>> + >>> >>> Is it better to name 'speed_lanes'? >> Are you proposing to rename to rte_speed_lanes_set() function name or >> rename variable "speed_lanes_capa" name ? >> > > rename variable "speed_lanes_capa" name > Hi Damodharam, I was hoping to get this feature for -rc2, as outstanding comments are not very big, if it can be possible to get new version in next few days we can proceed with it for this release, otherwise can wait for next release. Btw, other issue is testing this new feature, as it is not supported by many vendors, I expect this test case not included in many test plans. And because of the HW dependency adding unit test won't be sufficient. At least for the short term, can we rely Broadcom and Huawei to test it with the first version this feature is merged? And I am not sure about what can be the long term solution, any suggestion is welcome. My concern is as number of this kind of features are increasing, dpdk is becoming more fragile.