From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DE9C85689 for ; Mon, 21 Aug 2017 13:16:08 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2017 04:16:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,409,1498546800"; d="scan'208";a="302598843" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga004.fm.intel.com with ESMTP; 21 Aug 2017 04:16:06 -0700 To: Jiayu Hu , dev@dpdk.org Cc: konstantin.ananyev@intel.com, jianfeng.tan@intel.com, thomas@monjalon.net, jingjing.wu@intel.com, lei.a.yao@intel.com References: <1502333448-75976-1-git-send-email-jiayu.hu@intel.com> <1502960892-112960-1-git-send-email-jiayu.hu@intel.com> <1502960892-112960-2-git-send-email-jiayu.hu@intel.com> From: Ferruh Yigit Message-ID: <983b0256-5839-fa53-2d4b-d5b9e0e04b98@intel.com> Date: Mon, 21 Aug 2017 12:16:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1502960892-112960-2-git-send-email-jiayu.hu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 11:16:09 -0000 On 8/17/2017 10:08 AM, Jiayu Hu wrote: > The GRO library provides two reassembly modes: lightweight mode and > heavyweight mode. This patch is to support the heavyweight mode in > csum forwarding engine. > > With the command "set port gro (heavymode|lightmode) (on|off)", > users can select the lightweight mode or the heavyweight mode to use. With > the command "set gro flush interval ", users can set the interval of > flushing GROed packets from reassembly tables for the heavyweight mode. > With the command "show port gro", users can display GRO > configuration. > > Signed-off-by: Jiayu Hu <...> > + /* create a gro context for each lcore */ > + gro_param.gro_types = RTE_GRO_TCP_IPV4; > + gro_param.max_flow_num = GRO_MAX_FLUSH_INTERVAL; > + gro_param.max_item_per_flow = MAX_PKT_BURST; > + for (lc_id = 0; lc_id < nb_lcores; lc_id++) { > + gro_param.socket_id = rte_lcore_to_socket_id( > + fwd_lcores_cpuids[lc_id]); > + fwd_lcores[lc_id]->gro_ctx = rte_gro_ctx_create(&gro_param); The gro library .map file has wrong function name "rte_gro_ctrl_create" instead of "rte_gro_ctx_create". So this is giving a build error with shared library config. Both "rte_gro_ctrl_create" and "rte_gro_ctrl_destroy" need to be fixed. > + if (fwd_lcores[lc_id]->gro_ctx == NULL) { > + rte_exit(EXIT_FAILURE, > + "rte_gro_ctx_create() failed\n"); > + } > + } > } <...>