From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A1E0A0526; Tue, 10 Nov 2020 14:04:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81BC02B93; Tue, 10 Nov 2020 14:04:28 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 79548F64 for ; Tue, 10 Nov 2020 14:04:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 3CBB6D71; Tue, 10 Nov 2020 08:04:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 10 Nov 2020 08:04:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= dQZMuORrtpGeoIMsh63blCLB+ND9krB6ZTjHelObFBQ=; b=XkeF60mLe3PvWvQX kXNv9/bPoQDKc+hN11GQjHGXoyG5mfbWnArWD8iXhDSd2ehIJTOytZbrKSpONp8A G4QNLrVuOTgO7xLxnBmYDVkknxDrpWGePsygFwK4lSEvLHP/pFM3Ys3qSRmNSD/l CC7+L1uIYz78nzS769Q7UtDwm6MUJImclcgKWM4CbwjiGIhVylutUyISl9JR+h9k rg8FICUXrcjtDpto9IRvMY0mtpuHxBDtn1JgDMyVkyrYWxeEfZT077rO2vQdd7N6 YYwQX5ue2ExYEM53V2DK+2UD96wpIp3hivLpLjca21mRfS490NNcnb/l/sfuJa7H sRIapQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dQZMuORrtpGeoIMsh63blCLB+ND9krB6ZTjHelObF BQ=; b=Ld3NeKcPUyeNHU145JJEm+pSIbg3pkZjw1gpm5j68wmOrlrwE+sLMvsw7 gQ3lFcmG0bfbfgk1qpVMgwUiXklHn/dH6ivrwynfHhSC26yrWZRuHBDcyaGPoYgm 7m9tSZ/DvreJ98gM7pj5zwCP9NwA+vc3hFlfHlW7KrPeTBlz9BuhyEE/DPHHak9k r+S+10pFuQ4A0XErHrs6iVI+uIDAo0Ro/nV7GnbLyuzL6UvX94FO/evFc1AytETV bnjsCMSDMGaHabSM8UM6q6UNlTSsqmQ+zDdhzj4pbTFi62oc/dLXs4xsRFa0uMSb 6CGmNlhy+id6NMin7HqCoEMpbT6SA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddujedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 010DE3280065; Tue, 10 Nov 2020 08:04:23 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Tue, 10 Nov 2020 14:04:21 +0100 Message-ID: <9843499.ZJUyaPxYeA@thomas> In-Reply-To: <20201110113435.GF1641@bricha3-MOBL.ger.corp.intel.com> References: <20201027173836.891184-1-bruce.richardson@intel.com> <2594616.PNtlxbl9Qa@thomas> <20201110113435.GF1641@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/11/2020 12:34, Bruce Richardson: > On Tue, Nov 10, 2020 at 12:25:13PM +0100, Thomas Monjalon wrote: > > 10/11/2020 11:08, Bruce Richardson: > > > On Mon, Nov 09, 2020 at 08:26:10PM +0100, Thomas Monjalon wrote: > > > > 09/11/2020 19:02, Bruce Richardson: > > > > > On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > > > > > > 27/10/2020 18:38, Bruce Richardson: > > > > > > > To test the installation process of DPDK using "ninja install" > > > > > > > test-meson-builds.sh builds a subset of the examples using "make". > > > > > > > To allow more flexibility for people testing, allow the set of > > > > > > > examples chosen for this make test to be overridden using variable > > > > > > > "DPDK_BUILD_TEST_EXAMPLES" in the environment. > > > > > > > > > > > > > > Since a number of example apps link against drivers directly even > > > > > > > for shared builds, we need to ensure that LD_LIBRARY_PATH points to > > > > > > > the main DPDK lib folder so any dependencies of those drivers can > > > > > > > be found e.g. that the PCI/vdev bus driver .so is found. [All > > > > > > > drivers are symlinked from drivers dir back to lib dir on install, > > > > > > > so only one dir rather than two is needed in the path.] > > > > > > [...] > > > > > > > +libdir=$(dirname $(find $DESTDIR -name librte_eal.so)) +export > > > > > > > LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH > > > > > > > > > > > > I don't get why libdir is required for some examples, and not for > > > > > > others? The pkg-config file is not enough? > > > > > > > > > > > > > > > > It's only needed for examples that link against drivers directly. > > > > > > > > > > I believe it's needed in those cases, because app linker flags > > > > > (including e.g. -lrte_pmd_bond) occur before the pkg-config flags, > > > > > which means that the linker at that point does not have the path to > > > > > find the dependencies of the driver. [In a normal build, this wouldn't > > > > > be necessary because the library directory would be a standard path] > > > > > > > > If it's just a matter of ordering, it would be a better example to fix > > > > the ordering in the Makefile, isn't it? > > > > > > > > > > I thought about that, but it seems strange to have the DPDK linker flags > > > appear before the application specific flags. The general style is to have > > > the apps own linker flags apply first, and then the list of dependencies, > > > so that any app linker flags take precedence. The other option is to have > > > two separate LDFLAG variables for the app, one for before pkg-config flags > > > and the other afterwards, but that is an untidy solution. > > > > > > Therefore, I think it's better to keep the ordering in the examples as-is > > > and just set the library path in the script. It's only a single extra > > > assignment that is necessary because we are installing to a non-standard > > > path using DESTDIR. > > > > It is OK to add LD_LIBRARY_PATH in test-meson-builds.sh because > > DPDK is "installed" with a DESTDIR prefix. > > > > But this change is unrelated to test more examples, > > it is a general fix for examples compilation. > > The thing I'm missing, as I said above, > > "why libdir is required for some examples, and not for others?" > > I feel something wrong made linking work where it should not. > > > > As I explained above, libdir is required for examples that link directly > against DPDK drivers in shared builds. There are only a few examples that > do so, which is why the majority worked fine, and why this was not needed > before. Sorry I don't understand how we link other libraries without LD_LIBRARY_PATH. Where the library path was taken from before this change?