Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 6/19/19 8:13 AM, Noa Ezra wrote:
> Rx mergeable buffers is a virtio feature that allows chaining of
> multiple virtio descriptors to handle large packet size.
> This behavior is supported and enabled by default, however in case
> the user knows that rx mergeable buffers are not needed, he can disable
> the feature.
> The user should also set mrg_rxbuf=off in virtual machine's xml.
> 
> Signed-off-by: Noa Ezra <noae@mellanox.com>
> Reviewed-by: Matan Azrad <matan@mellanox.com>
> ---
>  doc/guides/nics/vhost.rst         |  5 +++++
>  drivers/net/vhost/rte_eth_vhost.c | 17 ++++++++++++++++-
>  2 files changed, 21 insertions(+), 1 deletion(-)
> 

As stated earlier, I will not apply this patch because feature disabling
should be done at Vhost-user master side.

The exception are for features that require specific support from the
application, such as TSO or postcopy.

Regards,
Maxime