Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

["Wiles, Keith" <keith.wiles@intel.com>]

I agree using register for todays compilers is unnecessary and can actually be wrong in some cases. The compilers can pick the correct registers better then we can normally and restricting the compiler makes no sense. 

Sent from my iPhone

> On Jan 31, 2019, at 3:11 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
>> On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote:
>> Hi all,
>> 
>> Has there been any change regarding this? I'm still at DPDK 18.11. Maybe
>> automatically add -Wno-register when C++17 is enabled? Or have a some
>> register macro which gets undefined if C++17 is enabled?
>> 
>> The "warning: ISO C++1z does not allow ‘register’ storage class specifier"
>> is annoying. And vim always goes to some DPDK header when ":make" fails
>> because of the warning...
>> 
>> Thanks,
>> Tom
>> 
> What header is that? From what I see the patchset only makes changes to .c
> files rather than any .h files, so not sure it would help in your case.
> 
> For what it's worth on the general discussion, I'm in favour of applying
> this patchset. I view marking variables as "register" as completely
> unncessary. If someone can demonstrate a place where it actually makes a
> difference, then we can keep that use of the keywork, otherwise I think the
> code is as well off without it.
> 
> /Bruce