From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E6F42A0540;
	Fri,  8 Jul 2022 11:11:37 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 89E9A40A7B;
	Fri,  8 Jul 2022 11:11:37 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mails.dpdk.org (Postfix) with ESMTP id F3CB7406B4
 for <dev@dpdk.org>; Fri,  8 Jul 2022 11:11:35 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1657271495;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=7jy3IrAETds2ZvkZu4AC8saY737KR2LGj75Grl+QApI=;
 b=CuxeLvXA9L7L2kO36/s8+L4YL73fAiSlPSWl4xmnQrOwRXTe3Qb3ANpVgA3y6Xpzof/zAj
 wjUInE61Nd67gSMCuxKhHF2WwOU/Man+qIaLyCMRNDi4cmkumyz61oMYFXRA6WflD8uwFn
 NyIqhkPR39e+y1NmO+wesGn7My292eo=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-219-QBM0Ukc3MJO4n1Hf4EWrRA-1; Fri, 08 Jul 2022 05:11:24 -0400
X-MC-Unique: QBM0Ukc3MJO4n1Hf4EWrRA-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com
 [10.11.54.8])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2218F801231;
 Fri,  8 Jul 2022 09:11:24 +0000 (UTC)
Received: from [10.39.208.8] (unknown [10.39.208.8])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 404FAC15D40;
 Fri,  8 Jul 2022 09:11:23 +0000 (UTC)
Message-ID: <9852c8d7-aa27-f569-09a2-8039f310c0d3@redhat.com>
Date: Fri, 8 Jul 2022 11:11:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] vdpa/ifc/base: fix null pointer dereference
To: Andy Pei <andy.pei@intel.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com, xiao.w.wang@intel.com
References: <1657259861-75138-1-git-send-email-andy.pei@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
In-Reply-To: <1657259861-75138-1-git-send-email-andy.pei@intel.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



On 7/8/22 07:57, Andy Pei wrote:
> Fix null pointer dereference reported in coverity scan.
> Output some log information when lm_cfg is null.
> Make lm_cfg is not null before operate on lm_cfg.
> 
> Coverity issue: 378882
> Fixes: d7fe5a2861e7 ("net/ifc: support live migration")
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>   drivers/vdpa/ifc/base/ifcvf.c       | 31 ++++++++++++++++++++-----------
>   drivers/vdpa/ifc/base/ifcvf_osdep.h |  1 +
>   2 files changed, 21 insertions(+), 11 deletions(-)
> 

Applied to dpdk-next-virtio/main.

Thanks,
Maxime