From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform
Date: Thu, 11 Dec 2014 22:21:44 +0100 [thread overview]
Message-ID: <9863237.MyFdkOxhYo@xps13> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9EEB1@SHSMSX101.ccr.corp.intel.com>
2014-12-11 15:28, Qiu, Michael:
> On 2014/12/11 21:26, Neil Horman wrote:
> > On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote:
> >>> These two issues are both introuduced by commit b77b5639:
> >>> mem: add huge page sizes for IBM Power
> >>>
> >>> Michael Qiu (2):
> >>> Fix compile issue with hugepage_sz in 32-bit system
> >>> Fix compile issue of eal with icc compile
> >> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >>
> >> Applied
> >>
> >> Thanks
> >>
> > Wait, why did you apply this patch? We had outstanding debate on it, and
> > Michael indicated he was testing a new version of the patch.
>
> Yes, I test the solution you suggest :) and it mostly works, but with a
> little issue.
> I have re-post not the old version.
Neil, v4 is a new version implementing what you suggested.
There was no comment and it looks good so I applied it.
> Do you take a look at?
I think Neil missed the v4. Sorry to not have pinged you, I wanted rc4 for
validation at this time.
Neil do you agree this version is OK or do you see some issue to fix?
--
Thomas
next prev parent reply other threads:[~2014-12-11 21:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1417329845-7482-1-git-send-email-michael.qiu@intel.com>
[not found] ` <1417594223-2573-1-git-send-email-michael.qiu@intel.com>
2014-12-03 11:32 ` [dpdk-dev] [PATCH v2] " Qiu, Michael
2014-12-03 15:40 ` Bruce Richardson
2014-12-04 2:49 ` Qiu, Michael
2014-12-04 9:03 ` Thomas Monjalon
2014-12-04 10:21 ` Qiu, Michael
2014-12-04 9:12 ` [dpdk-dev] [PATCH v3] " Michael Qiu
2014-12-05 6:56 ` Qiu, Michael
2014-12-05 7:04 ` Chao Zhu
2014-12-05 8:31 ` Chao Zhu
2014-12-05 14:22 ` Neil Horman
2014-12-05 15:02 ` Bruce Richardson
2014-12-05 15:24 ` Neil Horman
2014-12-08 2:46 ` Qiu, Michael
2014-12-08 2:59 ` Neil Horman
2014-12-08 3:37 ` Qiu, Michael
2014-12-08 4:57 ` Qiu, Michael
2014-12-08 11:37 ` Neil Horman
2014-12-08 11:50 ` Thomas Monjalon
2014-12-08 14:59 ` Qiu, Michael
2014-12-10 10:46 ` [dpdk-dev] [PATCH 0/2 v4] " Michael Qiu
2014-12-10 10:46 ` [dpdk-dev] [PATCH 1/2 v4] Fix compile issue with hugepage_sz in 32-bit system Michael Qiu
2014-12-10 10:46 ` [dpdk-dev] [PATCH 2/2] Fix compile issue of eal with icc compile Michael Qiu
2014-12-11 0:56 ` [dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform Thomas Monjalon
2014-12-11 13:25 ` Neil Horman
2014-12-11 15:28 ` Qiu, Michael
2014-12-11 21:21 ` Thomas Monjalon [this message]
2014-12-12 11:38 ` Neil Horman
2014-12-12 15:09 ` Thomas Monjalon
2014-12-12 15:29 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9863237.MyFdkOxhYo@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).