From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 73B686A95 for ; Thu, 11 Dec 2014 22:22:13 +0100 (CET) Received: by mail-wi0-f170.google.com with SMTP id bs8so2773435wib.3 for ; Thu, 11 Dec 2014 13:22:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=t43VCpUZRpvPoxmZkXGO81xOaD3A2hP/QybzkHFcdmM=; b=VmAjyfs9YA9xI1Q/9YrOFicmaEBlQuHQlwXlOo5WtB/VfqaF7C1pHLqiwTLrBdtXlX S2oMPgLnYliATcD0VPN/ihTJJdamMmbkRbW31mCfkY+ZywVW8zGfM/bi6n/HJ6LKmonS KM55crnGdKdKSBAK4fhl+rbP5pqazL6QUEtDfcl3Thy57C0FAo6GFHTsL7GKA3LpEGi/ v94ftk/FicHun0S/wB1FmWjibHmO5HPzCvEdqtthRZBnbQu7MV1A5trIaG4tqm/Qjh+N lhRMNrB6QaA3woI3GfPV99bivP5fq+xzIsMuORgCDqg0eRaRBMz9Dx9cDXdF+wKe6+jk wITA== X-Gm-Message-State: ALoCoQlywOm/7v41q+t6zq2oBiT8vzuWlnfIBL6Lv6eM/uqJdrrQigGiM7/Lh0k6kdgHcDNXouEd X-Received: by 10.180.90.147 with SMTP id bw19mr1433480wib.69.1418332933342; Thu, 11 Dec 2014 13:22:13 -0800 (PST) Received: from xps13.localnet ([88.249.222.12]) by mx.google.com with ESMTPSA id ep9sm716706wid.3.2014.12.11.13.22.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 11 Dec 2014 13:22:12 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Thu, 11 Dec 2014 22:21:44 +0100 Message-ID: <9863237.MyFdkOxhYo@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9EEB1@SHSMSX101.ccr.corp.intel.com> References: <1417684369-21330-1-git-send-email-michael.qiu@intel.com> <20141211132506.GA28213@hmsreliant.think-freely.org> <533710CFB86FA344BFBF2D6802E60286C9EEB1@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 21:22:13 -0000 2014-12-11 15:28, Qiu, Michael: > On 2014/12/11 21:26, Neil Horman wrote: > > On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote: > >>> These two issues are both introuduced by commit b77b5639: > >>> mem: add huge page sizes for IBM Power > >>> > >>> Michael Qiu (2): > >>> Fix compile issue with hugepage_sz in 32-bit system > >>> Fix compile issue of eal with icc compile > >> Acked-by: Thomas Monjalon > >> > >> Applied > >> > >> Thanks > >> > > Wait, why did you apply this patch? We had outstanding debate on it, and > > Michael indicated he was testing a new version of the patch. > > Yes, I test the solution you suggest :) and it mostly works, but with a > little issue. > I have re-post not the old version. Neil, v4 is a new version implementing what you suggested. There was no comment and it looks good so I applied it. > Do you take a look at? I think Neil missed the v4. Sorry to not have pinged you, I wanted rc4 for validation at this time. Neil do you agree this version is OK or do you see some issue to fix? -- Thomas