From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7501A058A; Fri, 17 Apr 2020 16:18:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 477E01E8D0; Fri, 17 Apr 2020 16:18:58 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 24FB31DCF1 for ; Fri, 17 Apr 2020 16:18:55 +0200 (CEST) IronPort-SDR: 3+BAQrBkuxXQ1Z8Rcmi7drmSHMJW3sfxUVNeRTFnT2y74s7UPKIMQe320nvjHrw9AubegDL6SN wRjZjgEcxZpA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 07:18:50 -0700 IronPort-SDR: FAK25QywC44WmJoOGLUrqCdkwjGjapejSylZm2N2cDv6gHtB3ZcVWdhWbXDeDyGrCf3knd60VI lRauTSaqijng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,395,1580803200"; d="scan'208";a="278391630" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.209.17]) ([10.213.209.17]) by fmsmga004.fm.intel.com with ESMTP; 17 Apr 2020 07:18:47 -0700 To: Xiaojun Liu , xiao.w.wang@intel.com, qi.z.zhang@intel.com, ngai-mint.kwan@intel.com, jacob.e.keller@intel.com Cc: dev@dpdk.org References: <1584687199-19198-1-git-send-email-xiaojun.liu@silicom.co.il> <1586413588-5759-1-git-send-email-xiaojun.liu@silicom.co.il> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <9867e3b7-01a7-21e8-3060-8997d38ee61c@intel.com> Date: Fri, 17 Apr 2020 15:18:46 +0100 MIME-Version: 1.0 In-Reply-To: <1586413588-5759-1-git-send-email-xiaojun.liu@silicom.co.il> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/9/2020 7:26 AM, Xiaojun Liu wrote: > V4: > * Add I2C to control the inside LED and PHY. > * Add SBUS to communicate with spico. > * Add registers defination. > * Add switch management log API. > * Add switch management structures. > * Add epl serdes include loading spico, > controlling pcsl, dma, dfe, ical. > * Add spico code. > * Add state machine for epl lane and port. > * Add external port management. > * Add ffu to support offload flow into HW. > It supports forward, mirror, push VLAN, pop VLAN. > * Add config file to configure debug log, port speed, > epl port mapping dpdk port, flowset. > * Add statistics includes epl port, ffu rule, dpdk port. > * Add flow interface to support offload flow into HW. > * Add switch management, includes initialization, > port mapping, epl port link, LED controller, interrupt handler. > * Split dev_init to 2 parts in ethdev. First only register > the port in switch management; second init hook will be > called after all the pf are registered. > * Add switch interrupt support. > * Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset. > * Add fm10k_dev_filter_ctrl to support flow operation. > * Add dpdk port and pf mapping. > * Modify Makefile to add new files building > > Xiaojun Liu (5): > net/fm10k: add basic functions for switch management > net/fm10k: add epl serdes and port control functions > net/fm10k: add ffu and statistics and config file functions > net/fm10k: add flow interface and switch management > net/fm10k: add switch management support > With 'CONFIG_RTE_FM10K_SWITCH_MANAGEMENT=y' I am getting following build errors, can you please check them? 1) T=ppc_64-power8-linuxapp-gcc .../drivers/net/fm10k/switch/fm10k_stats.c:758:26: error: ‘ts.tv_sec’ is used uninitialized in this function [-Werror=uninitialized] counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec; ~~^~~~~~~ .../drivers/net/fm10k/switch/fm10k_stats.c:758:48: error: ‘ts.tv_usec’ is used uninitialized in this function [-Werror=uninitialized] counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec; ~~^~~~~~~~ 2) T=arm64-armv8a-linuxapp-gcc .../drivers/net/fm10k/switch/../base/fm10k_osdep.h:49:20: error: conflicting types for ‘u64’... #define __le64 u64... ^~~... .../drivers/net/fm10k/switch/../base/fm10k_osdep.h:44:20: note: previous declaration of ‘u64’ was here... typedef uint64_t u64;... ^~~... 3) T=x86_64-native-linuxapp-clang .../drivers/net/fm10k/switch/fm10k_ffu.c:821:6: error: variable 'tcam_slice' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (sglort_vid_tcam) { ^~~~~~~~~~~~~~~ .../drivers/net/fm10k/switch/fm10k_ffu.c:838:32: note: uninitialized use occurs here fm10k_ffu_always_mismatch(sw, tcam_slice + 1, rule_id); ^~~~~~~~~~ .../drivers/net/fm10k/switch/fm10k_ffu.c:821:2: note: remove the 'if' if its condition is always true if (sglort_vid_tcam) { ^~~~~~~~~~~~~~~~~~~~~ .../drivers/net/fm10k/switch/fm10k_ffu.c:775:35: note: initialize the variable 'tcam_slice' to silence this warning uint16_t sram_idx = 0, tcam_slice, sram_slice, i; ^ = 0 .../drivers/net/fm10k/switch/fm10k_ffu.c:906:6: error: variable 'tcam_slice' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (sglort_vid_tcam) { ^~~~~~~~~~~~~~~ .../drivers/net/fm10k/switch/fm10k_ffu.c:923:32: note: uninitialized use occurs here fm10k_ffu_always_mismatch(sw, tcam_slice + 1, rule_id); ^~~~~~~~~~ .../drivers/net/fm10k/switch/fm10k_ffu.c:906:2: note: remove the 'if' if its condition is always true if (sglort_vid_tcam) { ^~~~~~~~~~~~~~~~~~~~~ .../drivers/net/fm10k/switch/fm10k_ffu.c:869:35: note: initialize the variable 'tcam_slice' to silence this warning uint16_t sram_idx = 0, tcam_slice, sram_slice, i; ^ = 0 .../drivers/net/fm10k/switch/fm10k_serdes.c:1922:9: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value] diff = abs(val2 - val1); ^ .../drivers/net/fm10k/switch/fm10k_serdes.c:1922:9: note: remove the call to 'abs' since unsigned values cannot be negative diff = abs(val2 - val1); ^~~ 4) T=x86_64-native-linuxapp-gcc .../drivers/net/fm10k/switch/fm10k_serdes.c: In function ‘fm10k_epl_serdes_get_ical_result’: .../drivers/net/fm10k/switch/fm10k_serdes.c:1922:9: error: taking the absolute value of unsigned type ‘uint32_t’ {aka ‘unsigned int’} has no effect [-Werror=absolute-value] 1922 | diff = abs(val2 - val1); | ^~~ cc1: all warnings being treated as errors make[7]: *** [.../mk/internal/rte.compile-pre.mk:114: fm10k_serdes.o] Error 1 make[7]: *** Waiting for unfinished jobs.... .../drivers/net/fm10k/switch/fm10k_stats.c: In function ‘fm10k_get_port_counters’: .../drivers/net/fm10k/switch/fm10k_stats.c:758:26: error: ‘ts.tv_sec’ is used uninitialized in this function [-Werror=uninitialized] 758 | counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec; | ~~^~~~~~~ .../drivers/net/fm10k/switch/fm10k_stats.c:758:48: error: ‘ts.tv_usec’ is used uninitialized in this function [-Werror=uninitialized] 758 | counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec; | ~~^~~~~~~~ cc1: all warnings being treated as errors