From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>,
Igor Russkikh <Igor.Russkikh@aquantia.com>
Subject: [dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes
Date: Tue, 12 Mar 2019 15:24:55 +0000 [thread overview]
Message-ID: <9878dd7a3e0652025e6cdb4c9e2b6e889e2e33e9.1552402263.git.igor.russkikh@aquantia.com> (raw)
In-Reply-To: <cover.1552402263.git.igor.russkikh@aquantia.com>
Found by Coverity scan. Checks are useless
because at these code places err is always zero.
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
---
drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
index f11093a50404..13f02b9f99c5 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
@@ -462,8 +462,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
goto err_exit;
}
} while (sw.tid != fw.tid || 0xFFFFU == fw.len);
- if (err < 0)
- goto err_exit;
if (rpc) {
if (fw.len) {
@@ -875,8 +873,7 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac)
}
err = hw_atl_utils_fw_rpc_call(self, rpc_size);
- if (err < 0)
- goto err_exit;
+
err_exit:
return err;
}
--
2.17.1
next prev parent reply other threads:[~2019-03-12 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 15:24 [dpdk-dev] [PATCH v3 00/11] net/atlantic: bugfixes and code cleanup Igor Russkikh
2019-03-12 15:24 ` [dpdk-dev] [PATCH v3 01/10] net/atlantic: fix negative error codes Igor Russkikh
2019-03-12 15:24 ` [dpdk-dev] [PATCH v3 02/10] net/atlantic: remove unused variable Igor Russkikh
2019-03-12 15:24 ` Igor Russkikh [this message]
2019-03-20 13:24 ` [dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes Ferruh Yigit
2019-03-20 13:24 ` Ferruh Yigit
2019-03-20 14:04 ` Igor Russkikh
2019-03-20 14:04 ` Igor Russkikh
2019-03-12 15:24 ` [dpdk-dev] [PATCH v3 04/10] net/atlantic: fix buffer overflow Igor Russkikh
2019-03-12 15:24 ` [dpdk-dev] [PATCH v3 05/10] net/atlantic: use EEPROM magic as a device address Igor Russkikh
2019-03-12 15:25 ` [dpdk-dev] [PATCH v3 06/10] net/atlantic: fix EEPROM get for small and uneven lengths Igor Russkikh
2019-03-12 15:25 ` [dpdk-dev] [PATCH v3 07/10] net/atlantic: fix link configuration Igor Russkikh
2019-03-12 15:25 ` [dpdk-dev] [PATCH v3 08/10] net/atlantic: eliminate excessive log levels on Rx/Tx Igor Russkikh
2019-03-12 15:25 ` [dpdk-dev] [PATCH v3 09/10] net/atlantic: fix missing VLAN filter offload Igor Russkikh
2019-03-12 20:03 ` Rami Rosen
2019-03-12 15:25 ` [dpdk-dev] [PATCH v3 10/10] net/atlantic: fix xstats to return correct number of items Igor Russkikh
2019-03-20 13:24 ` [dpdk-dev] [PATCH v3 00/11] net/atlantic: bugfixes and code cleanup Ferruh Yigit
2019-03-20 13:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9878dd7a3e0652025e6cdb4c9e2b6e889e2e33e9.1552402263.git.igor.russkikh@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).