From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michalx.kobylinski@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 2C9E76CD6
 for <dev@dpdk.org>; Wed,  2 Mar 2016 17:23:32 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga103.fm.intel.com with ESMTP; 02 Mar 2016 08:23:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,529,1449561600"; d="scan'208";a="58463292"
Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96])
 by fmsmga004.fm.intel.com with ESMTP; 02 Mar 2016 08:23:13 -0800
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by
 IRSMSX154.ger.corp.intel.com ([169.254.12.174]) with mapi id 14.03.0248.002;
 Wed, 2 Mar 2016 16:23:12 +0000
From: "Kobylinski, MichalX" <michalx.kobylinski@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add
 config structure
Thread-Index: AQHRWpAhsiGL1b5R7UOCLOPFdkQ/s59Ge1iAgAAIrRA=
Date: Wed, 2 Mar 2016 16:23:12 +0000
Message-ID: <987EE72691933347B9F0B5C19E71B5BB1F04159F@IRSMSX101.ger.corp.intel.com>
References: <1454069573-12059-1-git-send-email-michalx.kobylinski@intel.com>
 <1454069573-12059-2-git-send-email-michalx.kobylinski@intel.com>
 <2044358.OMRF2VQKlE@xps13>
In-Reply-To: <2044358.OMRF2VQKlE@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add
 config structure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2016 16:23:32 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, March 2, 2016 4:29 PM
> To: Kobylinski, MichalX <michalx.kobylinski@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add c=
onfig
> structure
> Importance: High
>=20
> Hi,

Hi Thomas,
thank you for suggested.
>=20
> As suggested by Bruce, I'm looking to apply this patchset before the ARM =
one.
> Please check the comments below.
>=20
> Is it possible to split the changes in next_hop and config structure?

It is possible. Do you mean to put config structure into seperate patch-set=
?
> > --- a/doc/guides/rel_notes/release_2_3.rst
> > +++ b/doc/guides/rel_notes/release_2_3.rst
> > @@ -18,7 +18,11 @@ Drivers
> >
> >  Libraries
> >  ~~~~~~~~~
> > +** librte_lpm: Increase number of next hops for IPv4 to 2^24 **
> >
> > +Extend next_hop field from 8-bits to 24-bits for IPv4. Changed structu=
res:
> > +rte_lpm_tbl24_entry and rte_lpm_tbl8_entry to one structure
> rte_lpm_tbl_entry.
> > +Added a new rte_lpm_config structure.
>=20
> The spacing is wrong here. Please check also the past tense.
> There is a template in the release notes.
>=20
> > +BIND_DEFAULT_SYMBOL(rte_lpm_add, _v23, 2.3); MAP_STATIC_SYMBOL(
> > +		int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
> > +				uint32_t next_hop), rte_lpm_add_v23);
>=20
> The version will be 16.04 instead of 2.3.