From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michalx.kobylinski@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 1E1202C5A
 for <dev@dpdk.org>; Tue, 28 Jun 2016 10:40:18 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 28 Jun 2016 01:40:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,540,1459839600"; d="scan'208";a="996421469"
Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28])
 by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2016 01:40:17 -0700
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.155]) by
 irsmsx105.ger.corp.intel.com ([169.254.7.51]) with mapi id 14.03.0248.002;
 Tue, 28 Jun 2016 09:40:16 +0100
From: "Kobylinski, MichalX" <michalx.kobylinski@intel.com>
To: "david.marchand@6wind.com" <david.marchand@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: Ignoring number of bytes read in eal
Thread-Index: AdHRGLEKATHQd6KyQqOeLi/BM/U9Yw==
Date: Tue, 28 Jun 2016 08:40:16 +0000
Message-ID: <987EE72691933347B9F0B5C19E71B5BB1F0A9974@IRSMSX101.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: [dpdk-dev] Ignoring number of bytes read in eal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2016 08:40:19 -0000

Hi David,

I'm working on issue reported by Coverity.

CID 13212 - Ignoring number of bytes read:
The number of bytes copied into the buffer can be smaller than the requeste=
d number and the buffer can potentially be accessed out of range.
In rte_mem_virt2phy: Value returned from a function and indicating the numb=
er of bytes read is ignored.

File: /lib/librte_eal/linuxapp/eal/eal_memory.c
Line: 187

Can I mark this error as "False Positive"?

Because return from read function is checked in "if" condition. If return f=
rom read is less than 0 function rte_mem_virt2phy is aborted and return: lo=
g message, RTE_BAD_PHYS_ADDR.

What's your opinion?

Regards,
Michal