From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C63AB425D1; Mon, 18 Sep 2023 14:36:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78CA44067A; Mon, 18 Sep 2023 14:36:37 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) by mails.dpdk.org (Postfix) with ESMTP id 88DDF402DE for ; Mon, 18 Sep 2023 14:36:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFqousCfF1uUHLR1ajorFiC4kkQ+5TfqvdmHBGRovDbRSuuw+Lf9ZlTT+zm+yW9ONWFQ53sEQEdvKOn6ijyVJlVe8B6ynEW/zzRCgWm2NNETYCqR3ksT86oTJjrt0PQbUwEOEMcK9JS+l8uZndZq+Z6RdwryF9QOyEXqWTBxLIpdo79DVQMiFaPtLVazXRzWhzzRbbJ3kuNZ2JHQfQLwVrXJ+dOBgR4QIKiAHpnKWVL2t0qwkgh3CcURZuSLXZ0Ea4RjigvGMDKEz1KCLXIXBgYsFlROI29MIdw7WlbK1QH5+UwJ+FPwd6vzfIZYb+08mH0o1sH0JdgiKFScxC1tSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTOLK8BNyhttbHF4+monbLuwWiOxSq5ApppYGVIftG8=; b=CfYKELQt27I9FITlJUYCyyznyphMG4EgOPAehmZTCu49AZZWDNAtqU4VmrrqJ7iWBjKfFCznYO5vXjacclvCDDny2+aGIrJVsyaLxAVipyCA7Fo8LB4QpPxkambbVwzbD4Arf7LdtazhSzjaH94tc508773Po3AOnGBwFd5ZVN0QEBi93bjaOXEKlyK63MDOWgQcTHVNmjOFnP66SCRxhHMSIVvJDupKCnF0Vrty7ZaKUwov3gYYTkAj67NTYWf8tJttUx3e0c/Pxa0SYl6xYo0EIm7K90yw3zpB+ZGFW6Cw2o4d5xXIXLuoW6CbTE2ohSEaFE6VJwdISLRVaT8kOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dTOLK8BNyhttbHF4+monbLuwWiOxSq5ApppYGVIftG8=; b=VD9bikJiHD8j9grgkW6lRt5XsiKkV+iA5A+cypNgknKb7jI8ChLgZ8I6OiyqZ7VLwq4Um1OD2fiRwDCEB6+bNIgAsSiHxSij2QbySj1+10X9Jl8aYDlVqvVD0JakRePRHvjM8lH6/AXF9HWTfJ6BBvJHoWIXmSQYt1C4ffhhgy8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB7815.namprd12.prod.outlook.com (2603:10b6:510:28a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep 2023 12:36:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 12:36:34 +0000 Message-ID: <987d9cc2-9a47-47be-bb63-97037f8b5a2c@amd.com> Date: Mon, 18 Sep 2023 13:36:27 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/27] net/nfp: refact the nsp module Content-Language: en-US From: Ferruh Yigit To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, =?UTF-8?Q?Niklas_S=C3=B6derlund?= References: <20230830021457.2064750-1-chaoyong.he@corigine.com> <20230915091551.1459606-1-chaoyong.he@corigine.com> <20230915091551.1459606-20-chaoyong.he@corigine.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0253.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB7815:EE_ X-MS-Office365-Filtering-Correlation-Id: f893e9ae-33ba-44fe-b755-08dbb843e46a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NjLzaCsjplXXbuAdU+toR+uBqB0xbIil0r+Z03okB5jDo/e1dCgy/CxPX+OsBObftPU5usLZ9VzmWKAffAnx6zTZsCTQCn48mfc+UVs1oWEwctrv8dHNxfghhCwk7hjFHE+8gUZJEXZEM4TQvpYfKK4Wko4TX32wf5DV1RsTyzwoL/E6NfV1mlwyixgHGaFnBNjj1ckfpjuzV5oo0HRBWLKxuHyPN+a6mjTFrH5RWxhHdMnzi7eDDRvdMU99WGY7gOTmcWCA5ScIduDiDSW/HZ3wfgXscjpNumN872kh+0wBdPerYXsYC9sKijIQnEXX9cS5fIrnaDf4BRUjrnnKQEhgzMaUpLc9cH3lolxhnZCfg2tRdKlW/OTOo3Yrr9Bh5SFIOsPSHGQdMmGv7SnQwOKNuTRWYbpLEp25SltleZGmzQr4jdplFO5OsTH8SRDe4m6UYqE2wh2TNS0/Qwv2KEQyD0kyoXjVYZUTRfOkoDsNgKADyB8LI1il58iUl3z2gNMXZszN9zvy5WkOg9jxAcGQQ/dOo5PWyox2BGkjOhBWIKsYtLimr7rJ9rUwmYsN0RZ6NrjFZ/NJiH+vXJ6k/Xwzz07HABTjmqGRPgTn0JSLPEaMKsFLS/kkeKWyeDmU9o+9x8egqeUEwM/Ce9bH2Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(366004)(396003)(39860400002)(346002)(1800799009)(451199024)(186009)(66946007)(66476007)(66574015)(316002)(8676002)(4326008)(8936002)(41300700001)(53546011)(6506007)(6486002)(6512007)(6666004)(478600001)(83380400001)(2616005)(26005)(31696002)(86362001)(2906002)(44832011)(38100700002)(5660300002)(36756003)(66556008)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHA3WmY5MDVQMTdBTjhsZHFRdy9hYVpFQzd4Q05ySWYwQWZZWVlMOWhYdVlu?= =?utf-8?B?elNyOGlxN3dEbmlrYjNDaGdwTWw2a2w4VDlpL21scmtPZGRXKytSUVRoc05S?= =?utf-8?B?V2hKSDJiNjdPang5djdtUVBRcEZEb0pIcTNQOVhKWFJNOXY5cGRwaHg5RStq?= =?utf-8?B?L0NZaW5tdmpobURrTzBYMm9MQjZxRnhqcWtxcUJ2d2tSUGhQek14ekRYRS9M?= =?utf-8?B?eXk3cjBDYk5YMEVPMnVDcEdhYlR3bGhYaGtoRmlCQy90VUNVNFlPMTh6UDhj?= =?utf-8?B?VEhBMUpRWGtEeWhRL0o0UWJERjUrOC9PTTRWS1FFOC85L0ltbTk0TlE5b1Jx?= =?utf-8?B?TVYyNzUyaGJiaWRJaHJGVmJFRTh4RXFNY1BtZUZRMnRXbk42a2h0U3EvMjRo?= =?utf-8?B?MHlQNGpXRWRHYll1NXI0Z0FtUVpRS2UvQ1hURE5HN2tkdG55WElBR1k5NWE1?= =?utf-8?B?RVRWRWpxY3pQZlVYV3YzSE8yVlQ5NVpZUUNMclBYekFkNzViVWlKMkhUUmVp?= =?utf-8?B?NWZTWjVUME9tZS9HZnA2aDRwWnN1eEdnL3FmTGlLd1NoR0ZhRE15Q1c4eFF2?= =?utf-8?B?UlVKTHRELzA5SVdDUTk5TmxjMEZBQVNwNzU2WHAvWUpiOGpKWnlKTDJleENI?= =?utf-8?B?dHVLTExVZ2FSZjVNQXJVbTE1U3k2ZWZBWWRVNjBYV05LUzRCdnBaaHFNNmVp?= =?utf-8?B?bzVUSkNRQXNzOStRUnhYc3pWRlF6dUoyR3NabHdRNHBqWTcrakFtcUw0OEty?= =?utf-8?B?WkJhQ2lQcFBPeGJPanNDUEJQUXIyT2g2QW5pNjJuWWZOTjJoKzdWenR0RWEr?= =?utf-8?B?SEdLeUxmVUY2cnRmdjdaN2l5WHpkOGhDRThnM0VtR3NmcENEUEhhdnJGYVFX?= =?utf-8?B?elZEWHFSWnZkb0NIQ01uK3Z4NXVSK0Q0bnJMV0NobnFUVy9id0tpZDVKUXJM?= =?utf-8?B?a05xVmFiVkp0WU96STJQdFcwS29sTXlWVFFEVzFxU3JoKzZQS1F6NUp6MGYy?= =?utf-8?B?am1kR1FuVkFyNDJNSjhxVlAwaWx5QmlQNERJRG5uY3k4VjRsSFRyYWo1SDIz?= =?utf-8?B?NlBSY3grRlJldjllQUdvblA3WXBBUUFDWnhRT1pkSjdST3NGY1lCcnpBL1VB?= =?utf-8?B?RDJUbHhDUTRZYVZZMkdQa3RhN2UzQUxVOTcwTmoyVTdibUlSdkMydFdBbmtC?= =?utf-8?B?aGJ3WW90YkVrTTJicXVrTzFiRitjV0lxeENnWVUzQmNhc0NKdCs4RTZlUGhj?= =?utf-8?B?b0V4VzhBY1diVmdMUWQ5UGVPM0pMQVFvNXVPYi9rUmxJVUVobGhiTXpwV2Ft?= =?utf-8?B?UE9XbVhlTEhobzVkbFVhalI4T2l6Y2xBRUxSYmZJbVUreko5UkxMaHdkVGlo?= =?utf-8?B?ajZPMU1YeHpkMkxLVjFZSStZZGhKek1NZVhScjQ3Rkl4YlR6ckNDTzA0TGJW?= =?utf-8?B?QzZhdytoWm5HNzlkZmQzaG1tUWpLeFMyQ0NwVUZUWUlHbzg5ZUdKTlZNS0dI?= =?utf-8?B?V2cyM0QyWWROcDRINGwxb29QYktweG1zdGg0eWNoL3hENDVCK0ltTUs5dDdS?= =?utf-8?B?QmhSOFJ5WjZOcTJ0OHRxMXdCdFEweU9ZSFgxcTV3WEw4MmlnV0M0cmNDYzZy?= =?utf-8?B?UWE4NlBxT000NWVOVzFvc3FmdmpzQnBYMDBnMTF1elgzZ1lWemlqZEtpTHJT?= =?utf-8?B?WGs0N0tRT3VKZEtVeGpRa0RFbWkydW4zWkdyYzJORWJ5bUc3TGFmY3NaNkxH?= =?utf-8?B?ZWZXbXlWUWh3NlNkYmVrZmQzZlNkQ21sOTVRV1NLYW92UUJEOGVtQm0zYzNr?= =?utf-8?B?cWhPYmxyT000bkZtTGluc1FLVEo4MkNlRFQzbDlFQk9GWVRiUnczSjMwYWxs?= =?utf-8?B?UVFVT05adGl5SE4wa3Q2RFpIRHV4N3dHbzNNdUZqSndNNHhtcENmWFR0MDk5?= =?utf-8?B?bCtCdGpGaTdXNHZETFhaOWlvRW9nc1dhelVSSWNXSGdlV1JtN1pWU3VoRldj?= =?utf-8?B?b0tzR1ZCZ2QwNS92WkJObG5pY04rNXZLcGhzbkFEdndrZUsxQU5icWZUQnF5?= =?utf-8?B?OXNUUzR6UXVYRW1KNkJZMEZLRDhzcFFQUGplRFFnb2JSNVFEVEtsNUZEMzdO?= =?utf-8?Q?RtuP+yy2Vw4tlAkEgE1Q4czS0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f893e9ae-33ba-44fe-b755-08dbb843e46a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 12:36:34.1592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0j9zBUuDbHasquskMcZMvRD70qfrOYQgxJn61JGRKiYXKjxp6KBRX+fgN2tRmtRL X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7815 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/18/2023 1:31 PM, Ferruh Yigit wrote: > On 9/15/2023 10:15 AM, Chaoyong He wrote: >> Move the definition of data structure into the implement file. >> Also sync the logic from kernel driver and remove the unneeded header >> file include statements. >> >> Signed-off-by: Chaoyong He >> Reviewed-by: Niklas Söderlund > > <...> > >> @@ -381,6 +478,43 @@ nfp_nsp_command_buf(struct nfp_nsp *nsp, >> return ret; >> } >> >> +#define SZ_1M 0x00100000 >> +#define SZ_4K 0x00001000 >> + >> +static int >> +nfp_nsp_command_buf(struct nfp_nsp *nsp, >> + struct nfp_nsp_command_buf_arg *arg) >> +{ >> + int err; >> + uint64_t reg; >> + uint32_t size; >> + uint32_t max_size; >> > > One of the previous patches, patch 3/27, updates variable type > 'unsigned int max_size;' -> 'size_t max_size;' > > Now it is updated again to 'uint32_t max_size;', I assume by mistake > that previous patch updated by this one didn't. > > If it is by mistake can you please check all patches that moves code, if > they are aligned with previous cleanups. > Or if this is intentional, can you please update the first patch to set > the variable correct at first place? > This comment is for v4, I replied to wrong version.