From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0070.outbound.protection.outlook.com [104.47.32.70]) by dpdk.org (Postfix) with ESMTP id 83A961B296 for ; Fri, 6 Oct 2017 11:11:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zq65b0IH3sRyhWYdkPy1yGzekO0y/C81+gX2mp/x88c=; b=myiuciSQlPb31K2UpWE5LMRfHt5vsfs4yBt79HtnRDzNIPv1kSKeCK9BLItCHM6gc1fp6onyj5cCpBOeP3BNibYDwFsYuAZwvVS7bsFGFcYwLP+PLX+503XzlcV/tK9Jfyc8yMWC2KE+13A7VvbqHaUdARAYIEaTtcWmb+ez0oc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [IPv6:2401:4900:1988:3cbd:a874:81a7:315f:de39] (2401:4900:1988:3cbd:a874:81a7:315f:de39) by DM5PR07MB3098.namprd07.prod.outlook.com (10.172.85.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 6 Oct 2017 09:11:40 +0000 To: Thomas Monjalon References: <20170918104234.9149-1-santosh.shukla@caviumnetworks.com> <1709089.zPNXRAn3Mx@xps> <7d5ca085-9b6d-83ca-6802-f855208f07ec@caviumnetworks.com> <9924204.vKznq0EaHZ@xps> Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, aconole@redhat.com, stephen@networkplumber.org, anatoly.burakov@intel.com, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, bruce.richardson@intel.com, sergio.gonzalez.monroy@intel.com, maxime.coquelin@redhat.com From: santosh Message-ID: <987f9703-017f-4e57-fe5d-8a5428ece301@caviumnetworks.com> Date: Fri, 6 Oct 2017 14:41:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <9924204.vKznq0EaHZ@xps> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [2401:4900:1988:3cbd:a874:81a7:315f:de39] X-ClientProxiedBy: DM5PR21CA0068.namprd21.prod.outlook.com (10.175.112.158) To DM5PR07MB3098.namprd07.prod.outlook.com (10.172.85.8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb6bcf52-e3ef-4944-b04d-08d50c9a447e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:DM5PR07MB3098; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 3:IKlmrTCNY/kNFhfr7qyhV2kW8ltpeXnSR+QijGpMdk/6HzRqP+RxTjFu15z3n0gxUPzdX8eZnluDJgN5ENtibNLJaOQbQlTHdnMIe3XN6aovNpeOMWxwqsgAARnURYvWBSVGZ8ih4j8K8UYw4hRecs/jChCa6Mo6jgHBGpM+exhYrL09PXapXbeN8p7LuPf30bEBqaWHYFouto8yoiWTzJ+thGI1f0EhZG5lfvT/tmL1Sld0eAb80ikc/CB45pYL; 25:4exO0vOroUl31mVdT9IZk01uOX18XwuyvFRc4qM737/CKqmECq/t7q3Amlzrm8j9iDduYzSgSsCp2cblC3RoZs/JDOWGDDzXxesF5FSr922FhWxGkXDycpguU6vWM0reRHlRR3Wi83z+xI4MG2LEuxMVhMFfHsiCMWZ4bx63J7lmwL1jvou9N+TaOAAcL5QI0bnROffNOIk7fHhVrs5E5qpomEomlJnTeI4EtvyW+OETI+qHuKp+hZcTgAfmJB7WvKI3E+y5wZ5PXhU/UFlPZzHTFoleiTYZ55p38xW5Y4MBjGtc2h8hqH4b42K2tJ7ML9YLswZCt4d9hC6cT8/BMQ==; 31:GlyE140vLaMGXqIBRBptUs05+oZcigHPo3w69sm/sBpF7auK6Ig62jQWEykCfBkZplQG45L54snXPlUcL4iaC3zkJy5YiJJf8Ilnov+0Sjp6TMHfCFGep4OgvkyCEdYK9yyB2D30y06veMW5vE53hd5eZUz3D2VyznoLS3alP5hwIqMLT0cJVv0DUxh2yLcHxlCYI+ghUlIN16CV1d0YwTqYnk7KC0B+poyLj4k+2Pk= X-MS-TrafficTypeDiagnostic: DM5PR07MB3098: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 20:BN4OLQtfTLgLnF31ONt8ZBRKgeeqJOtWPVCOzd/6TPCDh2Ssxa+aFMbgbWtfv6kVvHnqF2mxJXYKEY8oUY7M4WTOafYRbSb9sTI60XnM2Zyozx2ZXRHkiSuCKQmhJcCkweIWb6yoAdShA6tkZt1yp+ddrhWEkEWJyKekeogvD8hZewitorHaXGvz/854zDrX6eDpitsaicgoJmBhZGPS2hMEm9iWVdVf4vObkczKUw96sZhnhdH6qzdrs/BbHV94O9NRNCd7N6VwxIcp/BTbdxaXclST7GVgCrTUL/3/xZ+/JaAL2WrfT8hH6BHP/aeT5i6RFbd2SnRIvy7HYH8KfRHuHk7ZzpcgO7p7uyI5O3aPjmP8+yVK+B+Mt0/gPD0XoXsMQoFQmhYyi/U9XGUy7BCo3fE7FeTjnV9ZRVYe1+yAcFsBnQy6ucNVkC30cg+NA/03SYxed6H0Pq6dgt5s24H8PdcHzptC/zge75yUBLMwbehi0Zh8khJfr1dtLGXxKNI6wyV5mwYlbBCh+wjPUaWDU0xDYK27fU8AgT90/vPiW4eCBmPsKIM+jmZ/x9c32Y6fU/QYXWCgGrk+VhhvrM0+hFt7nQFwwS8zzjV060c=; 4:TOvPsIOZYP0PRORTdNpF+2do4OpLLXFwa5pHziacoqnahrX2LTB1n1NvTeqcP9jjRI38nKKE3/n7D37Vx5cPAiXND1bMCfhB4SZYnNS9z4l2nRNJhlMJpVjyWaCS+OISkg9190CJPPzhVo6/1B/+0KT1EKoJl96s9n36E4ZOMJ+jESdr6QXmwIFLxjlgA4RdWxJpu93slD/TAexJkSBERAQAZV5waP86vNC1ZekRHxur9UcqmDgMfXFX4g6t7KXK X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(3002001)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3098; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3098; X-Forefront-PRVS: 0452022BE1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6059001)(6009001)(346002)(376002)(189002)(377454003)(24454002)(199003)(25786009)(478600001)(6116002)(36756003)(7416002)(4326008)(54356999)(6246003)(8936002)(58126008)(316002)(2906002)(6916009)(2950100002)(68736007)(5660300001)(42882006)(101416001)(31696002)(97736004)(31686004)(7736002)(81156014)(33646002)(305945005)(23746002)(86152003)(53936002)(81166006)(1706002)(76176999)(8656003)(189998001)(47776003)(72206003)(106356001)(8676002)(65826007)(6666003)(230700001)(65806001)(65956001)(50986999)(93886005)(6486002)(64126003)(229853002)(50466002)(83506001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3098; H:[IPv6:2401:4900:1988:3cbd:a874:81a7:315f:de39]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR07MB3098; 23:Our7NCUSKCSUDCPsE4G8Bd9rf3/Hqw5qLVXut?= =?Windows-1252?Q?5fsj3WQGYkem2Dngiup5jCBMCUoTu58nnclPBlGYkSR3W94nA4REQt7d?= =?Windows-1252?Q?sJwcNT+mQ2HL1lEJqKm6wNNLlOY4wCcbe4F4I0By2xv8OQmfyedpQjAb?= =?Windows-1252?Q?mM/jcctXyeIoxw5BSTUU2c3edg3mZiw5//u+mcVYIKgVo05ndLvsaNTA?= =?Windows-1252?Q?R0V2iI65OdgxovSQya42W4tGY2VfR5udBxTW24ITVXAovTtZ+LLlNOt0?= =?Windows-1252?Q?TW3T/G3sh/nLHOe+WsUty5wuElKyzLAigCaSd+xwMgYFrgb69uNInIbf?= =?Windows-1252?Q?npROgrPEPI/9xZqjpU64JJXnatI804YXjGXqdCrQOJKXol5+t5eyfyiF?= =?Windows-1252?Q?4DfcBolXjWQHEIq4W7uUwuD9k9A2RhaIZuv//hUglDzeaxhC0etlziVr?= =?Windows-1252?Q?cmDM7Wr8oPgG8Jp5lj3LMpIp55ymIVicwmhTJqdjyuqRhxROmianUKvG?= =?Windows-1252?Q?p2DS7nC3VesvJJLfaWyjF7337hJl+kc4iU7ud3cqzDQxmx5wVfiss5CP?= =?Windows-1252?Q?67kM/+/SStY5X5OOeeNHS56g7R3wJKo+uckvgSaqx04kTj/YxMBMMRDU?= =?Windows-1252?Q?/g7lLzX4BwjE5zL6OfqJJn3tJjEYc+sQAuI1+xDEds7V7juEVCu0dPLi?= =?Windows-1252?Q?JmEkpq6o1/hgujctplQZ8V7TzItek4YinCVvJIWwmRXaP6+9GZDOrEpY?= =?Windows-1252?Q?StSu2jh5hEA8fNle9MDRrEZqpGDCoMMdVb4YMeD4MzBPOItQqeMLLsAK?= =?Windows-1252?Q?LHuwjMVnW7cglLFfsAnCprAbAieGcq7WEs7xbRTTDMCBC9BZ9sOhHp13?= =?Windows-1252?Q?d1k5VZCxQsFD1XODv9A7kE2lTUKi0uWpx7xVbS7mlyFEXjyICNeg5EiP?= =?Windows-1252?Q?1ZHBQTNHStRtEVyREKnC5UfOujipZFbsIOHVzE15GbBdkstTpFBhoVaD?= =?Windows-1252?Q?MoE20aNoHjrg85CMV6bnS1qeW8CrnBSI3ONLRPFUW6pO5j3pIVaeBL1w?= =?Windows-1252?Q?DZkfKBRhbacNWmYKWmM9B9Nfw+/rrHCGh4T9w2ycL2v6+DSI9WB+flTj?= =?Windows-1252?Q?Xss+dMxLmJA7agUQWpC8+mj5XlvIAqCfJrm0Gt/lASkOjkdrTNpiic+U?= =?Windows-1252?Q?pHXMep0+uK1W9pOZx4cdLL5IqQnNG4UBQmrTtyCak8moZ1p5w6M8jTNu?= =?Windows-1252?Q?t2u9ocZ8301R9n0CMaDz7LDk9ZYJdj1xa+N47J40215MI40pgXbhwrZw?= =?Windows-1252?Q?NE9h//DdRIDWLvv8oYsnjwimPI72kqcEH8GiQpLext3lczg49KN7rTzN?= =?Windows-1252?Q?4lZC6GCE7MkVUzi4q/iw7SO3FaeQXu3q0iheb9kEq8fnxBfnT1SLOoJH?= =?Windows-1252?Q?NFsjl2mwrHU0kMP+sP5?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 6:dLRHVKBQ9wBnY5im6iJ0kmSyVfFI/V85pDkVDdoKgf9a+hZhRt8RIUb+UQq+gcgIknKXHVTC5voguWTZPWk54uecbFxTgCjsM3hXquoTkNfnPJYlzuo7lWgUrSz/tkgl6NeUOGIODnQc5CZb1P5dGwHbZP/idvR3L7uDi7lRW8n5KKxUHIGUadYAFoAeVNxlpmibiGGKpAho28iJfit6IUuVJq/R/MXVwrpw2FnaDLuMEkT2YCvLmL7NeEgI7tzYDCgnOqcC1GV0m5y2xB/D82ok5fh7Kw36EIHAz7BJj1S6exs9MBQQeJTbgn+1Pe3NEj4LKP7NZAx4BT4TlvMc1w==; 5:7G9NoDPY25XTsJ5leiRngqfn+Q6GN+opyto9STLXyqCcc1Nib+qjgXwpGtEF4HxuLDXI+FMiguTBWi2kSKL8loFDWJJYZrMwNB4OHDlczq1FHV6n106zUOIvqxH4NwGUDKjxOISHyIhoQP+eWa0XaQ==; 24:u4Nsj12giCa76iWu7ZJKQjOYEnp2zWHY/ekECNqkFTqK1L+cn7TQRIYA6lUf+fgniP5Q5+Ws9pgCI+fEmKyxReNd2HMszTZyx6fbaa5UBfI=; 7:DShFd5tT4UdIuI3NZ2wPjmWYM1VuOopmg+Y5EcU6JP/cAaCN3wisqEstm/KR/3SffeZhABrdx3Ejh3ff+Wg2moMowDnL7zaEy9vh9ZAcfUxeMRY9htQB7ZBG2kf55SZP3fM3a2iORfEM5d+d0EO4EdJUsrrd1RfAeQCFVOL11WdBwTcjfK6lQDVMPATrdJx3MCRbuKXZ8K1PYsOluLxv37LnamR4rBeWjQT0fIwat1o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2017 09:11:40.9412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3098 Subject: Re: [dpdk-dev] [PATCH v9 6/9] eal: auto detect iova mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 09:11:49 -0000 On Friday 06 October 2017 01:41 PM, Thomas Monjalon wrote: > 06/10/2017 05:25, santosh: >> On Friday 06 October 2017 05:49 AM, Thomas Monjalon wrote: >>> 20/09/2017 13:23, Santosh Shukla: >>>> For auto detection purpose: >>>> * Below calls moved up in the eal initialization order: >>>> - eal_option_device_parse >>>> - rte_bus_scan >>>> >>>> Based on the result of rte_bus_scan_iommu_class - select iova >>>> mapping mode. >>> It does not explain why you need to move things up. >> For that one should understand eal_init sequence first. >> Should know about _option_device_parse and rte_bus_scan() dependency. >> >> After that bus_scan is a need for _get_iommu_class() of api to know that >> - kdrv is igb/uio/vfio etc.. That's why. Refer work history. >> Again V9 series happened not for fun. I diagress on your comment. > This is the basics of writing a commit log. > You have to explain why things are done. > You move things because of dependencies without explaining them. Agree, But if reader does reading from 0..5, by then he could understand " auto detection purpose" reasoning. Anyways, I'll add more context in patch summary in v10...sending.. > And I'm pretty sure this move will cause big troubles. > For instance, have you tried shared library mode? Its builds, also testpmd works. > One more comment, you are considering only devices scanned at initialization. > What happens when a new device is plugged in? Should work. in vfio mode: if PMDs(for that device) flag set to IOVA_AS_VA flag then newly bound device will have iova=_va mapping mode. Or else iova=_pa. Thanks. > I can push it as is, given there are some Reviewed-by and Tested-by. > I am trying to avoid you a revert of this patch when one will discover > some major bugs. > But I wonder whether it's worth given how you welcome it. >