From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 218DC4F94; Sat, 27 Oct 2018 17:48:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A72F220A0E; Sat, 27 Oct 2018 11:48:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 27 Oct 2018 11:48:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=huTScqGrUOEHC3PYFtk/xhj22ok5PK3tCvfQTIYgUpg=; b=dlo6b+/D8xAf Wn5DGg7h85uezqG4++u5wwwMqSjdIZ2/oggAk+wFOBuvGZcozkZzliqa+nVcuHDT FexxZPAuX+KkaZ+kSMtLxEud3WpwT7/kOdAlOfqiBajgsWVPWCWklTJojKJ11dKH imWFvBwP6BNGz+c7gSFyWjDFR7fRbTw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=huTScqGrUOEHC3PYFtk/xhj22ok5PK3tCvfQTIYgU pg=; b=yh8ne7AnthaM2+AF+QVe088lIpSqVR7AsheQ1nOlCfiB+nYQ2PwMM3Iqw +g1yzA0H0HzqiKPNqPE6E5zib/ZPylb8ApB+K+dCJH943kjpOP/aqlxvuFDaPZfM CQg3qgOv3s6eyjIi1aE7BebMt46rZ4NX6rPY+Cvpr/Uw2yu7CzxOt+oWblOuLYBH Isl3CcYXI9ExmPUVrB1UmwjqIjUT5aDFbaPEECn3/wQK6bJxg2jpHOU79VTtwK5V +NaoaxxKJhJCHi5UffFMoWKHExCthBsxkE+pkp300fnxL8z4WfvYsdKC2sjxPqFS 5VQRWcBkH7O3PDqgcal1kQyEWtcRg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 94388102DD; Sat, 27 Oct 2018 11:48:38 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" , Honnappa Nagarahalli , "stable@dpdk.org" , Ola Liljedahl , "olivier.matz@6wind.com" , "chaozhu@linux.vnet.ibm.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" Date: Sat, 27 Oct 2018 17:48:45 +0200 Message-ID: <9881217.bz70b1Bfip@xps> In-Reply-To: <20181027153355.GA9367@jerin> References: <1537172244-64874-2-git-send-email-gavin.hu@arm.com> <17713879.gC9jYcxDUo@xps> <20181027153355.GA9367@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 15:48:41 -0000 27/10/2018 17:34, Jerin Jacob: > From: Thomas Monjalon > > 27/10/2018 17:00, Jerin Jacob: > > > From: Thomas Monjalon > > > > 17/10/2018 08:35, Gavin Hu (Arm Technology China): > > > > > Hi Jerin > > > > > > > > > > As the 1st one of the 3-patch set was not concluded, I submit this 2-patch series to unblock the merge. > > > > > > > > The thread is totally messed up because: > > > > - there is no cover letter > > > > - some different series (testpmd, i40e and doc) are in the same thread > > > > - v4 replies to a different series > > > > - this version should be a v5 but has no number > > > > - this version replies to the v3 > > > > - patchwork still shows v3 and "v5" > > > > - replies from Ola are not quoting previous discussion > > > > > > > > Because of all of this, it is really difficult to follow. > > > > This is probably the reason of the lack of review outside of Arm. > > > > > > > > One more issue: you must Cc the relevant maintainers. > > > > Here: > > > > - Olivier for rte_ring > > > > - Chao for IBM platform > > > > - Bruce and Konstantin for x86 > > > > > > > > Guys, it is really cool to have more Arm developpers in DPDK. > > > > But please consider better formatting your discussions, it is really > > > > important in our contribution workflow. > > > > > > > > I don't know what to do. > > > > I suggest to wait for more feedbacks and integrate it in -rc2. > > > > > > This series has been acked and tested. Sure, if we are looking for some > > > more feedback we can push to -rc2 if not it a good candidate to be > > > selected for -rc1. > > > > It has been acked and tested only for Arm platforms. > > And Olivier, the ring maintainer, was not Cc. > > > > I feel it is not enough. > > Sure, More reviews is already better. But lets keep as -rc2 target. Yes. If no objection, it will enter in -rc2. After -rc2, we cannot do such core change anyway.