From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4642DA052A; Tue, 26 Jan 2021 16:27:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 121D2140F8C; Tue, 26 Jan 2021 16:27:37 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id EFE9C140F88 for ; Tue, 26 Jan 2021 16:27:33 +0100 (CET) IronPort-SDR: FtYzJHqdn5UIQ1c/MHrFUfh0/wgOFEIEu3V63yzCLBCCA9kMEqxYhEKfA5llOW+Ni//+17y3/e sxqUzooJbZ2w== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="264739923" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="264739923" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:27:33 -0800 IronPort-SDR: ZXRmm8aoxkjaQaFIJrf1vhAduav8wdrJWa0fPvtaCkvQ+vc9FlDdUc8torEWCDpRdrNUMkpakt 7FalAXn1wEEg== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="362020776" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.53]) ([10.213.227.53]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:27:30 -0800 To: Nalla Pradeep , Jerin Jacob , Nithin Dabilpuram , Radha Mohan Chintakuntla , Veerasenareddy Burru Cc: dev@dpdk.org, sburla@marvell.com References: <20210118093602.5449-1-pnalla@marvell.com> <20210118093602.5449-2-pnalla@marvell.com> From: Ferruh Yigit Message-ID: <988b0493-8c97-c1e1-5a78-771670fa6705@intel.com> Date: Tue, 26 Jan 2021 15:27:29 +0000 MIME-Version: 1.0 In-Reply-To: <20210118093602.5449-2-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 02/11] net/octeontx_ep: add ethdev probe and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/18/2021 9:35 AM, Nalla Pradeep wrote: > add basic PCIe ethdev probe and remove. > > Signed-off-by: Nalla Pradeep <...> > @@ -136,7 +136,10 @@ extern int otx2_logtype_ree; > #define PCI_DEVID_OCTEONTX2_RVU_CPT_VF 0xA0FE > #define PCI_DEVID_OCTEONTX2_RVU_AF_VF 0xA0f8 > #define PCI_DEVID_OCTEONTX2_DPI_VF 0xA081 > -#define PCI_DEVID_OCTEONTX2_EP_VF 0xB203 /* OCTEON TX2 EP mode */ > +#define PCI_DEVID_OCTEONTX2_EP_NET_VF 0xB203 /* OCTEON TX2 EP mode */ You can considering doing this rename on its own patch, to reduce the noise for the actual patch. <...> > +++ b/drivers/net/octeontx_ep/meson.build > @@ -6,3 +6,16 @@ sources = files( > 'otx_ep_ethdev.c', > ) > > +extra_flags = [] > +# This integrated controller runs only on a arm64 machine, remove 32bit warnings > +if not dpdk_conf.get('RTE_ARCH_64') > + extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > +endif There is almost any code at this stage, are above compiler flags really needed? Can you add then only when they are really needed? <...> > --- a/drivers/net/octeontx_ep/otx_ep_ethdev.c > +++ b/drivers/net/octeontx_ep/otx_ep_ethdev.c > @@ -1,3 +1,65 @@ > /* SPDX-License-Identifier: BSD-3-Clause > * Copyright(C) 2020 Marvell. > */ > + > +#include > +#include > +#include > + Are all these headers needed, no io or mem allocation yet, can you please add them as they are needed? <...> > +++ b/drivers/net/octeontx_ep/otx_ep_vf.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2020 Marvell. > + */ > +#ifndef _OTX_EP_VF_H_ > +#define _OTX_EP_VF_H_ > + > +#define PCI_DEVID_OCTEONTX_EP_VF 0xa303 > + Why this PCI device id defined different place than all the others did, won't it be easier to keep them all in same place?