From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mb@smartsharesystems.com>
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by dpdk.org (Postfix) with ESMTP id 6EC7FC69C
 for <dev@dpdk.org>; Thu, 18 Jun 2015 16:39:07 +0200 (CEST)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Date: Thu, 18 Jun 2015 16:38:56 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC358AF171@smartserver.smartshare.dk>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Re: [PATCH v4] doc: guidelines for library statistics
Thread-Index: AdCp1IHOJ8rik4GqQNe/YIGkBMF1pg==
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: <dev@dpdk.org>
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v4] doc: guidelines for library statistics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 14:39:07 -0000

The suggested solution with only one single flag per library prevents =
implementing statistics with varying granularity for different purposes. =
E.g. a library could have one set of statistics counters for ordinary =
SNMP purposes, and another set of statistics counters for =
debugging/optimization purposes.

=20

Multiple flags per library should be possible. A hierarchy of flags per =
library is probably not required.

=20

And since the compile time flag =
CONFIG_RTE_<LIBRARY_NAME>[_<STATS_COLLECTION_NAME>]_STATS_COLLECT =
already tells the application if the statistics are present or not, the =
application should simply use this flag to determine if statistics are =
accessible or not.

=20

=20

=20

Med venlig hilsen / kind regards

=20

Morten Br=F8rup

CTO

=20

=20

=20

SmartShare Systems A/S

Tonsbakken 16-18

DK-2740 Skovlunde

Denmark

=20

Office      +45 70 20 00 93

Direct      +45 89 93 50 22

Mobile      +45 25 40 82 12

=20

mb@smartsharesystems.com <mailto:mb@smartsharesystems.com>=20

www.smartsharesystems.com <http://www.smartsharesystems.com/>=20

=20