From: "Morten Brørup" <mb@smartsharesystems.com>
To: "DPDK" <dev@dpdk.org>
Subject: [dpdk-dev] mbuf vlan_tci validity unclear
Date: Wed, 17 Jan 2018 22:20:53 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B41D73@smartserver.smartshare.dk> (raw)
In rte_mbuf.h, the description of the PKT_RX_VLAN flag (lines 93-94) says that mbuf->vlan_tci contains the VLAN TCI if the flag is set; however, the description of the vlan_tci field (line 513) says that the PKT_RX_VLAN_STRIPPED flag must be set for it to be valid.
Which one is it? And will someone please update the comments in rte_mbuf.h accordingly.
Med venlig hilsen / kind regards
Morten Brørup
CTO
SmartShare Systems A/S
Tonsbakken 16-18
DK-2740 Skovlunde
Denmark
Office +45 70 20 00 93
Direct +45 89 93 50 22
Mobile +45 25 40 82 12
mb@smartsharesystems.com <mailto:mb@smartsharesystems.com>
www.smartsharesystems.com <https://www.smartsharesystems.com/>
next reply other threads:[~2018-01-17 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 21:20 Morten Brørup [this message]
2018-01-22 12:51 ` Olivier Matz
2018-01-29 9:36 ` [dpdk-dev] [PATCH] mbuf: fix API documentation regarding VLAN flags Olivier Matz
2018-01-29 16:24 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35B41D73@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).