From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by dpdk.org (Postfix) with ESMTP id 0C2D81B4A1; Tue, 8 Jan 2019 12:33:42 +0100 (CET) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Date: Tue, 8 Jan 2019 12:33:41 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B425AD@smartserver.smartshare.dk> In-Reply-To: <2601191342CEEE43887BDE71AB977258010D900817@irsmsx105.ger.corp.intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [dpdk-dev] [PATCH] gro: add missing invalid packet checks Thread-Index: AQHUpxi6gYDMrmZp9k2BAzziHTP876Wk6XyAgAAclYCAACVRUIAADnMw References: <1546567036-29444-1-git-send-email-jiayu.hu@intel.com> <1546927725-68831-1-git-send-email-jiayu.hu@intel.com> <20190107223151.18b185b7@hermes.lan> <2601191342CEEE43887BDE71AB977258010D900817@irsmsx105.ger.corp.intel.com> From: =?utf-8?B?TW9ydGVuIEJyw7hydXA=?= To: "Ananyev, Konstantin" , "Hu, Jiayu" , "Stephen Hemminger" Cc: , "Bie, Tiwei" , "Richardson, Bruce" , Subject: Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 11:33:43 -0000 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBkZXYgW21haWx0bzpkZXYtYm91 bmNlc0BkcGRrLm9yZ10gT24gQmVoYWxmIE9mIEFuYW55ZXYsDQo+IEtvbnN0YW50aW4NCj4gU2Vu dDogVHVlc2RheSwgSmFudWFyeSA4LCAyMDE5IDExOjM5IEFNDQo+IFRvOiBIdSwgSmlheXU7IFN0 ZXBoZW4gSGVtbWluZ2VyDQo+IENjOiBkZXZAZHBkay5vcmc7IEJpZSwgVGl3ZWk7IFJpY2hhcmRz b24sIEJydWNlOyBzdGFibGVAZHBkay5vcmcNCj4gU3ViamVjdDogUmU6IFtkcGRrLWRldl0gW1BB VENIXSBncm86IGFkZCBtaXNzaW5nIGludmFsaWQgcGFja2V0IGNoZWNrcw0KPiANCj4gDQo+IA0K PiA+DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBT dGVwaGVuIEhlbW1pbmdlciBbbWFpbHRvOnN0ZXBoZW5AbmV0d29ya3BsdW1iZXIub3JnXQ0KPiA+ ID4gU2VudDogVHVlc2RheSwgSmFudWFyeSA4LCAyMDE5IDI6MzIgUE0NCj4gPiA+IFRvOiBIdSwg SmlheXUgPGppYXl1Lmh1QGludGVsLmNvbT4NCj4gPiA+IENjOiBkZXZAZHBkay5vcmc7IEJpZSwg VGl3ZWkgPHRpd2VpLmJpZUBpbnRlbC5jb20+OyBSaWNoYXJkc29uLA0KPiBCcnVjZQ0KPiA+ID4g PGJydWNlLnJpY2hhcmRzb25AaW50ZWwuY29tPjsgc3RhYmxlQGRwZGsub3JnDQo+ID4gPiBTdWJq ZWN0OiBSZTogW2RwZGstZGV2XSBbUEFUQ0hdIGdybzogYWRkIG1pc3NpbmcgaW52YWxpZCBwYWNr ZXQNCj4gY2hlY2tzDQo+ID4gPg0KPiA+ID4gT24gVHVlLCAgOCBKYW4gMjAxOSAxNDowODo0NSAr MDgwMA0KPiA+ID4gSmlheXUgSHUgPGppYXl1Lmh1QGludGVsLmNvbT4gd3JvdGU6DQo+ID4gPg0K PiA+ID4gPiArCS8qDQo+ID4gPiA+ICsJICogRG9uJ3QgcHJvY2VzcyB0aGUgcGFja2V0IHdob3Nl IEV0aGVybmV0LCBJUHY0IGFuZCBUQ1ANCj4gaGVhZGVyDQo+ID4gPiA+ICsJICogbGVuZ3RocyBh cmUgaW52YWxpZC4gSW4gYWRkaXRpb24sIGlmIHRoZSBJUHY0IGhlYWRlcg0KPiBjb250YWlucw0K PiA+ID4gPiArCSAqIE9wdGlvbnMsIHRoZSBwYWNrZXQgc2hvdWxkbid0IGJlIHByb2Nlc3NlZC4N Cj4gPiA+ID4gKwkgKi8NCj4gPiA+ID4gKwlpZiAodW5saWtlbHkoSUxMRUdBTF9FVEhFUl9IRFJM RU4ocGt0LT5sMl9sZW4pIHx8DQo+ID4gPiA+ICsJCQlJTExFR0FMX0lQVjRfSERSTEVOKHBrdC0+ bDNfbGVuKSB8fA0KPiA+ID4gPiArCQkJSUxMRUdBTF9UQ1BfSERSTEVOKHBrdC0+bDRfbGVuKSkp DQo+ID4gPiA+ICsJCXJldHVybiAtMTsNCj4gPg0KPiA+IEluIHRoZSBHUk8gZGVzaWduLCB3ZSBh c3N1bWUgYXBwbGljYXRpb25zIGdpdmUgY29ycmVjdA0KPiA+IE1CVUYtPmwyX2xlbi8uLiBmb3Ig aW5wdXQgcGFja2V0cyBvZiBHUk8uIFNwZWNpZmljYWxseSwgR1JPDQo+ID4gbGlicmFyeSBhc3N1 bWVzIGFwcGxpY2F0aW9ucyB3aWxsIHNldCB2YWx1ZXMgdG8gTUJVRi0+bDJfbGVuLy4uLg0KPiA+ IGFuZCBndWFyYW50ZWUgdGhlIHZhbHVlcyBhcmUgdGhlIHNhbWUgYXMgdGhlIHZhbHVlcyBpbiB0 aGUgcGFja2V0DQo+ID4gaGVhZGVycy4gVGhlIHJlYXNvbiBmb3IgdGhpcyBhc3N1bXB0aW9uIGlz IHRvIHByb2Nlc3MgaGVhZGVyIGZhc3Rlci4NCg0KPiA+IFRoaXMgaXMgYWxzbyB3aHkgSSB3YW50 IHRvIGFkZCB0aGlzIGFzc3VtcHRpb24gaW4gdGhlIHByb2dyYW1tZXINCj4gPiBndWlkZS4NCg0K KzEgdG8gbW9yZSBkZXRhaWxlZCBkb2N1bWVudGF0aW9uIGFib3V0IGFzc3VtcHRpb25zIGFuZCBw cmVjb25kaXRpb25zLg0KDQoNCj4gPg0KPiA+IFRoZSBhYm92ZSBjb2RlIGlzIHRvIGZvcmJpZCBH Uk8gdG8gcHJvY2VzcyBpbnZhbGlkIHBhY2tldHMsIHdoaWNoDQo+ID4gaGF2ZSBpbnZhbGlkIHBh Y2tldCBoZWFkZXIgbGVuZ3RocywgbGlrZSBUQ1AgaGVhZGVyIGxlbmd0aCBpcyBsZXNzDQo+IHRo YW4NCj4gPiAyMCBieXRlcy4NCj4gPg0KPiA+ID4NCj4gPiA+IEkgbGlrZSBpdCB3aGVuIGNvZGUg aXMgYXMgcGlja3kgYXMgcG9zc2libGUgd2hlbiBkb2luZw0KPiBvcHRpbWl6YXRpb25zIGJlY2F1 c2UNCj4gPiA+IGl0IHJlZHVjZXMgcG9zc2libGUgc2VjdXJpdHkgcmlza2cuDQo+ID4gPg0KPiA+ ID4gVG8gbWUgdGhpcyBsb29rcyBtb3JlIGNvbmZ1c2luZyBhbmQgbm90IGFzIGNhcmVmdWwgYXMg ZG9pbmcgaXQNCj4gbGlrZToNCj4gPiA+DQo+ID4gPiAJaWYgKHVubGlrZWx5KHBrdC0+bDJfbGVu ICE9IEVUSEVSX0hEUl9MRU4pKQ0KPiA+ID4gCQlyZXR1cm4gLTE7DQo+ID4gPiAJZXRoX2hkciA9 IHJ0ZV9wa3RtYnVmX210b2QocGt0LCBzdHJ1Y3QgZXRoZXJfaGRyICopOw0KPiA+ID4gCWlwdjRf aGRyID0gKHN0cnVjdCBpcHY0X2hkciAqKSgoY2hhciAqKWV0aF9oZHIgKyBFVEhFUl9IRFJfTEVO KTsNCj4gPiA+DQo+ID4gPiAJaWYgKHBrdC0+bDNfbGVuICE9IChpcHY0LT52ZXJzaW9uX2lobCAm IElQVjRfSERSX0lITF9NQVNLKSA8PCA0KQ0KPiA+ID4gCQlyZXR1cm4gLTE7DQo+ID4gPg0KPiA+ ID4gCWlmIChwa3QtPmw0X2xlbiA8IHNpemVvZihzdHJ1Y3QgdGNwX2hkcikpDQo+ID4gPiAJCXJl dHVybiAtMTsNCj4gPiA+DQo+ID4gPiBZb3Ugc2hvdWxkIGFsc28gY2hlY2sgZm9yIFRDUCBvcHRp b25zIGFzIHdlbGwuDQo+ID4NCj4gPiBUaGVyZSBhcmUgdHdvIHdheXMgdG8gZ2V0IGV0aGVyLCBp cHY0IGFuZCB0Y3AgaGVhZGVyczoNCj4gPiAxKS4gVXNlIE1CVUYtPmwyX2xlbi9sM19sZW4uLi47 DQo+ID4gMikuIFBhcnNlIHBhY2tldCBhbmQgaWdub3JlIE1CVUYtPmwyX2xlbi8uLi4uDQo+ID4N Cj4gPiBJZiB3ZSBmb2xsb3cgdGhlIGNob2ljZSAxLCB3ZSBkb24ndCBuZWVkIHRvIHBhcnNlIHBh Y2tldCBhbmQNCj4gPiBkb24ndCBuZWVkIHRvIGNoZWNrIGlmIHZhbHVlcyBvZiBNQlVGLT5sMl9s ZW4vLi4uIGFyZSBjb3JyZWN0LA0KPiA+IHNpbmNlIHdlIGFzc3VtZSBhcHBsaWNhdGlvbnMgd2ls bCBzZXQgY29ycmVjdCB2YWx1ZXMuIElmIHdlIGZvbGxvdw0KPiA+IHRoZSBjaG9pY2UgMiwgd2Ug ZG9uJ3QgbmVlZCB0byBjYXJlIGFib3V0IHRoZSB2YWx1ZXMgb2YgTUJVRi0NCj4gPmwyX2xlbi8u Li4NCj4gPg0KPiA+IEkgYW0gYSBsaXR0bGUgY29uZnVzZWQgYWJvdXQgeW91ciBjb2RlLCBzaW5j ZSBpdCBwYXJzZXMgcGFja2V0IGFuZA0KPiA+IGNoZWNrcyBpZiB0aGUgdmFsdWVzIG9mIE1CVUYt PmwyX2xlbi8uLi4gYXJlIGNvcnJlY3QuIElmIHdlIGRvbid0IHVzZQ0KPiA+IE1CVUYtPmwyX2xl bi8uLi4gdG8gZ2V0IGV0aGVyL2lwdjQvdGNwIGhlYWRlcnMsIHdoeSBzaG91bGQgd2UgY2hlY2sN Cj4gPiB0aGUgdmFsdWVzIG9mIE1CVUYtPmwyX2xlbi8uLi4/DQo+ID4NCj4gDQo+IEFncmVlIHRo YXQgd2UgZG9uJ3QgbmVlZCBib3RoLg0KPiBNeSBwcmVmZXJlbmNlIHdvdWxkIGJlIHRvIHN0aWNr IHdpdGggMSkuDQo+IEluIG1hbnkgY2FzZXMgdXNlciB3b3VsZCBoYXZlIGFscmVhZHkgZGV0ZXJt aW5lZCBsMi9sMy9sNCBsZW4NCj4gYnkgdGhpcyBzdGFnZS4NCj4gS29uc3RhbnRpbg0KDQpEbyB3 ZSBoYXZlIGEgZ2VuZXJpYyBwYWNrZXQgaGVhZGVyIHZhbGlkYXRpb24gbGlicmFyeT8gT3RoZXJ3 aXNlLCB0aGF0IHdvdWxkIHBlcmhhcHMgYmUgYSBiZXR0ZXIgcGF0aC4gU3VjaCBhIGxpYnJhcnkg Y291bGQgcHJvYmFibHkgdXNlIHNvbWUgb2YgdGhlIGZsYWdzIGZyb20gdGhlIFBNRCB0byBkZXRl cm1pbmUgaG93IG11Y2ggdG8gdmFsaWRhdGUgaW4gc29mdHdhcmUuDQoNCkFuZCBpZiBpdCBpcyBh IGRvY3VtZW50ZWQgcHJlY29uZGl0aW9uIG9mIHRoZSBHUk8gbGlicmFyeSB0aGF0IG0tPmwyX2xl bi9sM19sZW4uLi4gbXVzdCBiZSBzZXQgYW5kIHNlbnNpYmxlLCBwZXJoYXBzIGFuIFJURV9BU1NF UlQoKSBjb3VsZCBiZSBjb25zaWRlcmVkIGluc3RlYWQgb2YgZ3JhY2VmdWxseSByZXR1cm5pbmcg LTE/DQoNCg==