From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by dpdk.org (Postfix) with ESMTP id 1BB371B1F0; Tue, 8 Jan 2019 15:50:23 +0100 (CET) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Date: Tue, 8 Jan 2019 15:50:21 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B425B0@smartserver.smartshare.dk> In-Reply-To: <2601191342CEEE43887BDE71AB977258010D900A85@irsmsx105.ger.corp.intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [dpdk-dev] [PATCH] gro: add missing invalid packet checks Thread-Index: AQHUpxi6gYDMrmZp9k2BAzziHTP876Wk6XyAgAAclYCAACVRUIAADnMwgAAnmQCAAAZaUA== References: <1546567036-29444-1-git-send-email-jiayu.hu@intel.com> <1546927725-68831-1-git-send-email-jiayu.hu@intel.com> <20190107223151.18b185b7@hermes.lan> <2601191342CEEE43887BDE71AB977258010D900817@irsmsx105.ger.corp.intel.com> <98CBD80474FA8B44BF855DF32C47DC35B425AD@smartserver.smartshare.dk> <2601191342CEEE43887BDE71AB977258010D900A85@irsmsx105.ger.corp.intel.com> From: =?utf-8?B?TW9ydGVuIEJyw7hydXA=?= To: "Ananyev, Konstantin" , "Hu, Jiayu" , "Stephen Hemminger" Cc: , "Bie, Tiwei" , "Richardson, Bruce" , Subject: Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 14:50:23 -0000 PiBGcm9tOiBBbmFueWV2LCBLb25zdGFudGluIFttYWlsdG86a29uc3RhbnRpbi5hbmFueWV2QGlu dGVsLmNvbV0NCj4gPiBGcm9tOiBNb3J0ZW4gQnLDuHJ1cCBbbWFpbHRvOm1iQHNtYXJ0c2hhcmVz eXN0ZW1zLmNvbV0NCj4gPiA+IEZyb206IGRldiBbbWFpbHRvOmRldi1ib3VuY2VzQGRwZGsub3Jn XSBPbiBCZWhhbGYgT2YgQW5hbnlldiwNCj4gPiA+IEtvbnN0YW50aW4NCj4gPiA+ID4gPiBGcm9t OiBTdGVwaGVuIEhlbW1pbmdlciBbbWFpbHRvOnN0ZXBoZW5AbmV0d29ya3BsdW1iZXIub3JnXQ0K PiA+ID4gPiA+DQo+ID4gPiA+ID4gT24gVHVlLCAgOCBKYW4gMjAxOSAxNDowODo0NSArMDgwMA0K PiA+ID4gPiA+IEppYXl1IEh1IDxqaWF5dS5odUBpbnRlbC5jb20+IHdyb3RlOg0KPiA+ID4gPiA+ DQo+ID4gPiA+ID4gPiArCS8qDQo+ID4gPiA+ID4gPiArCSAqIERvbid0IHByb2Nlc3MgdGhlIHBh Y2tldCB3aG9zZSBFdGhlcm5ldCwgSVB2NCBhbmQgVENQDQo+ID4gPiBoZWFkZXINCj4gPiA+ID4g PiA+ICsJICogbGVuZ3RocyBhcmUgaW52YWxpZC4gSW4gYWRkaXRpb24sIGlmIHRoZSBJUHY0IGhl YWRlcg0KPiA+ID4gY29udGFpbnMNCj4gPiA+ID4gPiA+ICsJICogT3B0aW9ucywgdGhlIHBhY2tl dCBzaG91bGRuJ3QgYmUgcHJvY2Vzc2VkLg0KPiA+ID4gPiA+ID4gKwkgKi8NCj4gPiA+ID4gPiA+ ICsJaWYgKHVubGlrZWx5KElMTEVHQUxfRVRIRVJfSERSTEVOKHBrdC0+bDJfbGVuKSB8fA0KPiA+ ID4gPiA+ID4gKwkJCUlMTEVHQUxfSVBWNF9IRFJMRU4ocGt0LT5sM19sZW4pIHx8DQo+ID4gPiA+ ID4gPiArCQkJSUxMRUdBTF9UQ1BfSERSTEVOKHBrdC0+bDRfbGVuKSkpDQo+ID4gPiA+ID4gPiAr CQlyZXR1cm4gLTE7DQo+ID4gPiA+DQo+ID4gPiA+IEluIHRoZSBHUk8gZGVzaWduLCB3ZSBhc3N1 bWUgYXBwbGljYXRpb25zIGdpdmUgY29ycmVjdA0KPiA+ID4gPiBNQlVGLT5sMl9sZW4vLi4gZm9y IGlucHV0IHBhY2tldHMgb2YgR1JPLiBTcGVjaWZpY2FsbHksIEdSTw0KPiA+ID4gPiBsaWJyYXJ5 IGFzc3VtZXMgYXBwbGljYXRpb25zIHdpbGwgc2V0IHZhbHVlcyB0byBNQlVGLT5sMl9sZW4vLi4u DQo+ID4gPiA+IGFuZCBndWFyYW50ZWUgdGhlIHZhbHVlcyBhcmUgdGhlIHNhbWUgYXMgdGhlIHZh bHVlcyBpbiB0aGUgcGFja2V0DQo+ID4gPiA+IGhlYWRlcnMuIFRoZSByZWFzb24gZm9yIHRoaXMg YXNzdW1wdGlvbiBpcyB0byBwcm9jZXNzIGhlYWRlcg0KPiBmYXN0ZXIuDQo+ID4NCj4gPiA+ID4g VGhpcyBpcyBhbHNvIHdoeSBJIHdhbnQgdG8gYWRkIHRoaXMgYXNzdW1wdGlvbiBpbiB0aGUgcHJv Z3JhbW1lcg0KPiA+ID4gPiBndWlkZS4NCj4gPg0KPiA+ICsxIHRvIG1vcmUgZGV0YWlsZWQgZG9j dW1lbnRhdGlvbiBhYm91dCBhc3N1bXB0aW9ucyBhbmQNCj4gcHJlY29uZGl0aW9ucy4NCj4gPg0K PiA+DQo+ID4gPiA+DQo+ID4gPiA+IFRoZSBhYm92ZSBjb2RlIGlzIHRvIGZvcmJpZCBHUk8gdG8g cHJvY2VzcyBpbnZhbGlkIHBhY2tldHMsIHdoaWNoDQo+ID4gPiA+IGhhdmUgaW52YWxpZCBwYWNr ZXQgaGVhZGVyIGxlbmd0aHMsIGxpa2UgVENQIGhlYWRlciBsZW5ndGggaXMNCj4gbGVzcw0KPiA+ ID4gdGhhbg0KPiA+ID4gPiAyMCBieXRlcy4NCj4gPiA+ID4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ IEkgbGlrZSBpdCB3aGVuIGNvZGUgaXMgYXMgcGlja3kgYXMgcG9zc2libGUgd2hlbiBkb2luZw0K PiA+ID4gb3B0aW1pemF0aW9ucyBiZWNhdXNlDQo+ID4gPiA+ID4gaXQgcmVkdWNlcyBwb3NzaWJs ZSBzZWN1cml0eSByaXNrZy4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFRvIG1lIHRoaXMgbG9va3Mg bW9yZSBjb25mdXNpbmcgYW5kIG5vdCBhcyBjYXJlZnVsIGFzIGRvaW5nIGl0DQo+ID4gPiBsaWtl Og0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gCWlmICh1bmxpa2VseShwa3QtPmwyX2xlbiAhPSBFVEhF Ul9IRFJfTEVOKSkNCj4gPiA+ID4gPiAJCXJldHVybiAtMTsNCj4gPiA+ID4gPiAJZXRoX2hkciA9 IHJ0ZV9wa3RtYnVmX210b2QocGt0LCBzdHJ1Y3QgZXRoZXJfaGRyICopOw0KPiA+ID4gPiA+IAlp cHY0X2hkciA9IChzdHJ1Y3QgaXB2NF9oZHIgKikoKGNoYXIgKilldGhfaGRyICsNCj4gRVRIRVJf SERSX0xFTik7DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiAJaWYgKHBrdC0+bDNfbGVuICE9IChpcHY0 LT52ZXJzaW9uX2lobCAmIElQVjRfSERSX0lITF9NQVNLKQ0KPiA8PCA0KQ0KPiA+ID4gPiA+IAkJ cmV0dXJuIC0xOw0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gCWlmIChwa3QtPmw0X2xlbiA8IHNpemVv ZihzdHJ1Y3QgdGNwX2hkcikpDQo+ID4gPiA+ID4gCQlyZXR1cm4gLTE7DQo+ID4gPiA+ID4NCj4g PiA+ID4gPiBZb3Ugc2hvdWxkIGFsc28gY2hlY2sgZm9yIFRDUCBvcHRpb25zIGFzIHdlbGwuDQo+ ID4gPiA+DQo+ID4gPiA+IFRoZXJlIGFyZSB0d28gd2F5cyB0byBnZXQgZXRoZXIsIGlwdjQgYW5k IHRjcCBoZWFkZXJzOg0KPiA+ID4gPiAxKS4gVXNlIE1CVUYtPmwyX2xlbi9sM19sZW4uLi47DQo+ ID4gPiA+IDIpLiBQYXJzZSBwYWNrZXQgYW5kIGlnbm9yZSBNQlVGLT5sMl9sZW4vLi4uLg0KPiA+ ID4gPg0KPiA+ID4gPiBJZiB3ZSBmb2xsb3cgdGhlIGNob2ljZSAxLCB3ZSBkb24ndCBuZWVkIHRv IHBhcnNlIHBhY2tldCBhbmQNCj4gPiA+ID4gZG9uJ3QgbmVlZCB0byBjaGVjayBpZiB2YWx1ZXMg b2YgTUJVRi0+bDJfbGVuLy4uLiBhcmUgY29ycmVjdCwNCj4gPiA+ID4gc2luY2Ugd2UgYXNzdW1l IGFwcGxpY2F0aW9ucyB3aWxsIHNldCBjb3JyZWN0IHZhbHVlcy4gSWYgd2UNCj4gZm9sbG93DQo+ ID4gPiA+IHRoZSBjaG9pY2UgMiwgd2UgZG9uJ3QgbmVlZCB0byBjYXJlIGFib3V0IHRoZSB2YWx1 ZXMgb2YgTUJVRi0NCj4gPiA+ID5sMl9sZW4vLi4uDQo+ID4gPiA+DQo+ID4gPiA+IEkgYW0gYSBs aXR0bGUgY29uZnVzZWQgYWJvdXQgeW91ciBjb2RlLCBzaW5jZSBpdCBwYXJzZXMgcGFja2V0DQo+ IGFuZA0KPiA+ID4gPiBjaGVja3MgaWYgdGhlIHZhbHVlcyBvZiBNQlVGLT5sMl9sZW4vLi4uIGFy ZSBjb3JyZWN0LiBJZiB3ZSBkb24ndA0KPiB1c2UNCj4gPiA+ID4gTUJVRi0+bDJfbGVuLy4uLiB0 byBnZXQgZXRoZXIvaXB2NC90Y3AgaGVhZGVycywgd2h5IHNob3VsZCB3ZQ0KPiBjaGVjaw0KPiA+ ID4gPiB0aGUgdmFsdWVzIG9mIE1CVUYtPmwyX2xlbi8uLi4/DQo+ID4gPiA+DQo+ID4gPg0KPiA+ ID4gQWdyZWUgdGhhdCB3ZSBkb24ndCBuZWVkIGJvdGguDQo+ID4gPiBNeSBwcmVmZXJlbmNlIHdv dWxkIGJlIHRvIHN0aWNrIHdpdGggMSkuDQo+ID4gPiBJbiBtYW55IGNhc2VzIHVzZXIgd291bGQg aGF2ZSBhbHJlYWR5IGRldGVybWluZWQgbDIvbDMvbDQgbGVuDQo+ID4gPiBieSB0aGlzIHN0YWdl Lg0KPiA+ID4gS29uc3RhbnRpbg0KPiA+DQo+ID4gRG8gd2UgaGF2ZSBhIGdlbmVyaWMgcGFja2V0 IGhlYWRlciB2YWxpZGF0aW9uIGxpYnJhcnk/IE90aGVyd2lzZSwNCj4gdGhhdCB3b3VsZCBwZXJo YXBzIGJlIGEgYmV0dGVyIHBhdGguIFN1Y2ggYSBsaWJyYXJ5IGNvdWxkIHByb2JhYmx5IHVzZQ0K PiA+IHNvbWUgb2YgdGhlIGZsYWdzIGZyb20gdGhlIFBNRCB0byBkZXRlcm1pbmUgaG93IG11Y2gg dG8gdmFsaWRhdGUgaW4NCj4gc29mdHdhcmUuDQo+IA0KPiBBRkFJSyAtIHdlIGRvbid0IGhhdmUg YSBnZW5lcmljIGhlYWRlciBwYXJzaW5nIGxpYnJhcnkuDQo+IFllcywgaXQgd291bGQgYmUgZ29v ZCB0byBoYXZlIHN1Y2ggYWJpbGl0eSwgYnV0IEkgdGhpbmsgdGhhdCdzIG91dCBvZg0KPiBzY29w ZSBmb3IgdGhhdCBwYXRjaC4NCj4gQlRXLCB2b2x1bnRlZXJzIGFyZSB3ZWxjb21lIDopDQo+IA0K PiA+DQo+ID4gQW5kIGlmIGl0IGlzIGEgZG9jdW1lbnRlZCBwcmVjb25kaXRpb24gb2YgdGhlIEdS TyBsaWJyYXJ5IHRoYXQgbS0NCj4gPmwyX2xlbi9sM19sZW4uLi4gbXVzdCBiZSBzZXQgYW5kIHNl bnNpYmxlLCBwZXJoYXBzIGFuIFJURV9BU1NFUlQoKQ0KPiBjb3VsZA0KPiA+IGJlIGNvbnNpZGVy ZWQgaW5zdGVhZCBvZiBncmFjZWZ1bGx5IHJldHVybmluZyAtMT8NCj4gDQo+IEkgc3VwcG9zZSB0 aGF0J3MgdG9vIGV4dHJlbWUuDQo+IFdoYXQncyB3cm9uZyB3aXRoIGNoZWNraW5nIGlucHV0IHBh cmFtZXRlcnMgYW5kIHJldHVybiBhbiBlcnJvciBpZiB0aGV5DQo+IGFyZSBpbnZhbGlkPw0KPiBL b25zdGFudGluDQo+DQpJdCBpcyBleHRyZW1lLCBhbmQgaXQgd2FzIHBhcnRseSBtZWFudCBhcyBh IHByb3ZvY2F0aW9uIHRvIHRoaW5rIGRlZXBlciBhYm91dCBpdDogRG8gd2UgcmVhbGx5IG5lZWQg dG8gZm9sbG93IFBvc3RlbCdzIGxhdyAoaHR0cHM6Ly9lbi53aWtpcGVkaWEub3JnL3dpa2kvUm9i dXN0bmVzc19wcmluY2lwbGUpIGluIGZ1bmN0aW9ucyB3aGVyZSB3ZSBhcmUgaW4gZnVsbCBjb250 cm9sIG91cnNlbHZlcz8NCg0KSGVyZSdzIHdoYXQncyB3cm9uZyB3aXRoIGl0OiBJZiBlYWNoIGZ1 bmN0aW9uIGEgcGFja2V0IHBhc3NlcyB0aHJvdWdoIGhhcyB0byBwYXJzZSB0aGUgcGFja2V0IGhl YWRlcnMgYW5kIHZhbGlkYXRlIHRoZSBtYnVmIHBhcmFtZXRlcnMgZnJvbSBzY3JhdGNoLCBpdCB3 aWxsIGhhdmUgYW4gdW5uZWNlc3NhcnkgcGVyZm9ybWFuY2UgY29zdC4gSXQgc2hvdWxkIGJlIGRv bmUgb25seSBvbmNlIGluIHRoZSBmYXN0IHBhdGgsIGFuZCBzdWJzZXF1ZW50IGZ1bmN0aW9ucyBz aG91bGQgYmUgYWJsZSB0byByZWx5IG9uIHRoZSByZXN1bHQgb2YgdGhhdC4NCg0KR2VuZXJhbGx5 LCB3ZSBzaG91bGQgYmUgYWJsZSB0byByZWx5IG9uIGFzc3VtcHRpb25zL3ByZWNvbmRpdGlvbnMu IEFuZCB3aGVuIGEgZnVuY3Rpb24gcmVsaWVzIG9uIHNvbWV0aGluZywgaXQgaXMgYSBnb29kIHRo aW5nIHRvIGRlc2NyaWJlIHN1Y2ggcHJlY29uZGl0aW9ucyBpbiB0aGUgZnVuY3Rpb24ncyBkb2N1 bWVudGF0aW9uLg0KDQpGcm9tIGEgaGlnaCBsZXZlbCBwZXJzcGVjdGl2ZSwgRFBESyBDb3JlIHNo b3VsZCBub3QgYmUgYSBidW5jaCBvZiBjb21wbGV0ZWx5IGluZGVwZW5kZW50IGxpYnJhcmllcywg YnV0IGEgY29uc2lzdGVudCBsaWJyYXJ5IHdoZXJlIGl0cyBmdW5jdGlvbnMgY2FuIHJlbHkgb24g cHJlY29uZGl0aW9ucyBhbmQgcG9zdGNvbmRpdGlvbnMgb2YgaXRzIG90aGVyIGZ1bmN0aW9ucyBh bmQgdGhlaXIgaW50ZW5kZWQgdXNlIGluIHRoZSBmYXN0IHBhdGguDQoNClJlZ2FyZGluZyBkb2N1 bWVudGF0aW9uLCBpdCBtaWdodCBhbHNvIGJlIHdvcnRoIG1lbnRpb25pbmcgdGhhdCB0aGUgbS0+ bDJfbGVuLy4uLiBmaWVsZHMgYXJlIGRlc2NyaWJlZCBhcyAiZmllbGRzIHRvIHN1cHBvcnQgVFgg b2ZmbG9hZHMiIGluIHJ0ZV9tYnVmLmguIFNvIHdoZW4gUlggb2ZmbG9hZCBmZWF0dXJlcyAtIHN1 Y2ggYXMgR1JPIC0gcmVseSBvbiB0aGVzZSBmaWVsZHMsIHBlcmhhcHMgdGhlIGRlc2NyaXB0aW9u IGluIHJ0ZV9tYnVmLmggc2hvdWxkIGJlIHVwZGF0ZWQgYWNjb3JkaW5nbHkuDQoNCg0KTWVkIHZl bmxpZyBoaWxzZW4gLyBraW5kIHJlZ2FyZHMNCi0gTW9ydGVuIEJyw7hydXANCg0K