From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Andrew Rybchenko" <arybchenko@solarflare.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Rami Rosen" <roszenrami@gmail.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>, <dev@dpdk.org>,
<olivier.matz@6wind.com>, <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [RFC] function to parse packet headers
Date: Fri, 11 Jan 2019 09:16:50 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B425C9@smartserver.smartshare.dk> (raw)
In-Reply-To: <73285400-c67b-48cf-88be-b20bb05b5484@solarflare.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko
> On 1/11/19 3:11 AM, Stephen Hemminger wrote:
> >
> > All drivers that don't have hardware support for getting l2/l3 and
> > ptype information should be calling rte_net_get_ptype() already.
>
> Is it documented somewhere?
>
The drivers need to parse the packet headers to set MBUF->packet_type, and without hardware support for it, the alternative to calling rte_net_get_ptype() is implementing duplicate code in the driver.
In other words, you can interpret Stephen's "should be" as "would be silly if not". :-)
Med venlig hilsen / kind regards
- Morten Brørup
next prev parent reply other threads:[~2019-01-11 8:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 16:48 Morten Brørup
2019-01-08 20:09 ` Rami Rosen
2019-01-09 15:53 ` Morten Brørup
2019-01-09 23:57 ` Thomas Monjalon
2019-01-10 1:03 ` Rami Rosen
2019-01-11 0:11 ` Stephen Hemminger
2019-01-11 7:56 ` Andrew Rybchenko
2019-01-11 8:16 ` Morten Brørup [this message]
2019-01-11 8:28 ` Andrew Rybchenko
2019-01-11 8:35 ` Olivier Matz
2019-01-11 9:49 ` Ananyev, Konstantin
2019-01-11 12:04 ` Morten Brørup
2019-01-09 3:43 longtb5
2019-01-09 15:38 ` Morten Brørup
2019-01-10 3:25 ` longtb5
2019-01-10 8:21 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35B425C9@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=roszenrami@gmail.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).