From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
"Thomas Monjalon" <thomas@monjalon.net>
Cc: <checkpatch@dpdk.org>, <test-report@dpdk.org>, "dpdk-dev" <dev@dpdk.org>
Subject: Re: [dpdk-dev] |WARNING| pw59738 [PATCH v2 2/2] mbuf: add bulk free function
Date: Fri, 27 Sep 2019 08:42:32 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B42AD3@smartserver.smartshare.dk> (raw)
In-Reply-To: <20190925163701.78c09842@hermes.lan>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Thursday, September 26, 2019 1:37 AM
>
> On Wed, 25 Sep 2019 14:17:42 +0200
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > Dear Thomas - listed as checkpatch maintainer,
> >
> > I think this warning is bogus, and is a bug checkpatch.
> >
> > The line in question was deliberately indented using tabs to the
> current indentation level, and using spaces for the readability
> alignment. This makes the code readable in editors with another tab
> setting than 8 spaces. E.g. 4 spaces is my personal preference.
> >
> >
> > Med venlig hilsen / kind regards
> > - Morten Brørup
>
> It is understandable that you have personal preferences, but projects
> like DPDK rely
> on common style across all code. The collective decision has been made
> to keep a
> uniform style similar to the Linux kernel.
>
> No it is not a bug in checkpatch.
Thank you for the prompt feedback, Stephen.
I thought I could get the best of both worlds with this method of indentation. But since it's against the style guide, I'll change it to comply.
Med venlig hilsen / kind regards
- Morten Brørup
next prev parent reply other threads:[~2019-09-27 6:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:03 [dpdk-dev] [PATCH v2 0/2] " Morten Brørup
2019-09-25 12:03 ` [dpdk-dev] [PATCH v2 1/2] " Morten Brørup
2019-09-25 12:03 ` [dpdk-dev] [PATCH v2 2/2] " Morten Brørup
[not found] ` <20190925120542.A51B41BE84@dpdk.org>
2019-09-25 12:17 ` [dpdk-dev] |WARNING| pw59738 " Morten Brørup
2019-09-25 23:37 ` Stephen Hemminger
2019-09-27 6:42 ` Morten Brørup [this message]
2019-09-25 19:02 ` [dpdk-dev] " Mattias Rönnblom
2019-09-26 8:30 ` Bruce Richardson
2019-09-26 20:11 ` Mattias Rönnblom
2019-09-27 9:09 ` Bruce Richardson
2019-09-26 9:26 ` Andrew Rybchenko
2019-09-26 15:35 ` Morten Brørup
2019-09-26 10:23 ` Ananyev, Konstantin
2019-09-27 10:22 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35B42AD3@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=checkpatch@dpdk.org \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).