From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7250A04A4; Wed, 27 May 2020 09:45:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 860E11D5A7; Wed, 27 May 2020 09:45:56 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by dpdk.org (Postfix) with ESMTP id 30F211D443 for ; Wed, 27 May 2020 09:45:55 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Date: Wed, 27 May 2020 09:45:49 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C6100A@smartserver.smartshare.dk> In-Reply-To: <20200526191033.16459-3-i.dyukov@samsung.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [dpdk-dev] [PATCH v2 2/7] ethdev: add a link status textrepresentation Thread-Index: AdYzkWzcjE//LeqfSNW5Tf3nI86S6wAZDLIg References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> <20200526191033.16459-3-i.dyukov@samsung.com> From: =?UTF-8?B?TW9ydGVuIEJyw7hydXA=?= To: Cc: , , , , , , , , , , Subject: Re: [dpdk-dev] [PATCH v2 2/7] ethdev: add a link status textrepresentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PiBGcm9tOiBkZXYgW21haWx0bzpkZXYtYm91bmNlc0BkcGRrLm9yZ10gT24gQmVoYWxmIE9mIEl2 YW4gRHl1a292DQo+IFNlbnQ6IFR1ZXNkYXksIE1heSAyNiwgMjAyMCA5OjEwIFBNDQo+IA0KPiBU aGlzIGNvbW1pdCBhZGQgZnVuY3Rpb24gd2hpY2ggdHJlYXQgbGluayBzdGF0dXMgc3RydWN0dXJl DQo+IGFuZCBmb3JtYXQgaXQgdG8gdGV4dCByZXByZXNlbnRhdGlvbi4NCj4gDQo+IFNpZ25lZC1v ZmYtYnk6IEl2YW4gRHl1a292IDxpLmR5dWtvdkBzYW1zdW5nLmNvbT4NCj4gLS0tDQo+ICBsaWIv bGlicnRlX2V0aGRldi9ydGVfZXRoZGV2LmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrDQo+ICBsaWIvbGlicnRlX2V0aGRldi9ydGVfZXRoZGV2LmggfCAzMSArKysrKysr KysrKysrKysrKysrKysrKysrKysNCj4gIDIgZmlsZXMgY2hhbmdlZCwgNzAgaW5zZXJ0aW9ucygr KQ0KPiANCj4gZGlmZiAtLWdpdCBhL2xpYi9saWJydGVfZXRoZGV2L3J0ZV9ldGhkZXYuYw0KPiBi L2xpYi9saWJydGVfZXRoZGV2L3J0ZV9ldGhkZXYuYw0KPiBpbmRleCA4ZTEwYTZmYzMuLjhkNzVj MjQ0MCAxMDA2NDQNCj4gLS0tIGEvbGliL2xpYnJ0ZV9ldGhkZXYvcnRlX2V0aGRldi5jDQo+ICsr KyBiL2xpYi9saWJydGVfZXRoZGV2L3J0ZV9ldGhkZXYuYw0KPiBAQCAtMjM4NSw2ICsyMzg1LDQ1 IEBAIHJ0ZV9ldGhfbGlua19nZXRfbm93YWl0KHVpbnQxNl90IHBvcnRfaWQsIHN0cnVjdA0KPiBy dGVfZXRoX2xpbmsgKmV0aF9saW5rKQ0KPiAgCXJldHVybiAwOw0KPiAgfQ0KPiANCj4gK3ZvaWQN Cj4gK3J0ZV9ldGhfbGlua19wcmVwYXJlX3RleHQoc3RydWN0IHJ0ZV9ldGhfbGluayAqZXRoX2xp bmssIHVpbnQzMl90DQo+IHNwZWVkX3VuaXQsDQo+ICsJCQkgIHN0cnVjdCBydGVfZXRoX2xpbmtf dGV4dCAqbGlua190ZXh0KQ0KPiArew0KPiArCXVpbnQzMl90IGxpbmtfc3BlZWQgPSAwOw0KPiAr CS8qIHByZXBhcmUgbGluayBzcGVlZCAqLw0KPiArCWlmIChldGhfbGluay0+bGlua19zcGVlZCA9 PSBFVEhfU1BFRURfTlVNX1VOS05PV04pDQo+ICsJCW1lbWNweShsaW5rX3RleHQtPmxpbmtfc3Bl ZWQsICJ1bmtub3duIiwNCj4gc2l6ZW9mKCJ1bmtub3duIikpOw0KPiArCWVsc2Ugew0KPiArCQlp ZiAoc3BlZWRfdW5pdCA9PSBFVEhfU1BFRURfVU5JVF9HQlBTKQ0KPiArCQkJbGlua19zcGVlZCA9 IGV0aF9saW5rLT5saW5rX3NwZWVkIC8gMTAwMDsNCj4gKwkJZWxzZQ0KPiArCQkJbGlua19zcGVl ZCA9IGV0aF9saW5rLT5saW5rX3NwZWVkOw0KPiArCQlzbnByaW50ZihsaW5rX3RleHQtPmxpbmtf c3BlZWQsIHNpemVvZihsaW5rX3RleHQtDQo+ID5saW5rX3NwZWVkKSwNCj4gKwkJCSAiJXUiLCBs aW5rX3NwZWVkKTsNCj4gKwl9DQo+ICsJLyogcHJlcGFyZSBsaW5rIGR1cGxleCAqLw0KPiArCWlm IChldGhfbGluay0+bGlua19kdXBsZXggPT0gRVRIX0xJTktfRlVMTF9EVVBMRVgpDQo+ICsJCW1l bWNweShsaW5rX3RleHQtPmxpbmtfZHVwbGV4LCAiZnVsbC1kdXBsZXgiLA0KPiArCQkJc2l6ZW9m KCJmdWxsLWR1cGxleCIpKTsNCj4gKwllbHNlDQo+ICsJCW1lbWNweShsaW5rX3RleHQtPmxpbmtf ZHVwbGV4LCAiaGFsZi1kdXBsZXgiLA0KPiArCQkJc2l6ZW9mKCJoYWxmLWR1cGxleCIpKTsNCj4g KwkvKiBwcmVwYXJlIGF1dG9uZWcgKi8NCj4gKwlpZiAoZXRoX2xpbmstPmxpbmtfYXV0b25lZyA9 PSBFVEhfTElOS19BVVRPTkVHKQ0KPiArCQltZW1jcHkobGlua190ZXh0LT5saW5rX2F1dG9uZWcs ICJhdXRvbmVnIiwNCj4gKwkJCXNpemVvZigiYXV0b25lZyIpKTsNCj4gKwllbHNlDQo+ICsJCW1l bWNweShsaW5rX3RleHQtPmxpbmtfYXV0b25lZywgImZpeGVkIiwNCj4gKwkJCXNpemVvZigiZml4 ZWQiKSk7DQo+ICsJLyogcHJlcGFyZSBzdGF0dXMgKi8NCj4gKwlpZiAoZXRoX2xpbmstPmxpbmtf c3RhdHVzID09IEVUSF9MSU5LX0RPV04pDQo+ICsJCW1lbWNweShsaW5rX3RleHQtPmxpbmtfc3Rh dHVzLCAiZG93biIsDQo+ICsJCQlzaXplb2YoImRvd24iKSk7DQo+ICsJZWxzZQ0KPiArCQltZW1j cHkobGlua190ZXh0LT5saW5rX3N0YXR1cywgInVwIiwNCj4gKwkJCXNpemVvZigidXAiKSk7DQo+ ICt9DQo+ICsNCj4gIGludA0KPiAgcnRlX2V0aF9zdGF0c19nZXQodWludDE2X3QgcG9ydF9pZCwg c3RydWN0IHJ0ZV9ldGhfc3RhdHMgKnN0YXRzKQ0KPiAgew0KPiBkaWZmIC0tZ2l0IGEvbGliL2xp YnJ0ZV9ldGhkZXYvcnRlX2V0aGRldi5oDQo+IGIvbGliL2xpYnJ0ZV9ldGhkZXYvcnRlX2V0aGRl di5oDQo+IGluZGV4IDIwOTBhZjUwMS4uNTNkMmYwYzc4IDEwMDY0NA0KPiAtLS0gYS9saWIvbGli cnRlX2V0aGRldi9ydGVfZXRoZGV2LmgNCj4gKysrIGIvbGliL2xpYnJ0ZV9ldGhkZXYvcnRlX2V0 aGRldi5oDQo+IEBAIC0zMTYsNiArMzE2LDE5IEBAIHN0cnVjdCBydGVfZXRoX2xpbmsgew0KPiAg CXVpbnQxNl90IGxpbmtfc3RhdHVzICA6IDE7ICAvKio8IEVUSF9MSU5LX1tET1dOL1VQXSAqLw0K PiAgfSBfX3J0ZV9hbGlnbmVkKDgpOyAgICAgIC8qKjwgYWxpZ25lZCBmb3IgYXRvbWljNjQgcmVh ZC93cml0ZSAqLw0KPiANCj4gKy8qKg0KPiArICogTGluayBzcGVlZCB1bml0cw0KPiArICovDQo+ ICsjZGVmaW5lIEVUSF9TUEVFRF9VTklUX0dCUFMgMA0KPiArI2RlZmluZSBFVEhfU1BFRURfVU5J VF9NQlBTIDENCj4gKw0KPiArDQo+ICtzdHJ1Y3QgcnRlX2V0aF9saW5rX3RleHQgew0KPiArCWNo YXIgbGlua19zcGVlZFsxNF07ICAvKiogbGluayBzcGVlZCAqLw0KPiArCWNoYXIgbGlua19kdXBs ZXhbMTJdOyAgLyoqIGZ1bGwtZHVwbGV4IG9yIGhhbGYtZHVwbGV4ICovDQo+ICsJY2hhciBsaW5r X2F1dG9uZWdbOF07ICAvKiogYXV0b25lZyBvciBmaXhlZCAqLw0KPiArCWNoYXIgbGlua19zdGF0 dXNbNV07ICAvKiogZG93biBvciB1cCAqLw0KPiArfTsNCj4gIC8qIFV0aWxpdHkgY29uc3RhbnRz ICovDQo+ICAjZGVmaW5lIEVUSF9MSU5LX0hBTEZfRFVQTEVYIDAgLyoqPCBIYWxmLWR1cGxleCBj b25uZWN0aW9uIChzZWUNCj4gbGlua19kdXBsZXgpLiAqLw0KPiAgI2RlZmluZSBFVEhfTElOS19G VUxMX0RVUExFWCAxIC8qKjwgRnVsbC1kdXBsZXggY29ubmVjdGlvbiAoc2VlDQo+IGxpbmtfZHVw bGV4KS4gKi8NCj4gQEAgLTIyOTUsNiArMjMwOCwyNCBAQCBpbnQgcnRlX2V0aF9saW5rX2dldCh1 aW50MTZfdCBwb3J0X2lkLCBzdHJ1Y3QNCj4gcnRlX2V0aF9saW5rICpsaW5rKTsNCj4gICAqLw0K PiAgaW50IHJ0ZV9ldGhfbGlua19nZXRfbm93YWl0KHVpbnQxNl90IHBvcnRfaWQsIHN0cnVjdCBy dGVfZXRoX2xpbmsNCj4gKmxpbmspOw0KPiANCj4gKy8qKg0KPiArICogRm9ybWF0IGxpbmsgc3Rh dHVzIHRvIHRleHR1YWwgcmVwcmVzZW50YXRpb24uIHNwZWVkX3VuaXQgaXMgdXNlZCB0bw0KPiBj b252ZXJ0DQo+ICsgKiBsaW5rX3NwZWVkIHRvIHNwZWNpZmllZCB1bml0LiBBbHNvIHRoaXMgZnVu Y3Rpb24gdGhyZWF0cyBhIHNwZWNpYWwNCj4gKyAqIEVUSF9TUEVFRF9OVU1fVU5LTk9XTiB2YWx1 ZSBvZiBsaW5rX3NwZWVkIGFuZCByZXR1cm4gJ1VOS05PV04nDQo+IHNwZWVkDQo+ICsgKiBpbiB0 aGlzIGNhc2UuDQo+ICsgKg0KPiArICogQHBhcmFtIGxpbmsNCj4gKyAqICAgTGluayBzdGF0dXMg cHJvdmlkZWQgYnkgcnRlX2V0aF9saW5rX2dldCBmdW5jdGlvbg0KPiArICogQHBhcmFtIHNwZWVk X3VuaXQNCj4gKyAqICAgVGFyZ2V0IHVuaXRzIGZvciB0aGUgc3BlZWQuIEZvbGxvd2luZyB2YWx1 ZXMgYXJlIGF2YWlsYWJsZToNCj4gKyAqICAgIC0gRVRIX1NQRUVEX1VOSVRfR0JQUw0KPiArICog ICAgLSBFVEhfU1BFRURfVU5JVF9NQlBTDQo+ICsgKiBAcGFyYW0gbGlua190ZXh0DQo+ICsgKiAg IEEgcG9pbnRlciB0byBhbiAqcnRlX2V0aF9saW5rX3RleHQqIHN0cnVjdHVyZSB0byBiZSBmaWxs ZWQgd2l0aA0KPiArICogICB0ZXh0dWFsIHJlcHJlc2VudGF0aW9uIG9mIGRldmljZSBzdGF0dXMN Cj4gKyAqLw0KPiArdm9pZCBydGVfZXRoX2xpbmtfcHJlcGFyZV90ZXh0KHN0cnVjdCBydGVfZXRo X2xpbmsgKmxpbmssIHVpbnQzMl90DQo+IHNwZWVkX3VuaXQsDQo+ICsJCQkJc3RydWN0IHJ0ZV9l dGhfbGlua190ZXh0ICpsaW5rX3RleHQpOw0KPiAgLyoqDQo+ICAgKiBSZXRyaWV2ZSB0aGUgZ2Vu ZXJhbCBJL08gc3RhdGlzdGljcyBvZiBhbiBFdGhlcm5ldCBkZXZpY2UuDQo+ICAgKg0KPiAtLQ0K PiAyLjE3LjENCj4gDQoNCkNvbnNpZGVyaW5nIHRoYXQgdGhpcyBmdW5jdGlvbiB3aWxsIG9ubHkg YmUgdXNlZCBieSBhcHBsaWNhdGlvbnMgdGhhdCBkb24ndCBuZWVkIHRvIGZvbGxvdyBhIHZlbmRv ci1zcGVjaWZpYyB0ZXh0dWFsIGZvcm1hdCBmb3IgdGhlaXIgbGluayBzdGF0dXMsIHlvdSBjYW4g Y2hvb3NlIHlvdXIgb3duIHRleHQgZm9ybWF0LCBhbmQgZG9uJ3QgbmVlZCB0aGUgc3RydWN0IGZv ciB0aGUgdGV4dCBzdHJpbmdzLiBUaGUgZnVuY3Rpb24gY2FuIHNpbXBseSB3cml0ZSB0aGUgZW50 aXJlIGluZm9ybWF0aW9uIGludG8gYSBzaW5nbGUgc3RyaW5nLiBJdCBhbHNvIG1ha2VzIHNwZWVk X3VuaXQgc3VwZXJmbHVvdXMuIEUuZy4gbGlrZSB0aGlzOg0KDQp2b2lkIHJ0ZV9ldGhfbGlua19w cmVwYXJlX3RleHQoY2hhciAqc3RyLCBjb25zdCBzdHJ1Y3QgcnRlX2V0aF9saW5rICpjb25zdCBs aW5rKQ0Kew0KICAgIGlmIChsaW5rLmxpbmtfc3RhdHVzID09IEVUSF9MSU5LX0RPV04pIHsNCiAg ICAgICAgc3RyICs9IHNwcmludGYoc3RyLCAiTGluayBkb3duIik7DQogICAgfSBlbHNlIHsNCiAg ICAgICAgc3RyICs9IHNwcmludGYoc3RyLCAiTGluayB1cCBhdCAiKTsNCiAgICAgICAgaWYgKGxp bmsubGlua19zcGVlZCA9PSBFVEhfU1BFRURfTlVNX1VOS05PV04pIHsNCiAgICAgICAgICAgIHN0 ciArPSBzcHJpbnRmKCJVbmtub3duIHNwZWVkIik7DQogICAgICAgIH0gZWxzZSB7DQogICAgICAg ICAgICBpZiAobGluay5saW5rX3NwZWVkIDwgRVRIX1NQRUVEX05VTV8xRykNCiAgICAgICAgICAg ICAgICBzdHIgKz0gc3ByaW50ZihzdHIsICIldSBNYml0L3MiLCBsaW5rLmxpbmtfc3BlZWQpOw0K ICAgICAgICAgICAgZWxzZSBpZiAobGluay5saW5rX3NwZWVkID09IEVUSF9TUEVFRF9OVU1fMl81 RykNCiAgICAgICAgICAgICAgICBzdHIgKz0gc3ByaW50ZihzdHIsICIyLjUgR2JpdC9zIik7DQog ICAgICAgICAgICBlbHNlDQogICAgICAgICAgICAgICAgc3RyICs9IHNwcmludGYoc3RyLCAiJXUg R2JpdC9zIiwgbGluay5saW5rX3NwZWVkIC8gMTAwMCk7DQogICAgICAgICAgICBzdHIgKz0gc3By aW50ZihzdHIsICIgJWNEWCIsIGxpbmsubGlua19kdXBsZXggPyAnRicgOiAnSCcpOw0KICAgICAg ICAgICAgc3RyICs9IHNwcmludGYoc3RyLCAiICVzIiwgbGluay5saW5rX2F1dG9uZWcgPyAiQXV0 b25lZyIgOiAiRml4ZWQiKTsNCiAgICAgICAgfQ0KICAgIH0NCn0NCg0KDQpBbmQgaWYgRFBESyBh bHJlYWR5IGhhcyBhbiBlc3RhYmxpc2hlZCBzdHlsZSBmb3IgImNvbnZlcnQgaW5mb3JtYXRpb24g dG8gaHVtYW4gcmVhZGFibGUgdGV4dCIgZnVuY3Rpb25zIHJlZ2FyZGluZyBmdW5jdGlvbiBuYW1l IGFuZCBwYXJhbWV0ZXIgb3JkZXIsIHRoZSBmdW5jdGlvbiBzaG91bGQgZm9sbG93IHN1Y2ggc3R5 bGUuDQoNCg0KTWVkIHZlbmxpZyBoaWxzZW4gLyBraW5kIHJlZ2FyZHMNCi0gTW9ydGVuIEJyw7hy dXANCg0K