From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Jeff Guo" <jia.guo@intel.com>, "Beilei Xing" <beilei.xing@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] i40e_rxtx_vec_avx2 code review
Date: Mon, 31 Aug 2020 08:50:18 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C6126D@smartserver.smartshare.dk> (raw)
In-Reply-To: <aa6fc5b6-65c7-d947-cf42-50e2f058a70c@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jeff Guo
> Sent: Monday, August 31, 2020 8:30 AM
>
> hi, mb
>
> Seems that there are a referring issue here which you have found, i
> think we need to fix it, if there are on objection i will add that fix
> into the prior burst fixing patch, thanks very much.
I don't object if you put it in the same patch. I can't speak on behalf of others, though.
-Morten
>
> On 8/29/2020 3:21 PM, Morten Brørup wrote:
> > Jeff, Beilei,
> >
> > Looking closer at i40e_rxtx_vec_avx2.c, I noticed:
> > 1. i40e_rxq_rearm() uses RTE_I40E_DESCS_PER_LOOP, while all other
> functions in the file use RTE_I40E_DESCS_PER_LOOP_AVX. It may be
> correct, but please check.
> > 2. The function descriptions of i40e_recv_pkts_vec_avx2(),
> i40e_recv_scattered_burst_vec_avx2() and
> i40e_recv_scattered_pkts_vec_avx2() refer to RTE_I40E_DESCS_PER_LOOP,
> but they should be referring to RTE_I40E_DESCS_PER_LOOP_AVX.
> > 3. RTE_I40E_DESCS_PER_LOOP_AVX is defined in the file, unlike
> RTE_I40E_DESCS_PER_LOOP, which is defined in the i40e_rxtx.h header
> file. Your choice, just mentioning it.
> >
> >
> > Med venlig hilsen / kind regards
> > - Morten Brørup
> >
prev parent reply other threads:[~2020-08-31 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 7:21 Morten Brørup
2020-08-31 6:30 ` Jeff Guo
2020-08-31 6:50 ` Morten Brørup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35C6126D@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).