Re: [dpdk-dev] [PATCH] ethdev: use rte_pktmbuf_free_bulk()

["Morten Brørup" <mb@smartsharesystems.com>]

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, September 30, 2020 11:27 PM
> 
> The mbuf library now has routine to free multiple buffers.
> Loop is no longer needed.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_ethdev/rte_ethdev.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c
> b/lib/librte_ethdev/rte_ethdev.c
> index dfe5c1b488a0..307fbeb3a798 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -2179,10 +2179,7 @@ void
>  rte_eth_tx_buffer_drop_callback(struct rte_mbuf **pkts, uint16_t
> unsent,
>  		void *userdata __rte_unused)
>  {
> -	unsigned i;
> -
> -	for (i = 0; i < unsent; i++)
> -		rte_pktmbuf_free(pkts[i]);
> +	rte_pktmbuf_free_bulk(pkts, unsent);
>  }
> 
>  void
> @@ -2190,11 +2187,8 @@ rte_eth_tx_buffer_count_callback(struct rte_mbuf
> **pkts, uint16_t unsent,
>  		void *userdata)
>  {
>  	uint64_t *count = userdata;
> -	unsigned i;
> -
> -	for (i = 0; i < unsent; i++)
> -		rte_pktmbuf_free(pkts[i]);
> 
> +	rte_pktmbuf_free_bulk(pkts, unsent);
>  	*count += unsent;
>  }
> 
> --
> 2.27.0
> 

Reviewed-by: Morten Brørup <mb@smartsharesystems.com>