DPDK patches and discussions
 help / color / mirror / Atom feed
From: Morten Brørup <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
	<jgrajcia@cisco.com>, <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>
Subject: RE: [PATCH] net/memif: remove unnecessary rx_intr stub
Date: Sat, 15 Jan 2022 09:15:31 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86E07@smartserver.smartshare.dk> (raw)
In-Reply-To: <20220114204644.351712-1-stephen@networkplumber.org>

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, 14 January 2022 21.47
> 
> The code in memif driver to stub out rx_irq_enable is unnecessary
> and causes different error returns than other drivers.
> The core ethdev code will return -ENOTSUP if the driver has
> a null rx_queue_intr_enable callback.
> 
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> Cc: jgrajcia@cisco.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/memif/rte_eth_memif.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/net/memif/rte_eth_memif.c
> b/drivers/net/memif/rte_eth_memif.c
> index 59cb5a82a23f..d3459c5007c4 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev)
>  	return 0;
>  }
> 
> -static int
> -memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused,
> -			   uint16_t qid __rte_unused)
> -{
> -	MIF_LOG(WARNING, "Interrupt mode not supported.");
> -
> -	return -1;
> -}
> -
> -static int
> -memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid
> __rte_unused)
> -{
> -	struct pmd_internals *pmd __rte_unused = dev->data->dev_private;
> -
> -	return 0;
> -}
> -
>  static const struct eth_dev_ops ops = {
>  	.dev_start = memif_dev_start,
>  	.dev_stop = memif_dev_stop,
> @@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops = {
>  	.rx_queue_setup = memif_rx_queue_setup,
>  	.rx_queue_release = memif_rx_queue_release,
>  	.tx_queue_release = memif_tx_queue_release,
> -	.rx_queue_intr_enable = memif_rx_queue_intr_enable,
> -	.rx_queue_intr_disable = memif_rx_queue_intr_disable,
>  	.link_update = memif_link_update,
>  	.stats_get = memif_stats_get,
>  	.stats_reset = memif_stats_reset,
> --
> 2.30.2
> 

Acked-by: Morten Brørup <mb@smartsharesystems.com>


  reply	other threads:[~2022-01-15  8:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 20:46 Stephen Hemminger
2022-01-15  8:15 ` Morten Brørup [this message]
2022-01-26 14:24   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D86E07@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jgrajcia@cisco.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git