From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05FF6A0093; Sat, 15 Jan 2022 09:15:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F1E141163; Sat, 15 Jan 2022 09:15:35 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 080A0406A2 for ; Sat, 15 Jan 2022 09:15:33 +0100 (CET) Subject: RE: [PATCH] net/memif: remove unnecessary rx_intr stub Date: Sat, 15 Jan 2022 09:15:31 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86E07@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220114204644.351712-1-stephen@networkplumber.org> X-MS-Has-Attach: Content-class: urn:content-classes:message X-MS-TNEF-Correlator: Thread-Topic: [PATCH] net/memif: remove unnecessary rx_intr stub Thread-Index: AdgJ5UdleXt/yhLgTQakNl/dl7WjLQAAr58g References: <20220114204644.351712-1-stephen@networkplumber.org> From: =?iso-8859-1?Q?Morten_Br=F8rup?= X-MimeOLE: Produced By Microsoft Exchange V6.5 To: "Stephen Hemminger" , , Cc: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, 14 January 2022 21.47 >=20 > The code in memif driver to stub out rx_irq_enable is unnecessary > and causes different error returns than other drivers. > The core ethdev code will return -ENOTSUP if the driver has > a null rx_queue_intr_enable callback. >=20 > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") > Cc: jgrajcia@cisco.com > Signed-off-by: Stephen Hemminger > --- > drivers/net/memif/rte_eth_memif.c | 19 ------------------- > 1 file changed, 19 deletions(-) >=20 > diff --git a/drivers/net/memif/rte_eth_memif.c > b/drivers/net/memif/rte_eth_memif.c > index 59cb5a82a23f..d3459c5007c4 100644 > --- a/drivers/net/memif/rte_eth_memif.c > +++ b/drivers/net/memif/rte_eth_memif.c > @@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev) > return 0; > } >=20 > -static int > -memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused, > - uint16_t qid __rte_unused) > -{ > - MIF_LOG(WARNING, "Interrupt mode not supported."); > - > - return -1; > -} > - > -static int > -memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid > __rte_unused) > -{ > - struct pmd_internals *pmd __rte_unused =3D dev->data->dev_private; > - > - return 0; > -} > - > static const struct eth_dev_ops ops =3D { > .dev_start =3D memif_dev_start, > .dev_stop =3D memif_dev_stop, > @@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops =3D { > .rx_queue_setup =3D memif_rx_queue_setup, > .rx_queue_release =3D memif_rx_queue_release, > .tx_queue_release =3D memif_tx_queue_release, > - .rx_queue_intr_enable =3D memif_rx_queue_intr_enable, > - .rx_queue_intr_disable =3D memif_rx_queue_intr_disable, > .link_update =3D memif_link_update, > .stats_get =3D memif_stats_get, > .stats_reset =3D memif_stats_reset, > -- > 2.30.2 >=20 Acked-by: Morten Br=F8rup