From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: "Olivier Matz" <olivier.matz@6wind.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Subject: RE: [PATCH] build: make ring mempool driver mandatory
Date: Tue, 15 Feb 2022 10:25:53 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86EA8@smartserver.smartshare.dk> (raw)
In-Reply-To: <20220214153038.367923-1-bruce.richardson@intel.com>
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Monday, 14 February 2022 16.31
>
> The default mempool driver is one based on the rte_ring, and as such it
> needs to be present to have just about any app (which doesn't override
> the mempool) run. Given this state of affairs it is probably best to
> add
> this default mempool driver to the always-enabled list to ensure we get
> a runnable build in all cases. This means that, for example, to run
> some
> NIC tests with testpmd in a minimal build, in most cases, all the user
> should need to do is specify "-Denable_drivers=net/<nic_drv>" for the
> build.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/meson.build b/drivers/meson.build
> index d5f4e1c1f2..1d8123b00c 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -40,6 +40,8 @@ endif
>
> # these drivers must always be enabled, otherwise the build breaks
> always_enable = ['bus/pci', 'bus/vdev']
> +# we always need a mempool driver, and ring is default, so make it
> mandatory
> +always_enable += ['mempool/ring']
> enable_drivers += always_enable
>
> default_cflags = machine_args
> --
> 2.32.0
>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2022-02-15 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 15:30 Bruce Richardson
2022-02-15 9:25 ` Morten Brørup [this message]
2022-02-22 14:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D86EA8@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).