From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 29765A00C5;
	Tue, 15 Feb 2022 10:25:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A77F3410F3;
	Tue, 15 Feb 2022 10:25:58 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 3249040E78
 for <dev@dpdk.org>; Tue, 15 Feb 2022 10:25:57 +0100 (CET)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH] build: make ring mempool driver mandatory
Date: Tue, 15 Feb 2022 10:25:53 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86EA8@smartserver.smartshare.dk>
In-Reply-To: <20220214153038.367923-1-bruce.richardson@intel.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH] build: make ring mempool driver mandatory
Thread-Index: Adght/Hie45q2mYwT8WSVxALWb8qywAlgjnQ
References: <20220214153038.367923-1-bruce.richardson@intel.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>,
	<dev@dpdk.org>
Cc: "Olivier Matz" <olivier.matz@6wind.com>,
 "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Monday, 14 February 2022 16.31
>=20
> The default mempool driver is one based on the rte_ring, and as such =
it
> needs to be present to have just about any app (which doesn't override
> the mempool) run. Given this state of affairs it is probably best to
> add
> this default mempool driver to the always-enabled list to ensure we =
get
> a runnable build in all cases. This means that, for example, to run
> some
> NIC tests with testpmd in a minimal build, in most cases, all the user
> should need to do is specify "-Denable_drivers=3Dnet/<nic_drv>" for =
the
> build.
>=20
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  drivers/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/meson.build b/drivers/meson.build
> index d5f4e1c1f2..1d8123b00c 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -40,6 +40,8 @@ endif
>=20
>  # these drivers must always be enabled, otherwise the build breaks
>  always_enable =3D ['bus/pci', 'bus/vdev']
> +# we always need a mempool driver, and ring is default, so make it
> mandatory
> +always_enable +=3D ['mempool/ring']
>  enable_drivers +=3D always_enable
>=20
>  default_cflags =3D machine_args
> --
> 2.32.0
>=20

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>