From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: RE: [RFC 0/2] Eliminate zero length arrays in DPDK
Date: Wed, 16 Feb 2022 10:27:58 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86EAF@smartserver.smartshare.dk> (raw)
In-Reply-To: <20220215230058.64760-1-stephen@networkplumber.org>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, 16 February 2022 00.01
>
> Yet another case of applying Linux kernel best practices
> to DPDK. Flexible arrays are supported by Clang, GCC and
> Microsoft compilers (part of C99).
>
> Stephen Hemminger (2):
> devtools: add script to check for zero length array
> treewide: replace zero-length array with flex array
>
> app/test/test_table_tables.c | 2 +-
> devtools/cocci/zerolengtharray.cocci | 17 +++++++++++++++++
> drivers/bus/dpaa/include/netcfg.h | 4 ++--
> drivers/common/cnxk/roc_se.h | 2 +-
> drivers/common/dpaax/caamflib/desc/ipsec.h | 2 +-
> drivers/common/dpaax/dpaax_iova_table.h | 2 +-
> drivers/common/mlx5/mlx5_prm.h | 8 ++++----
> drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 2 +-
> drivers/crypto/ipsec_mb/ipsec_mb_private.h | 4 ++--
> drivers/crypto/virtio/virtio_ring.h | 4 ++--
> drivers/crypto/virtio/virtqueue.h | 2 +-
> drivers/net/cxgbe/clip_tbl.h | 2 +-
> drivers/net/cxgbe/l2t.h | 2 +-
> drivers/net/cxgbe/mps_tcam.h | 2 +-
> drivers/net/cxgbe/smt.h | 2 +-
> drivers/net/enic/base/vnic_devcmd.h | 4 ++--
> drivers/net/hinic/hinic_pmd_tx.h | 2 +-
> drivers/net/nfp/nfpcore/nfp_nsp.h | 2 +-
> drivers/net/virtio/virtio_ring.h | 4 ++--
> drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +-
> drivers/net/virtio/virtio_user/vhost_vdpa.c | 2 +-
> drivers/net/virtio/virtqueue.h | 2 +-
> drivers/regex/mlx5/mlx5_rxp.h | 2 +-
> examples/ip_reassembly/main.c | 2 +-
> lib/cryptodev/cryptodev_pmd.h | 2 +-
> lib/cryptodev/rte_cryptodev.h | 2 +-
> lib/ip_frag/ip_reassembly.h | 2 +-
> lib/ipsec/sa.h | 2 +-
> lib/rib/rte_rib.c | 2 +-
> lib/rib/rte_rib6.c | 2 +-
> lib/table/rte_swx_table_learner.c | 2 +-
> lib/table/rte_table_hash_key16.c | 4 ++--
> lib/table/rte_table_hash_key32.c | 4 ++--
> lib/table/rte_table_hash_key8.c | 4 ++--
> lib/vhost/rte_vhost.h | 4 ++--
> 35 files changed, 63 insertions(+), 46 deletions(-)
> create mode 100644 devtools/cocci/zerolengtharray.cocci
>
> --
> 2.34.1
Thank you! We must all appreciate the DPDK housekeeping efforts, where it DPDK gets some real love, and not just added support for new bells and whistles in fancy NICs. :-)
Series-Acked-By: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2022-02-16 9:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 23:00 Stephen Hemminger
2022-02-15 23:00 ` [RFC 1/2] devtools: add script to check for zero length array Stephen Hemminger
2022-02-15 23:00 ` [RFC 2/2] treewide: replace zero-length array with flex array Stephen Hemminger
2022-02-16 9:27 ` Morten Brørup [this message]
2022-02-16 9:33 ` [RFC 0/2] Eliminate zero length arrays in DPDK Bruce Richardson
2022-02-16 10:05 ` Morten Brørup
2022-02-16 10:10 ` Bruce Richardson
2022-02-17 7:41 ` Tyler Retzlaff
2022-02-24 21:51 ` Morten Brørup
2022-02-24 23:03 ` Stephen Hemminger
2022-02-16 18:56 ` Stephen Hemminger
2022-02-17 8:09 ` Tyler Retzlaff
2022-02-16 10:39 Morten Brørup
2022-02-17 8:32 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D86EAF@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).