DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Jiang, YuX" <yux.jiang@intel.com>, <bugzilla@dpdk.org>, <dev@dpdk.org>
Subject: RE: [Bug 937] [dpdk-22.03] unit_tests_mempool/test_mempool_perf: timeout on mempool_perf_autotest
Date: Fri, 18 Feb 2022 09:10:20 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86EBC@smartserver.smartshare.dk> (raw)
In-Reply-To: <BYAPR11MB27117AECC9200C57E62F0037FE369@BYAPR11MB2711.namprd11.prod.outlook.com>

> From: Jiang, YuX [mailto:yux.jiang@intel.com]
> Sent: Thursday, 17 February 2022 11.31
> 
> > From: Morten Brørup <mb@smartsharesystems.com>
> > Sent: Thursday, February 17, 2022 6:16 PM
> >
> > > From: bugzilla@dpdk.org [mailto:bugzilla@dpdk.org]
> > > Sent: Thursday, 17 February 2022 10.11
> > >
> > > https://bugs.dpdk.org/show_bug.cgi?id=937
> > >
> >
> > [...]
> >
> >
> > >
> > > dpdk-22.03-rc1: 2e07139b66a810883871ff20a5f31e4c222e5b40
> > >
> > > Reproduce Step:
> > >
> > > 1.launch dpdk-test
> > > x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1-111 -n 4 2.
> > > RTE>>mempool_perf_autotest
> > >
> > > Expect results: mempool_perf_autotest timeout in 2000s.
> > >
> > > Actual results: mempool_perf_autotest need run 1 or more hours.
> > >
> > > Is this issue a regression: Y
> > > Version the regression was introduced: Specify git id if known.
> > >  First bad commit:ed579e50c66db90485593c6c79f5366a57145f2a
> > > Author: Morten Brørup <mb@smartsharesystems.com>
> > > Date: Mon Jan 24 15:59:53 2022 +0100
> > >
> > > mempool: test performance with constant n
> > >
> > > "What gets measured gets done."
> > >
> > > This patch adds mempool performance tests where the number of
> objects
> > > to put and get is constant at compile time, which may significantly
> > > improve the performance of these functions. [*]
> > >
> > > Also, it is ensured that the array holding the object used for
> testing
> > > is cache line aligned, for maximum performance.
> > >
> > > And finally, the following entries are added to the list of tests:
> > > - Number of kept objects: 512
> > > - Number of objects to get and to put: The number of pointers
> fitting
> > > into a cache line, i.e. 8 or 16
> > >
> >
> > A few more test cases were added, and each test is now run in two
> variants,
> > one variant with variable N, and one variant with constant N.
> >
> > To reduce the very long test running time, we could consider removing
> some
> > of the tests. However, a few undocumented magic numbers are used
> > throughout DPDK, e.g. a burst size of 32. These magic numbers do not
> have
> > names, but are just used numerically. So I am not sure if we can
> safely
> > remove the tests with burst size 4 and/or 128 kept objects. E.g. I
> suspect that
> > 4 could be a magic number in some NIC drivers, and thus still
> relevant to test.
> >
> >
> Do you mean that this is normal behavior due to this merged patch? How
> long this mempool_perf_autotest will take? 1 more hours or several
> hours?

It was running for 2-3 hours on our server.

-Morten


  reply	other threads:[~2022-02-18  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17  9:10 bugzilla
2022-02-17 10:15 ` Morten Brørup
2022-02-17 10:30   ` Jiang, YuX
2022-02-18  8:10     ` Morten Brørup [this message]
2022-02-18  9:51       ` Jiang, YuX
2022-02-18  9:53         ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D86EBC@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=yux.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).