From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3874AA0503;
	Wed, 23 Mar 2022 13:01:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 08CD2427F6;
	Wed, 23 Mar 2022 13:01:58 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 3981341140
 for <dev@dpdk.org>; Wed, 23 Mar 2022 13:01:57 +0100 (CET)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH] eal: factorize lcore main loop
Date: Wed, 23 Mar 2022 13:01:52 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86F62@smartserver.smartshare.dk>
In-Reply-To: <20220323093001.20618-1-david.marchand@redhat.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH] eal: factorize lcore main loop
Thread-Index: Adg+mKKQPygtpcf0SI+q8cXUvmYwVwAFLKLQ
References: <20220323093001.20618-1-david.marchand@redhat.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>,
	<dev@dpdk.org>
Cc: <thomas@monjalon.net>, "Bruce Richardson" <bruce.richardson@intel.com>,
 "Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>,
 "Narcisa Ana Maria Vasile" <navasile@linux.microsoft.com>,
 "Dmitry Malloy" <dmitrym@microsoft.com>,
 "Pallavi Kadam" <pallavi.kadam@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Wednesday, 23 March 2022 10.30
>=20
> All OS implementations provide the same main loop.
> Introduce helpers (shared for Linux and FreeBSD) to handle
> synchronisation
> between main and threads and factorize the rest as common code.
> Thread id are now logged as string in a common format across OS.
>=20
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> I had this patch in store for a long time.
> I don't particularly care about it, it's not fixing anything.
> But it seems a good cleanup/consolidation, so I rebased it and I am
> sending it to get feedback.
>=20

LGTM. I'm always in favor of cleaning up! :-)

Thank you, David.

Acked-By: Morten Br=F8rup <mb@smartsharesystems.com>