From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BF0C8A00BE;
	Wed, 20 Apr 2022 10:49:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 60AF74068E;
	Wed, 20 Apr 2022 10:49:49 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 99DD040687
 for <dev@dpdk.org>; Wed, 20 Apr 2022 10:49:48 +0200 (CEST)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v3 0/5] add telemetry command for show module EEPROM
Date: Wed, 20 Apr 2022 10:49:45 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86FE2@smartserver.smartshare.dk>
In-Reply-To: <20220420070017.119739-1-robinx.zhang@intel.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v3 0/5] add telemetry command for show module EEPROM
Thread-Index: AdhUhQV06hw9B4oBQNyrvNu9/Z6Y5QADKpKg
References: <20220215101853.919735-1-robinx.zhang@intel.com>
 <20220420070017.119739-1-robinx.zhang@intel.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Robin Zhang" <robinx.zhang@intel.com>,
	<dev@dpdk.org>
Cc: <qiming.yang@intel.com>, <qi.z.zhang@intel.com>, <stevex.yang@intel.com>,
 <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>,
 <bruce.richardson@intel.com>, <david.marchand@redhat.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Robin Zhang [mailto:robinx.zhang@intel.com]
> Sent: Wednesday, 20 April 2022 09.00
>=20
> Introduce a new telemetry command /ethdev/module_eeprom to show module
> EEPROM for each port. The format of module EEPROM information follows
> the SFF(Small Form Factor) Committee specifications.
>=20
> Current the format support SFP(Small Formfactor Pluggable)/SFP+/
> QSFP+(Quad Small Formfactor Pluggable)/QSFP28 with specs SFF-8079/
> SFF-8472/SFF-8024/SFF-8636.
>=20
> Afther run the /ethdev/module_eeprom command, both primary application
> and telemetry client will show the module EEPROM information. For
> primary application, we keep the same format with Linux utility
> ethtool,
> refer to command 'ethtool -m' of ethtool v5.4. For telemetry client,
> we record the key value pairs of each item, then show them in =
telemetry
> client dictionary.

This patch uses printf() a lot. It should only collect the data and give =
the data to the telemetry library, not printf() anything.

It is up to the application (which asked the telemetry library for the =
data) to determine how the data should be presented to the end user. =
E.g. the application could present the data in an SNMP packet, as the =
response to an SNMP request received by the application's SNMP agent. =
The separation of data and presentation is a key point of the telemetry =
library.

-Morten