From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 467D0A0506;
	Sat, 30 Apr 2022 09:20:54 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DCF524069D;
	Sat, 30 Apr 2022 09:20:53 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 946F64014F
 for <dev@dpdk.org>; Sat, 30 Apr 2022 09:20:52 +0200 (CEST)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [RFC v2] eal: allow worker lcore stacks to be allocated from
 hugepage memory
Date: Sat, 30 Apr 2022 09:20:49 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87011@smartserver.smartshare.dk>
In-Reply-To: <20220429200037.29114-1-donw@xsightlabs.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [RFC v2] eal: allow worker lcore stacks to be allocated from
 hugepage memory
Thread-Index: AdhcBAC3JQXWe6glSFW3u7+TY3BsgwAXYzqw
References: <20220426122000.24743-1-donw@xsightlabs.com>
 <20220429200037.29114-1-donw@xsightlabs.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Don Wallwork" <donw@xsightlabs.com>,
	<dev@dpdk.org>
Cc: <stephen@networkplumber.org>, <anatoly.burakov@intel.com>,
 <dmitry.kozliuk@gmail.com>, <bruce.richardson@intel.com>,
 <Honnappa.Nagarahalli@arm.com>, <nd@arm.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Don Wallwork [mailto:donw@xsightlabs.com]
> Sent: Friday, 29 April 2022 22.01
>=20
> Add support for using hugepages for worker lcore stack memory.  The
> intent is to improve performance by reducing stack memory related TLB
> misses and also by using memory local to the NUMA node of each lcore.
>=20
> EAL option '--huge-worker-stack [stack-size-kbytes]' is added to allow
> the feature to be enabled at runtime.  If the size is not specified,
> the system pthread stack size will be used.

It would be nice if DPDK EAL could parse size parameter values provided =
as "1M" or "128k"; but it is clearly not a requirement for this patch. =
Just mentioning it.

>=20
> Signed-off-by: Don Wallwork <donw@xsightlabs.com>
> ---

>  /**
>   * internal configuration
>   */
> @@ -102,6 +105,7 @@ struct internal_config {
>  	unsigned int no_telemetry; /**< true to disable Telemetry */
>  	struct simd_bitwidth max_simd_bitwidth;
>  	/**< max simd bitwidth path to use */
> +	size_t huge_worker_stack_size; /**< worker thread stack size in
> kbytes */

The command line parameter value has been converted from kbytes to bytes =
here, so this comment is wrong.

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>