From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: RE: [RFT 0/2] pie: floating point fixes
Date: Tue, 24 May 2022 21:31:24 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D870AB@smartserver.smartshare.dk> (raw)
In-Reply-To: <20220524184623.480646-1-stephen@networkplumber.org>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, 24 May 2022 20.46
>
> A couple of small untested changes to address some
> issues found while reviewing usage of random in DPDK.
>
> The PIE code should get rexamined in later release.
Untested fixes to seemingly untested code. What's not to like? ;-)
> It should not be exposing internal algorithm, that makes
> it brittle for ABI.
Agree. Just look at the mempool... an increasing amount of its internals are getting elevated to public API, so other code can understand and use its internals instead of going through its API. (My current pet peeve.)
>
> Also, no code in DPDK should ever be doing floating point
> math in the data path!
+1
>
> Stephen Hemminger (2):
> rte_pie: remove unnecessary floating point
> rte_pie: fix incorrect floating point math
This looks much better than what it replaces, so...
Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2022-05-24 19:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 18:46 Stephen Hemminger
2022-05-24 18:46 ` [RFT 1/2] rte_pie: remove unnecessary floating point Stephen Hemminger
2022-05-24 18:46 ` [RFT 2/2] rte_pie: fix incorrect floating point math Stephen Hemminger
2022-05-24 19:31 ` Morten Brørup [this message]
2022-05-24 22:18 ` [RFT v2 0/3] pie: fix random number issues Stephen Hemminger
2022-05-24 22:18 ` [RFT v2 1/3] random: add rte_rand_float() Stephen Hemminger
2022-05-25 11:55 ` Ray Kinsella
2022-05-25 14:45 ` Mattias Rönnblom
2022-05-25 15:26 ` Morten Brørup
2022-05-25 15:45 ` Stephen Hemminger
2022-05-25 15:47 ` Stephen Hemminger
2022-05-24 22:18 ` [RFT v2 2/3] rte_pie: remove unnecessary floating point Stephen Hemminger
2022-05-24 22:18 ` [RFT v2 3/3] rte_pie: fix incorrect floating point math Stephen Hemminger
2022-05-25 17:12 ` [PATCH v3 0/3] introduce random floating point function Stephen Hemminger
2022-05-25 17:12 ` [PATCH v3 1/3] random: add rte_drand() funciton Stephen Hemminger
2022-05-25 17:12 ` [PATCH v3 2/3] rte_pie: remove unnecessary floating point Stephen Hemminger
2022-05-25 17:12 ` [PATCH v3 3/3] rte_pie: fix incorrect floating point math Stephen Hemminger
2022-05-25 20:31 ` [PATCH v4 0/3] introduce random floating point function Stephen Hemminger
2022-05-25 20:31 ` [PATCH v4 1/3] random: add rte_drand() function Stephen Hemminger
2022-05-26 9:56 ` Ray Kinsella
2022-05-26 13:20 ` Mattias Rönnblom
2022-05-26 15:25 ` Stephen Hemminger
2022-05-26 15:28 ` Stephen Hemminger
2022-05-26 20:19 ` Stephen Hemminger
2022-05-25 20:31 ` [PATCH v4 2/3] rte_pie: remove unnecessary floating point Stephen Hemminger
2022-05-25 20:31 ` [PATCH v4 3/3] rte_pie: fix incorrect floating point math Stephen Hemminger
2022-05-26 7:06 ` [PATCH v4 0/3] introduce random floating point function Morten Brørup
2022-05-26 20:26 ` [PATCH v5 " Stephen Hemminger
2022-05-26 20:26 ` [PATCH v5 1/3] random: add rte_drand() function Stephen Hemminger
2022-05-26 20:26 ` [PATCH v5 2/3] rte_pie: remove unnecessary floating point Stephen Hemminger
2022-05-30 11:50 ` Dumitrescu, Cristian
2022-06-21 8:18 ` Singh, Jasvinder
2022-05-26 20:26 ` [PATCH v5 3/3] rte_pie: fix incorrect floating point math Stephen Hemminger
2022-05-30 11:50 ` Dumitrescu, Cristian
2022-06-21 8:18 ` Singh, Jasvinder
2022-06-22 9:21 ` [PATCH v5 0/3] introduce random floating point function Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D870AB@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).