From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2CDA9A0543;
	Tue, 24 May 2022 21:31:29 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D8DF3400EF;
	Tue, 24 May 2022 21:31:28 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 1EFE8400D6
 for <dev@dpdk.org>; Tue, 24 May 2022 21:31:27 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [RFT 0/2] pie: floating point fixes
Date: Tue, 24 May 2022 21:31:24 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D870AB@smartserver.smartshare.dk>
In-Reply-To: <20220524184623.480646-1-stephen@networkplumber.org>
X-MimeOLE: Produced By Microsoft Exchange V6.5
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [RFT 0/2] pie: floating point fixes
Thread-Index: AdhvnpeCzpT9Ea7yQzC26O3oMl5j6QAA7kvA
References: <20220524184623.480646-1-stephen@networkplumber.org>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
	<dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, 24 May 2022 20.46
>=20
> A couple of small untested changes to address some
> issues found while reviewing usage of random in DPDK.
>=20
> The PIE code should get rexamined in later release.

Untested fixes to seemingly untested code. What's not to like? ;-)

> It should not be exposing internal algorithm, that makes
> it brittle for ABI.

Agree. Just look at the mempool... an increasing amount of its internals =
are getting elevated to public API, so other code can understand and use =
its internals instead of going through its API. (My current pet peeve.)

>=20
> Also, no code in DPDK should ever be doing floating point
> math in the data path!

+1

>=20
> Stephen Hemminger (2):
>   rte_pie: remove unnecessary floating point
>   rte_pie: fix incorrect floating point math

This looks much better than what it replaces, so...

Series-acked-by: Morten Br=F8rup <mb@smartsharesystems.com>