From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83F7BA0543; Mon, 13 Jun 2022 12:01:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F27240150; Mon, 13 Jun 2022 12:01:31 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 2E3F9400EF for ; Mon, 13 Jun 2022 12:01:30 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] config: remove explicit undef of unset values X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Mon, 13 Jun 2022 12:01:28 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87118@smartserver.smartshare.dk> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] config: remove explicit undef of unset values Thread-Index: Adh/C5rpM/xs+N3mQT2Fptoo6OaC5AAANHmg References: <20211216111430.699717-1-bruce.richardson@intel.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" , Cc: , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Monday, 13 June 2022 11.55 > To: dev@dpdk.org > Cc: david.marchand@redhat.com; junx.dong@intel.com > Subject: Re: [PATCH] config: remove explicit undef of unset values >=20 > On Thu, Dec 16, 2021 at 11:14:30AM +0000, Bruce Richardson wrote: > > Rather than explicitly clearing any setting of undefined values in > our > > rte_config.h file, it's better to instead just add a comment that = the > > value is not set. Using a comment allows the user to set the value > using > > CFLAGS or similar mechanism without the config file clearing the > value > > again. > > > > The text used " is not set" is modelled after the kernel > approach > > of doing the same thing. > > > > Signed-off-by: Bruce Richardson > > --- > > > > Although DPDK coding convention forbids use of "//" for comments, > using > > regular C comment style makes the config settings less clear, as = they > can > > be confused with regular comments in the file. Using "//" makes them > stand > > out better, so I prefer it. However, if others feel strongly, they > can be > > changed to standard. > > > > Note: this is a resubmission of patch [1] which was part of a > rejected > > series. However, the reasons for rejection - values in config being > out > > of sync with those used for building apps - are less relevant for > > many, if not all, of these setting, so I believe the benefits for > > testing outweigh the potential downsides. If any setting is likely > > problematic, I can keep the explicit undef for that case in a new > patch > > version. > > > > [1] = http://patches.dpdk.org/project/dpdk/patch/20200903144942.671870- > 2-bruce.richardson@intel.com/ > > --- >=20 > Ping for review or feedback for this patch. I'd like to see it move > forward > into a DPDK release if possible. >=20 > /Bruce >=20 > > config/rte_config.h | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/config/rte_config.h b/config/rte_config.h > > index cab4390a97..953216babd 100644 > > --- a/config/rte_config.h > > +++ b/config/rte_config.h > > @@ -83,17 +83,17 @@ > > > > /* ip_fragmentation defines */ > > #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8 > > -#undef RTE_LIBRTE_IP_FRAG_TBL_STAT > > +// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set > > Yes, this is the right way to do it. Acked-by: Morten Br=F8rup