From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 56602A0548;
	Wed, 15 Jun 2022 15:55:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EE09040F1A;
	Wed, 15 Jun 2022 15:55:00 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 6A5AD40F19
 for <dev@dpdk.org>; Wed, 15 Jun 2022 15:54:59 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH 1/5] usertools: use non-strict when json-loads in telemetry
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Wed, 15 Jun 2022 15:54:57 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87126@smartserver.smartshare.dk>
In-Reply-To: <20220615073915.14041-2-fengchengwen@huawei.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH 1/5] usertools: use non-strict when json-loads in
 telemetry
Thread-Index: AdiAi/RqOyAEUZp0RCOVOQ/cprUBFAAMpTDg
References: <20220615073915.14041-1-fengchengwen@huawei.com>
 <20220615073915.14041-2-fengchengwen@huawei.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Chengwen Feng" <fengchengwen@huawei.com>, <thomas@monjalon.net>,
 <ferruh.yigit@xilinx.com>, <kevin.laatz@intel.com>,
 <bruce.richardson@intel.com>, <andrew.rybchenko@oktetlabs.ru>,
 <jerinj@marvell.com>, <sachin.saxena@oss.nxp.com>, <hemant.agrawal@nxp.com>
Cc: <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Chengwen Feng [mailto:fengchengwen@huawei.com]
> Sent: Wednesday, 15 June 2022 09.39
>=20
> Use 'strict=3DFalse' in json-loads, it will ignore control characters
> (e.g. '\n\t'), this patch is prepared for the support of telemetry =
dump
> in the future.
>=20
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>  usertools/dpdk-telemetry.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py
> index a81868a547..63f8004566 100755
> --- a/usertools/dpdk-telemetry.py
> +++ b/usertools/dpdk-telemetry.py
> @@ -27,7 +27,7 @@ def read_socket(sock, buf_len, echo=3DTrue):
>      """ Read data from socket and return it in JSON format """
>      reply =3D sock.recv(buf_len).decode()
>      try:
> -        ret =3D json.loads(reply)
> +        ret =3D json.loads(reply, strict=3DFalse)
>      except json.JSONDecodeError:
>          print("Error in reply: ", reply)
>          sock.close()
> --
> 2.33.0
>=20

As I understand this patch, it accepts non-JSON data from the telemetry =
socket.

Isn't it is a major protocol violation if the telemetry socket produces =
output requiring this modification? Doing that would break other =
applications expecting strictly JSON formatted output from the telemetry =
socket.